Patch Detail
Show a patch.
GET /api/patches/12593/?format=api
{ "id": 12593, "url": "https://patchwork.libcamera.org/api/patches/12593/?format=api", "web_url": "https://patchwork.libcamera.org/patch/12593/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210614122215.510562-1-hiroh@chromium.org>", "date": "2021-06-14T12:22:15", "name": "[libcamera-devel] libcamera: CameraSensorProperties: Add test pattern mode of imx258", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "2f8487f74426dc710db48dd9fbc15b2f20052656", "submitter": { "id": 63, "url": "https://patchwork.libcamera.org/api/people/63/?format=api", "name": "Hirokazu Honda", "email": "hiroh@chromium.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/12593/mbox/", "series": [ { "id": 2132, "url": "https://patchwork.libcamera.org/api/series/2132/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2132", "date": "2021-06-14T12:22:15", "name": "[libcamera-devel] libcamera: CameraSensorProperties: Add test pattern mode of imx258", "version": 1, "mbox": "https://patchwork.libcamera.org/series/2132/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/12593/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/12593/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BB279BD78E\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 14 Jun 2021 12:22:27 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 314DF68930;\n\tMon, 14 Jun 2021 14:22:27 +0200 (CEST)", "from mail-pj1-x102b.google.com (mail-pj1-x102b.google.com\n\t[IPv6:2607:f8b0:4864:20::102b])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 59EA7602A1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 14 Jun 2021 14:22:26 +0200 (CEST)", "by mail-pj1-x102b.google.com with SMTP id\n\tgo18-20020a17090b03d2b029016e4ae973f7so8947922pjb.0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 14 Jun 2021 05:22:26 -0700 (PDT)", "from hiroh2.tok.corp.google.com\n\t([2401:fa00:8f:203:dd3f:f6f0:e98e:863b])\n\tby smtp.gmail.com with ESMTPSA id\n\tk15sm18035964pjf.32.2021.06.14.05.22.23\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 14 Jun 2021 05:22:24 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"T/CVA3y8\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; h=from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=U4U8YIqo/X7UVd9msnqsf3YoyvJRqFOqgbeOmJNMkY0=;\n\tb=T/CVA3y88gl6GjnpblAzk4cT7gJEFfhGMxEpSREj60AzJUireA9ErbDmPIuLWpZ1wQ\n\tRCUqXQuZIo0ujFIaJdIbxNWArhf3Y6cz6bbg2MrVKQqp4swrXsOrKC6BRJtz0ESdk2tF\n\tqOzyHwiCufoVhA076yJS6mQd/C9ZcEr2c9SJ8=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=U4U8YIqo/X7UVd9msnqsf3YoyvJRqFOqgbeOmJNMkY0=;\n\tb=fQNY7sCGzvt/qqP3okzgvxt/jKEbQlrkkksJ5K+gMW1XdDOxXZpgJEFShVdFKu51BC\n\thV/U0iYTwBBky39nNBiNcob8tCtPocDI0fsu7LRJ7PCITpDQEACzPJ0HbXhkciS3pIkF\n\t7vqh0WvNOypqULQ2mn8E4YGeU9e83ts0X3ZQWoNyzWhKnIbJDLKM//qhvl9H0dtFS1oZ\n\tk0N8FH94fB+qO54kC6Lf0s5bAOo7u/qHWWe9ullCaMNrYXzXxkef5+p3bLUOePnR/BJ/\n\tGUxyUMNjQ+9Dawn6quf8ajwiC+dkKmTKY1ITzZQJYrtITgZ20HCnGzOCXZB/vXe009CQ\n\t7IOA==", "X-Gm-Message-State": "AOAM533rK6t0ps20XtVkGMTJyE3kMjVhvPp0+thV8zj3yn188EPnjD9o\n\tTgp3M+hzWbPMfepjLo5xcB9nMSt3pHKyZA==", "X-Google-Smtp-Source": "ABdhPJyg+6D5vAaddUXGHeh01+NWV8VeT4nJ2R25w6v06Nzej2RASmJxetwyomkcgN795EQCCc0XZQ==", "X-Received": "by 2002:a17:90b:1048:: with SMTP id\n\tgq8mr23896595pjb.213.1623673344490; \n\tMon, 14 Jun 2021 05:22:24 -0700 (PDT)", "From": "Hirokazu Honda <hiroh@chromium.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 14 Jun 2021 21:22:15 +0900", "Message-Id": "<20210614122215.510562-1-hiroh@chromium.org>", "X-Mailer": "git-send-email 2.32.0.272.g935e593368-goog", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH] libcamera: CameraSensorProperties: Add\n\ttest pattern mode of imx258", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add supported test pattern modes of imx258 in CameraSensorProperties.\n\nSigned-off-by: Hirokazu Honda <hiroh@chromium.org>\n---\n src/libcamera/camera_sensor_properties.cpp | 8 +++++++-\n 1 file changed, 7 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/camera_sensor_properties.cpp b/src/libcamera/camera_sensor_properties.cpp\nindex f660743a..afa59b82 100644\n--- a/src/libcamera/camera_sensor_properties.cpp\n+++ b/src/libcamera/camera_sensor_properties.cpp\n@@ -65,7 +65,13 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n \t\t{ \"imx258\", {\n \t\t\t.unitCellSize = { 1120, 1120 },\n \t\t\t/* \\todo fill test pattern modes for imx258. */\n-\t\t\t.testPatternModes = {},\n+\t\t\t.testPatternModes = {\n+\t\t\t\t{0, controls::draft::TestPatternModeOff },\n+\t\t\t\t{1, controls::draft::TestPatternModeSolidColor},\n+\t\t\t\t{2, controls::draft::TestPatternModeColorBars},\n+\t\t\t\t{3, controls::draft::TestPatternModeColorBarsFadeToGray},\n+\t\t\t\t{4, controls::draft::TestPatternModePn9},\n+\t\t\t},\n \t\t} },\n \t\t{ \"ov5670\", {\n \t\t\t.unitCellSize = { 1120, 1120 },\n", "prefixes": [ "libcamera-devel" ] }