Patch Detail
Show a patch.
GET /api/patches/12591/?format=api
{ "id": 12591, "url": "https://patchwork.libcamera.org/api/patches/12591/?format=api", "web_url": "https://patchwork.libcamera.org/patch/12591/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210614104553.497626-1-hiroh@chromium.org>", "date": "2021-06-14T10:45:53", "name": "[libcamera-devel,RFC] android: camera_device: Drop HAL_PIXEL_FORMAT_RAW_OPAQUE support", "commit_ref": "1fea2730a162905794277b7c21dee283c9cd3a02", "pull_url": null, "state": "accepted", "archived": false, "hash": "4911af60c06c5d03bf1ccc750f8160aadd80478a", "submitter": { "id": 63, "url": "https://patchwork.libcamera.org/api/people/63/?format=api", "name": "Hirokazu Honda", "email": "hiroh@chromium.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/12591/mbox/", "series": [ { "id": 2130, "url": "https://patchwork.libcamera.org/api/series/2130/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2130", "date": "2021-06-14T10:45:53", "name": "[libcamera-devel,RFC] android: camera_device: Drop HAL_PIXEL_FORMAT_RAW_OPAQUE support", "version": 1, "mbox": "https://patchwork.libcamera.org/series/2130/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/12591/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/12591/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5D269BD78E\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 14 Jun 2021 10:46:07 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B1BAC602A1;\n\tMon, 14 Jun 2021 12:46:06 +0200 (CEST)", "from mail-pf1-x42a.google.com (mail-pf1-x42a.google.com\n\t[IPv6:2607:f8b0:4864:20::42a])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B3BDB6029D\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 14 Jun 2021 12:46:04 +0200 (CEST)", "by mail-pf1-x42a.google.com with SMTP id x16so6044466pfa.13\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 14 Jun 2021 03:46:04 -0700 (PDT)", "from hiroh2.tok.corp.google.com\n\t([2401:fa00:8f:203:dd3f:f6f0:e98e:863b])\n\tby smtp.gmail.com with ESMTPSA id\n\tu38sm1818366pgm.14.2021.06.14.03.46.01\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 14 Jun 2021 03:46:02 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"MF+1znDv\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; h=from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=AiHAs+ml7IWXYb179n3+tNAePt8bdUQ6p/7KDXuddNc=;\n\tb=MF+1znDvQsIKiyA1aO0LfhGNnOZik3xZrInTOKV0iZuN0y3k8dFn6zXlilRPrVNogU\n\tgNZJbKUGhmf1B2gamoFg1TITinaKUIAz5TtXx4Y9/dCPu0sD/DwEQ4mvEddEXxFRBzsp\n\tUEa+y4q3l+cw30gidaIgL63JHnEg+mLJw54pc=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=AiHAs+ml7IWXYb179n3+tNAePt8bdUQ6p/7KDXuddNc=;\n\tb=ZLCuQiPzKNsYxUnDamjBd9HH+1JKmaHPgwdSZ171LqA9I5kc8KRd733/fp7ZY73d14\n\tU1TqCZKkTeT87EahhiS7/OBvENC6V+CCI81gAi42NFfh4pQ81O5PXwT8i7kr6UndSOYi\n\tdUJAuQ1Qla+2qZigsQlPstj+GVGeNFD0tnQYoIhcCEn/7ndRpUudz8W2DlpVQqITLcbt\n\tdXL6eoThk4t/uJZOhljC6TC3ElNCbJbuB0kkCmSk0xgzVLeSA1LgKrsQueRg0AhS/egS\n\t8oIZ4gx54LhiXozTaDTVwRUQUqcKOcoR2tTt6jw5yh2d/526Y6XANnAxopQIGVyh5F4I\n\tO3Pw==", "X-Gm-Message-State": "AOAM531CNhNSgX+cHq7sNkL/ZAiQuoi84n12T+uy3Mi0xwd9lxBeQbhC\n\tAF6drBXQaSNq5JNTy8D9iBgLqx3KHWEDbQ==", "X-Google-Smtp-Source": "ABdhPJxTwHx6AsNCwI7JMFmuSnGazGvDVh0ttEEzEURuMfmyRX86e3HVoKcBaL6lOlfo5HL7yRs/FQ==", "X-Received": "by 2002:a63:de02:: with SMTP id f2mr16588448pgg.32.1623667562812;\n\tMon, 14 Jun 2021 03:46:02 -0700 (PDT)", "From": "Hirokazu Honda <hiroh@chromium.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 14 Jun 2021 19:45:53 +0900", "Message-Id": "<20210614104553.497626-1-hiroh@chromium.org>", "X-Mailer": "git-send-email 2.32.0.272.g935e593368-goog", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [RFC PATCH] android: camera_device: Drop\n\tHAL_PIXEL_FORMAT_RAW_OPAQUE support", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "HAL_PIXEL_FORMAT_RAW_OPAQUE is requested only for\nZero-Shutter-Lag (ZSL). ZSL requires RAW and YUV reprocessing.\nSince either of them is not supported by libcamera, supporting\nRAW_OPAQUE format doesn't make sense. Drop the format from the\nsupported format list.\n\nSigned-off-by: Hirokazu Honda <hiroh@chromium.org>\n---\n src/android/camera_device.cpp | 11 -----------\n 1 file changed, 11 deletions(-)", "diff": "diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\nindex fe332ec3..14022aed 100644\n--- a/src/android/camera_device.cpp\n+++ b/src/android/camera_device.cpp\n@@ -120,17 +120,6 @@ const std::map<int, const Camera3Format> camera3FormatsMap = {\n \t\t\tfalse,\n \t\t\t\"RAW16\"\n \t\t}\n-\t}, {\n-\t\tHAL_PIXEL_FORMAT_RAW_OPAQUE, {\n-\t\t\t{\n-\t\t\t\tformats::SBGGR10_IPU3,\n-\t\t\t\tformats::SGBRG10_IPU3,\n-\t\t\t\tformats::SGRBG10_IPU3,\n-\t\t\t\tformats::SRGGB10_IPU3\n-\t\t\t},\n-\t\t\tfalse,\n-\t\t\t\"RAW_OPAQUE\"\n-\t\t}\n \t},\n };\n \n", "prefixes": [ "libcamera-devel", "RFC" ] }