Patch Detail
Show a patch.
GET /api/patches/12499/?format=api
{ "id": 12499, "url": "https://patchwork.libcamera.org/api/patches/12499/?format=api", "web_url": "https://patchwork.libcamera.org/patch/12499/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210607011402.55331-6-hiroh@chromium.org>", "date": "2021-06-07T01:14:02", "name": "[libcamera-devel,v7,6/6] android: CameraDevice: Report queried test pattern modes", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "06df6e463ad2e9b5cf063b70bbea7e68417c3e80", "submitter": { "id": 63, "url": "https://patchwork.libcamera.org/api/people/63/?format=api", "name": "Hirokazu Honda", "email": "hiroh@chromium.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/12499/mbox/", "series": [ { "id": 2105, "url": "https://patchwork.libcamera.org/api/series/2105/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2105", "date": "2021-06-07T01:13:57", "name": "[libcamera-devel,v7,1/6] libcamera: controls: Add sensor test pattern mode", "version": 7, "mbox": "https://patchwork.libcamera.org/series/2105/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/12499/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/12499/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 794C1C320B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 7 Jun 2021 01:14:19 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3EC706892D;\n\tMon, 7 Jun 2021 03:14:19 +0200 (CEST)", "from mail-pj1-x1031.google.com (mail-pj1-x1031.google.com\n\t[IPv6:2607:f8b0:4864:20::1031])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6EB3268931\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 7 Jun 2021 03:14:17 +0200 (CEST)", "by mail-pj1-x1031.google.com with SMTP id i22so8847624pju.0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 06 Jun 2021 18:14:17 -0700 (PDT)", "from hiroh2.tok.corp.google.com\n\t([2401:fa00:8f:203:6eb1:2d91:79ee:2043])\n\tby smtp.gmail.com with ESMTPSA id\n\th12sm7303655pgn.54.2021.06.06.18.14.14\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tSun, 06 Jun 2021 18:14:15 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"a6WkK9dd\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=hqu8pksEUVvipvwGZ2F8p2REk5PKW/IuLTrKzsk2/go=;\n\tb=a6WkK9ddx0XgdFAnaL+lD4BfuoULMdt+8uy1dgq9bMGe5lfxjEOW/WHJy9bepcqJYD\n\tKl0NPQ6soPOXG9yguwWXZUKHTvTDL3HOP/TwX2Wc1bZg2Ur9Gew8JYQSGv7s4B7SJNwW\n\tx4ZFdm5f+HL202AJN7aBC1XNPAAB2l57hcrNI=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=hqu8pksEUVvipvwGZ2F8p2REk5PKW/IuLTrKzsk2/go=;\n\tb=WTSUGefdI0Sd0+vcCHYXlNhfsB5eB1nuern9dZqPNuX4rRgbUESo2DGwZRvC/3ou3z\n\tzrDr0m55InFAr1yi9O1aVcaTQoP57TLu6TYV4QLmbx5lg78HO/PPsY7A5ECh9ZBomvKL\n\t9L1x2uv9jaTwbP41a6xywESfVmCQevbqIqaFcXQCg7FTN802GRccHxvYg/hWF08GHH6y\n\tGpFpFAiLQQbsogH2cHyyEVW8YiXHcAohqqWrD01Zfb0UJNPjd6UIvBMOL27fmqOuaEF6\n\tNf/13++IbI7Sh3C4XIg4yIe2hwK3iFqC+gA+/3FaMtCPLgEVu9YsrEwXw0MyjypvzPjD\n\tHZPw==", "X-Gm-Message-State": "AOAM533PX0I7s3ilo3PnfH0cHHqprxsNvF4BwKkFK2G4ifVcRg7ovJOQ\n\tYj6MK7PGEo6WjRowPnXJdMlnBWCXYVcu3lcb", "X-Google-Smtp-Source": "ABdhPJw9243EclzvWVMwGIPT4VMQixng9SPb2Q95E8NEqAE3mNIVRP+ZEMDPbN5l745cnfHUVcAp7Q==", "X-Received": "by 2002:a17:90b:e8a:: with SMTP id\n\tfv10mr26508620pjb.160.1623028455801; \n\tSun, 06 Jun 2021 18:14:15 -0700 (PDT)", "From": "Hirokazu Honda <hiroh@chromium.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 7 Jun 2021 10:14:02 +0900", "Message-Id": "<20210607011402.55331-6-hiroh@chromium.org>", "X-Mailer": "git-send-email 2.32.0.rc1.229.g3e70b5a671-goog", "In-Reply-To": "<20210607011402.55331-1-hiroh@chromium.org>", "References": "<20210607011402.55331-1-hiroh@chromium.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v7 6/6] android: CameraDevice: Report\n\tqueried test pattern modes", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Report to the Android camera stack the list of supported test\npattern modes constructed by inspecting the values reported\nby libcamera through the controls::draft::TestPatternMode control.\n\nSigned-off-by: Hirokazu Honda <hiroh@chromium.org>\nReviewed-by: Jacopo Mondi <jacopo@jmondi.org>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/android/camera_device.cpp | 51 ++++++++++++++++++++++++++++++++---\n 1 file changed, 48 insertions(+), 3 deletions(-)", "diff": "diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\nindex fe332ec3..5e961003 100644\n--- a/src/android/camera_device.cpp\n+++ b/src/android/camera_device.cpp\n@@ -1083,11 +1083,56 @@ const camera_metadata_t *CameraDevice::getStaticMetadata()\n \n \tstaticMetadata_->addEntry(ANDROID_SENSOR_ORIENTATION, orientation_);\n \n-\tstd::vector<int32_t> testPatterModes = {\n-\t\tANDROID_SENSOR_TEST_PATTERN_MODE_OFF,\n+\tstd::vector<int32_t> testPatternModes = {\n+\t\tANDROID_SENSOR_TEST_PATTERN_MODE_OFF\n \t};\n+\tconst auto &testPatternsInfo =\n+\t\tcontrolsInfo.find(&controls::draft::TestPatternMode);\n+\tif (testPatternsInfo != controlsInfo.end()) {\n+\t\tconst auto &values = testPatternsInfo->second.values();\n+\t\tASSERT(!values.empty());\n+\t\tfor (const auto &value : values) {\n+\t\t\tswitch (value.get<int32_t>()) {\n+\t\t\tcase controls::draft::TestPatternModeOff:\n+\t\t\t\t/*\n+\t\t\t\t * ANDROID_SENSOR_TEST_PATTERN_MODE_OFF is\n+\t\t\t\t * already in testPatternModes.\n+\t\t\t\t */\n+\t\t\t\tbreak;\n+\n+\t\t\tcase controls::draft::TestPatternModeSolidColor:\n+\t\t\t\ttestPatternModes.push_back(\n+\t\t\t\t\tANDROID_SENSOR_TEST_PATTERN_MODE_SOLID_COLOR);\n+\t\t\t\tbreak;\n+\n+\t\t\tcase controls::draft::TestPatternModeColorBars:\n+\t\t\t\ttestPatternModes.push_back(\n+\t\t\t\t\tANDROID_SENSOR_TEST_PATTERN_MODE_COLOR_BARS);\n+\t\t\t\tbreak;\n+\n+\t\t\tcase controls::draft::TestPatternModeColorBarsFadeToGray:\n+\t\t\t\ttestPatternModes.push_back(\n+\t\t\t\t\tANDROID_SENSOR_TEST_PATTERN_MODE_COLOR_BARS_FADE_TO_GRAY);\n+\t\t\t\tbreak;\n+\n+\t\t\tcase controls::draft::TestPatternModePn9:\n+\t\t\t\ttestPatternModes.push_back(\n+\t\t\t\t\tANDROID_SENSOR_TEST_PATTERN_MODE_PN9);\n+\t\t\t\tbreak;\n+\n+\t\t\tcase controls::draft::TestPatternModeCustom1:\n+\t\t\t\t/* We don't support this yet. */\n+\t\t\t\tbreak;\n+\n+\t\t\tdefault:\n+\t\t\t\tLOG(HAL, Error) << \"Unknown test pattern mode: \"\n+\t\t\t\t\t\t<< value.get<int32_t>();\n+\t\t\t\tcontinue;\n+\t\t\t}\n+\t\t}\n+\t}\n \tstaticMetadata_->addEntry(ANDROID_SENSOR_AVAILABLE_TEST_PATTERN_MODES,\n-\t\t\t\t testPatterModes);\n+\t\t\t\t testPatternModes);\n \n \tuint8_t timestampSource = ANDROID_SENSOR_INFO_TIMESTAMP_SOURCE_UNKNOWN;\n \tstaticMetadata_->addEntry(ANDROID_SENSOR_INFO_TIMESTAMP_SOURCE,\n", "prefixes": [ "libcamera-devel", "v7", "6/6" ] }