Patch Detail
Show a patch.
GET /api/patches/12486/?format=api
{ "id": 12486, "url": "https://patchwork.libcamera.org/api/patches/12486/?format=api", "web_url": "https://patchwork.libcamera.org/patch/12486/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210602102326.106549-4-umang.jain@ideasonboard.com>", "date": "2021-06-02T10:23:25", "name": "[libcamera-devel,3/4] ipa: ipu3: Copy IPACameraSensorInfo for future usage", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "4ba59cfd9eee0c37c751629f5a5bee75c58bc60e", "submitter": { "id": 86, "url": "https://patchwork.libcamera.org/api/people/86/?format=api", "name": "Umang Jain", "email": "umang.jain@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/12486/mbox/", "series": [ { "id": 2100, "url": "https://patchwork.libcamera.org/api/series/2100/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2100", "date": "2021-06-02T10:23:22", "name": "IPAIPU3 drive-by improvements", "version": 1, "mbox": "https://patchwork.libcamera.org/series/2100/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/12486/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/12486/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BE2C2C3208\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 2 Jun 2021 10:23:44 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 831EC602AF;\n\tWed, 2 Jun 2021 12:23:44 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D89B16050E\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 2 Jun 2021 12:23:42 +0200 (CEST)", "from perceval.ideasonboard.com (unknown [103.251.226.189])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A42784A5;\n\tWed, 2 Jun 2021 12:23:41 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"BRYFzvn6\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1622629422;\n\tbh=e8oBXTN623xZPGO/xDSa8+LGPhWI+SbMGHcd707iDa0=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=BRYFzvn6mJYW7suY0cHsTNZ1ZyhVkCRvZeBcBW89DOXd3N/F2wrLijrbtH97ilbZ1\n\tSUjsBcx4fkQ8Qcnz0k7xKD7bXyQ0REtBjzOy1+BKBOn5f61WDAifTAKydAcqdHwAG5\n\tMu4rIiHZZwwlHPey1Ht3i/DtHGVwmuwnL/cxmBz4=", "From": "Umang Jain <umang.jain@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 2 Jun 2021 15:53:25 +0530", "Message-Id": "<20210602102326.106549-4-umang.jain@ideasonboard.com>", "X-Mailer": "git-send-email 2.31.1", "In-Reply-To": "<20210602102326.106549-1-umang.jain@ideasonboard.com>", "References": "<20210602102326.106549-1-umang.jain@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 3/4] ipa: ipu3: Copy IPACameraSensorInfo\n\tfor future usage", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "IPACameraSensorInfo members will be needed at various places in the\nIPAIPU3 class, in subsequent commits. Hence, it seems trivial to copy\nthis structure for wider availability throughout the class.\n\nThis commit does not introduce any functional changes.\n\nSigned-off-by: Umang Jain <umang.jain@ideasonboard.com>\n---\n src/ipa/ipu3/ipu3.cpp | 6 +++++-\n 1 file changed, 5 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\nindex 2496b0a0..97ddb863 100644\n--- a/src/ipa/ipu3/ipu3.cpp\n+++ b/src/ipa/ipu3/ipu3.cpp\n@@ -63,6 +63,8 @@ private:\n \n \tControlInfoMap ctrls_;\n \n+\tIPACameraSensorInfo sensorInfo_;\n+\n \t/* Camera sensor controls. */\n \tuint32_t exposure_;\n \tuint32_t minExposure_;\n@@ -144,6 +146,8 @@ void IPAIPU3::configure(const IPAConfigInfo &configInfo)\n \tif (configInfo.entityControls.empty())\n \t\treturn;\n \n+\tsensorInfo_ = configInfo.sensorInfo;\n+\n \tctrls_ = configInfo.entityControls.at(0);\n \n \tconst auto itExp = ctrls_.find(V4L2_CID_EXPOSURE);\n@@ -174,7 +178,7 @@ void IPAIPU3::configure(const IPAConfigInfo &configInfo)\n \tawbAlgo_->initialise(params_, configInfo.bdsOutputSize, bdsGrid_);\n \n \tagcAlgo_ = std::make_unique<IPU3Agc>();\n-\tagcAlgo_->initialise(bdsGrid_, configInfo.sensorInfo);\n+\tagcAlgo_->initialise(bdsGrid_, sensorInfo_);\n }\n \n void IPAIPU3::mapBuffers(const std::vector<IPABuffer> &buffers)\n", "prefixes": [ "libcamera-devel", "3/4" ] }