Patch Detail
Show a patch.
GET /api/patches/12432/?format=api
{ "id": 12432, "url": "https://patchwork.libcamera.org/api/patches/12432/?format=api", "web_url": "https://patchwork.libcamera.org/patch/12432/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210527010149.30601-1-laurent.pinchart@ideasonboard.com>", "date": "2021-05-27T01:01:48", "name": "[libcamera-devel,1/2] android: Don't rely on indirect inclusion of unistd.h", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "22deb58808c0df9333682cf4df24876434b82b71", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/12432/mbox/", "series": [ { "id": 2076, "url": "https://patchwork.libcamera.org/api/series/2076/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2076", "date": "2021-05-27T01:01:48", "name": "[libcamera-devel,1/2] android: Don't rely on indirect inclusion of unistd.h", "version": 1, "mbox": "https://patchwork.libcamera.org/series/2076/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/12432/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/12432/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D6831BDB80\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 27 May 2021 01:02:03 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 17F5268924;\n\tThu, 27 May 2021 03:02:03 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D1D006050E\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 27 May 2021 03:02:01 +0200 (CEST)", "from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 56288124E\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 27 May 2021 03:02:01 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"fXkXDMjW\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1622077321;\n\tbh=KcSF8v+kDv4XUSu7x7HEcq+kRgaI7jHNCZ+gc6z3Cn0=;\n\th=From:To:Subject:Date:From;\n\tb=fXkXDMjWS/3xJQEsqOxiVj9BQQVbNs/uFRCl/OFRUWqO+ODXBfb93AqoR7HM2b7uV\n\tZn8TGmUdYorn2drQIwf8aK8Gn/88mUpNJjQiVy0AGDjGTurzEITujVfCtdTKzKCozb\n\t4IeJ+rT9/K32cKQokG6x1GnebHC2G9opxITl+Eio=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 27 May 2021 04:01:48 +0300", "Message-Id": "<20210527010149.30601-1-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.28.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 1/2] android: Don't rely on indirect\n\tinclusion of unistd.h", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The standard C library close() and lseek() functions require inclusion\nof the unistd.h header. Include it explicitly where needed instead of\nrelying on indirect inclusion.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/android/camera_device.cpp | 1 +\n src/android/camera_worker.cpp | 1 +\n src/android/mm/generic_camera_buffer.cpp | 2 ++\n 3 files changed, 4 insertions(+)", "diff": "diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\nindex 7fc4ddb024c1..81509f57d1b7 100644\n--- a/src/android/camera_device.cpp\n+++ b/src/android/camera_device.cpp\n@@ -15,6 +15,7 @@\n #include <fstream>\n #include <sys/mman.h>\n #include <tuple>\n+#include <unistd.h>\n #include <vector>\n \n #include <libcamera/control_ids.h>\ndiff --git a/src/android/camera_worker.cpp b/src/android/camera_worker.cpp\nindex 9f727826e23f..98dddd9eb13b 100644\n--- a/src/android/camera_worker.cpp\n+++ b/src/android/camera_worker.cpp\n@@ -10,6 +10,7 @@\n #include <errno.h>\n #include <string.h>\n #include <sys/poll.h>\n+#include <unistd.h>\n \n #include \"camera_device.h\"\n \ndiff --git a/src/android/mm/generic_camera_buffer.cpp b/src/android/mm/generic_camera_buffer.cpp\nindex 334498c1867f..cca88cf3632f 100644\n--- a/src/android/mm/generic_camera_buffer.cpp\n+++ b/src/android/mm/generic_camera_buffer.cpp\n@@ -7,6 +7,8 @@\n \n #include \"../camera_buffer.h\"\n \n+#include <unistd.h>\n+\n #include \"libcamera/internal/buffer.h\"\n #include \"libcamera/internal/log.h\"\n \n", "prefixes": [ "libcamera-devel", "1/2" ] }