Patch Detail
Show a patch.
GET /api/patches/12430/?format=api
{ "id": 12430, "url": "https://patchwork.libcamera.org/api/patches/12430/?format=api", "web_url": "https://patchwork.libcamera.org/patch/12430/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210526131025.675024-2-umang.jain@ideasonboard.com>", "date": "2021-05-26T13:10:24", "name": "[libcamera-devel,v2,1/2] pipeline: ipu3: Fix mis-aligned comment", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "460a9374b56d009270758c07c52bbeb1a65b20b4", "submitter": { "id": 86, "url": "https://patchwork.libcamera.org/api/people/86/?format=api", "name": "Umang Jain", "email": "umang.jain@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/12430/mbox/", "series": [ { "id": 2075, "url": "https://patchwork.libcamera.org/api/series/2075/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2075", "date": "2021-05-26T13:10:23", "name": "ipa: ipu3: Provide frame timestamps through IPU3Event", "version": 2, "mbox": "https://patchwork.libcamera.org/series/2075/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/12430/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/12430/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5E3E6BDB80\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 26 May 2021 13:10:38 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1F6E7602AE;\n\tWed, 26 May 2021 15:10:38 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5BC22602AE\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 26 May 2021 15:10:36 +0200 (CEST)", "from perceval.ideasonboard.com (unknown [103.251.226.203])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CF4BD908;\n\tWed, 26 May 2021 15:10:34 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"RnlZO4Ol\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1622034636;\n\tbh=+viFu0qZtoXR4pjb++Fj8ISOqZ7BSrXCytT4G53qSGY=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=RnlZO4OlL9Va5KxsjuoHRur96VoO5YHk8c0QYv5Y3Ge7YuI6dO6w/vhvuC5VEvDZY\n\tsucuz3FkKF8p/NoemzlKyYEg4rThwweQNAnTp9feIrZOVA4tzo9XCMZLbiO74TWuCZ\n\tjTZBSbHb647/X+EtTd+YWk7wnBRZRNucza1btspg=", "From": "Umang Jain <umang.jain@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 26 May 2021 18:40:24 +0530", "Message-Id": "<20210526131025.675024-2-umang.jain@ideasonboard.com>", "X-Mailer": "git-send-email 2.26.2", "In-Reply-To": "<20210526131025.675024-1-umang.jain@ideasonboard.com>", "References": "<20210526131025.675024-1-umang.jain@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2 1/2] pipeline: ipu3: Fix mis-aligned\n\tcomment", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Fixes: 2fac95b400b7 (\"libcamera: pipeline: ipu3: Ensure that IPU3Frames::info is not used after delete\")\nSigned-off-by: Umang Jain <umang.jain@ideasonboard.com>\n---\n src/libcamera/pipeline/ipu3/ipu3.cpp | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)", "diff": "diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\nindex 25203256..750880ed 100644\n--- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n+++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n@@ -1361,9 +1361,9 @@ void IPU3CameraData::statBufferReady(FrameBuffer *buffer)\n \t\tinfo->metadataProcessed = true;\n \n \t\t/*\n-\t\t* tryComplete() will delete info if it completes the IPU3Frame.\n-\t\t* In that event, we must have obtained the Request before hand.\n-\t\t*/\n+\t\t * tryComplete() will delete info if it completes the IPU3Frame.\n+\t\t * In that event, we must have obtained the Request before hand.\n+\t\t */\n \t\tRequest *request = info->request;\n \n \t\tif (frameInfos_.tryComplete(info))\n", "prefixes": [ "libcamera-devel", "v2", "1/2" ] }