Patch Detail
Show a patch.
GET /api/patches/1242/?format=api
{ "id": 1242, "url": "https://patchwork.libcamera.org/api/patches/1242/?format=api", "web_url": "https://patchwork.libcamera.org/patch/1242/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20190521164536.20920-1-laurent.pinchart@ideasonboard.com>", "date": "2019-05-21T16:45:36", "name": "[libcamera-devel] libcamera: Auto-generate libcamera.h", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "0bbd6fbc30b3a82481d30546113e7935b8fbfb16", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/1242/mbox/", "series": [ { "id": 312, "url": "https://patchwork.libcamera.org/api/series/312/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=312", "date": "2019-05-21T16:45:36", "name": "[libcamera-devel] libcamera: Auto-generate libcamera.h", "version": 1, "mbox": "https://patchwork.libcamera.org/series/312/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/1242/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/1242/checks/", "tags": {}, "headers": { "Return-Path": "<laurent.pinchart@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7922060C27\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 21 May 2019 18:46:00 +0200 (CEST)", "from pendragon.bb.dnainternet.fi\n\t(dfj612yhrgyx302h3jwwy-3.rev.dnainternet.fi\n\t[IPv6:2001:14ba:21f5:5b00:ce28:277f:58d7:3ca4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id EF99D52C\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 21 May 2019 18:45:59 +0200 (CEST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1558457160;\n\tbh=MeDZVV0J/CKYNMvNqRVNUZoYDjkPncsaQF7SPbZ/oS8=;\n\th=From:To:Subject:Date:From;\n\tb=iPZkieY+TANIzDaUTyIYKO6lJJqy81TE6f4EThBvo7VMw5fLY1+laNykIgfTA8yJs\n\tlW3z4pgkDgosmWZL5GjXzmgHRO1pG6BbRqqIdbkeFtu1zTVn19/uZEHl1tO+girM4m\n\tyM7RrDeLl1i+rj5a1/Ycyt679EOnuLyYY3mHrkjI=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 21 May 2019 19:45:36 +0300", "Message-Id": "<20190521164536.20920-1-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.21.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH] libcamera: Auto-generate libcamera.h", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Tue, 21 May 2019 16:46:00 -0000" }, "content": "As shown by two missing includes, keeping the libcamera.h file in sync\nwhen adding or removing headers is an error-prone manual process.\nAutomate it by generating the header automatically.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n include/libcamera/gen-header.sh | 26 ++++++++++++++++++++++++++\n include/libcamera/libcamera.h | 20 --------------------\n include/libcamera/meson.build | 10 +++++++++-\n 3 files changed, 35 insertions(+), 21 deletions(-)\n create mode 100755 include/libcamera/gen-header.sh\n delete mode 100644 include/libcamera/libcamera.h", "diff": "diff --git a/include/libcamera/gen-header.sh b/include/libcamera/gen-header.sh\nnew file mode 100755\nindex 000000000000..ea5b79a62520\n--- /dev/null\n+++ b/include/libcamera/gen-header.sh\n@@ -0,0 +1,26 @@\n+#!/bin/sh\n+\n+src_dir=$1\n+dst_file=$2\n+\n+cat <<EOF > $dst_file\n+/* SPDX-License-Identifier: LGPL-2.1-or-later */\n+/* This file is auto-generated, do not edit! */\n+/*\n+ * Copyright (C) 2018, Google Inc.\n+ *\n+ * libcamera.h - libcamera public API\n+ */\n+#ifndef __LIBCAMERA_LIBCAMERA_H__\n+#define __LIBCAMERA_LIBCAMERA_H__\n+\n+EOF\n+\n+for header in $src_dir/*.h ; do\n+\techo \"#include <libcamera/$(basename $header)>\" >> $dst_file\n+done\n+\n+cat <<EOF >> $dst_file\n+\n+#endif /* __LIBCAMERA_LIBCAMERA_H__ */\n+EOF\ndiff --git a/include/libcamera/libcamera.h b/include/libcamera/libcamera.h\ndeleted file mode 100644\nindex dda576e906fb..000000000000\n--- a/include/libcamera/libcamera.h\n+++ /dev/null\n@@ -1,20 +0,0 @@\n-/* SPDX-License-Identifier: LGPL-2.1-or-later */\n-/*\n- * Copyright (C) 2018, Google Inc.\n- *\n- * libcamera.h - libcamera public API\n- */\n-#ifndef __LIBCAMERA_LIBCAMERA_H__\n-#define __LIBCAMERA_LIBCAMERA_H__\n-\n-#include <libcamera/buffer.h>\n-#include <libcamera/camera.h>\n-#include <libcamera/camera_manager.h>\n-#include <libcamera/event_dispatcher.h>\n-#include <libcamera/event_notifier.h>\n-#include <libcamera/request.h>\n-#include <libcamera/signal.h>\n-#include <libcamera/stream.h>\n-#include <libcamera/timer.h>\n-\n-#endif /* __LIBCAMERA_LIBCAMERA_H__ */\ndiff --git a/include/libcamera/meson.build b/include/libcamera/meson.build\nindex 83d226ac5078..46aff0b6bc2f 100644\n--- a/include/libcamera/meson.build\n+++ b/include/libcamera/meson.build\n@@ -5,7 +5,6 @@ libcamera_api = files([\n 'event_dispatcher.h',\n 'event_notifier.h',\n 'geometry.h',\n- 'libcamera.h',\n 'object.h',\n 'request.h',\n 'signal.h',\n@@ -13,5 +12,14 @@ libcamera_api = files([\n 'timer.h',\n ])\n \n+gen_header = join_paths(meson.current_source_dir(), 'gen-header.sh')\n+\n+custom_target('gen-header',\n+\t input: meson.current_source_dir(),\n+ output: 'libcamera.h',\n+\t command: [gen_header, '@INPUT@', '@OUTPUT@'],\n+\t install: true,\n+\t install_dir: 'include/libcamera')\n+\n install_headers(libcamera_api,\n subdir : 'libcamera')\n", "prefixes": [ "libcamera-devel" ] }