Patch Detail
Show a patch.
GET /api/patches/12306/?format=api
{ "id": 12306, "url": "https://patchwork.libcamera.org/api/patches/12306/?format=api", "web_url": "https://patchwork.libcamera.org/patch/12306/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210515183826.21003-4-laurent.pinchart@ideasonboard.com>", "date": "2021-05-15T18:38:25", "name": "[libcamera-devel,3/4] android: camera_metadata: Make internal functions private", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "5ee022d0b957093e465a91b99bcd2afc6de7bb63", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": { "id": 14, "url": "https://patchwork.libcamera.org/api/users/14/?format=api", "username": "pinchartl", "first_name": "Laurent", "last_name": "Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "mbox": "https://patchwork.libcamera.org/patch/12306/mbox/", "series": [ { "id": 2033, "url": "https://patchwork.libcamera.org/api/series/2033/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2033", "date": "2021-05-15T18:38:22", "name": "android: camera_metadata: Miscellaneous improvements", "version": 1, "mbox": "https://patchwork.libcamera.org/series/2033/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/12306/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/12306/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1B2A7C31FB\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSat, 15 May 2021 18:38:45 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CAE1A68920;\n\tSat, 15 May 2021 20:38:44 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D6DAF6891B\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 15 May 2021 20:38:40 +0200 (CEST)", "from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7D72C559;\n\tSat, 15 May 2021 20:38:40 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"kcFDpSrD\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1621103920;\n\tbh=/r7G+YIxnwm+9weY/pVPn7vH5fKtgLvNaRZYSy8WzhA=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=kcFDpSrDhA47yHivKVwfAvs8kp98H3643RAXZQ+qt4tRmqc8MyQJO8OP+NoRjJboG\n\tj7H5Kim6Ajcpj0A4sDI9Zlom9rjV8iRlOutJ601QGHuOZFO0qzEcdvWCdCZYtGMmkH\n\tqD4Hyt9KwTPCUM+8M4C08A4OQeuMOnHcgPeB3LMo=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Sat, 15 May 2021 21:38:25 +0300", "Message-Id": "<20210515183826.21003-4-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.28.1", "In-Reply-To": "<20210515183826.21003-1-laurent.pinchart@ideasonboard.com>", "References": "<20210515183826.21003-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 3/4] android: camera_metadata: Make\n\tinternal functions private", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The resize() function and the addEntry() override that takes a void\npointer are not meant to be called by the user of the CameraMetadata\nclass. Make them private.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/android/camera_metadata.h | 7 ++++---\n 1 file changed, 4 insertions(+), 3 deletions(-)", "diff": "diff --git a/src/android/camera_metadata.h b/src/android/camera_metadata.h\nindex f95c34581fe4..d7c8d9df689f 100644\n--- a/src/android/camera_metadata.h\n+++ b/src/android/camera_metadata.h\n@@ -24,7 +24,6 @@ public:\n \tCameraMetadata &operator=(const CameraMetadata &other);\n \n \tbool isValid() const { return valid_; }\n-\tbool resize(size_t count, size_t size);\n \tbool getEntry(uint32_t tag, camera_metadata_ro_entry_t *entry) const;\n \n \ttemplate<typename T,\n@@ -72,14 +71,16 @@ public:\n \t\treturn updateEntry(tag, data.data(), data.size());\n \t}\n \n-\tbool addEntry(uint32_t tag, const void *data, size_t count,\n-\t\t size_t elementSize);\n \tbool updateEntry(uint32_t tag, const void *data, size_t count);\n \n \tcamera_metadata_t *get();\n \tconst camera_metadata_t *get() const;\n \n private:\n+\tbool resize(size_t count, size_t size);\n+\tbool addEntry(uint32_t tag, const void *data, size_t count,\n+\t\t size_t elementSize);\n+\n \tcamera_metadata_t *metadata_;\n \tbool valid_;\n };\n", "prefixes": [ "libcamera-devel", "3/4" ] }