Patch Detail
Show a patch.
GET /api/patches/12304/?format=api
{ "id": 12304, "url": "https://patchwork.libcamera.org/api/patches/12304/?format=api", "web_url": "https://patchwork.libcamera.org/patch/12304/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210515183826.21003-2-laurent.pinchart@ideasonboard.com>", "date": "2021-05-15T18:38:23", "name": "[libcamera-devel,1/4] android: camera_metadata: Rename sizeofT argument to elementSize", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "30d4fc27553a6c83ade71465f7197f5a79e8ead9", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": { "id": 14, "url": "https://patchwork.libcamera.org/api/users/14/?format=api", "username": "pinchartl", "first_name": "Laurent", "last_name": "Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "mbox": "https://patchwork.libcamera.org/patch/12304/mbox/", "series": [ { "id": 2033, "url": "https://patchwork.libcamera.org/api/series/2033/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2033", "date": "2021-05-15T18:38:22", "name": "android: camera_metadata: Miscellaneous improvements", "version": 1, "mbox": "https://patchwork.libcamera.org/series/2033/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/12304/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/12304/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E8509C31FB\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSat, 15 May 2021 18:38:42 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EB6AE6891E;\n\tSat, 15 May 2021 20:38:41 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0AFE66891B\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 15 May 2021 20:38:40 +0200 (CEST)", "from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8BCBA559;\n\tSat, 15 May 2021 20:38:39 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"oK0XEIbA\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1621103919;\n\tbh=CnncbO62OunficC/7qsarbjsqDtx4b26YIPxesqOXcU=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=oK0XEIbA8p655M/X/liDJDdgCPtjTcd8hPLQXlgh3Ea3gHwPEVLAgUDwCgLuWOP4a\n\tziyvP/mwix372hZ1NuzMGND0Gb2cxdGqeQw5zVRuFvxxvg7M+ljwCkeJMlpKKU27z4\n\tMOHhal21Nih5F90krdrRVHYvDdoTDO4R9ADTWh8Y=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Sat, 15 May 2021 21:38:23 +0300", "Message-Id": "<20210515183826.21003-2-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.28.1", "In-Reply-To": "<20210515183826.21003-1-laurent.pinchart@ideasonboard.com>", "References": "<20210515183826.21003-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 1/4] android: camera_metadata: Rename\n\tsizeofT argument to elementSize", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The sizeofT argument to CameraMetadata::addEntry() stores the size of\none element. Its name is a bit cryptic as the function isn't a template\nfunction with a typename T. Rename it to elementSize.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/android/camera_metadata.cpp | 4 ++--\n src/android/camera_metadata.h | 3 ++-\n 2 files changed, 4 insertions(+), 3 deletions(-)", "diff": "diff --git a/src/android/camera_metadata.cpp b/src/android/camera_metadata.cpp\nindex bf8d2781cc21..59366c50cc16 100644\n--- a/src/android/camera_metadata.cpp\n+++ b/src/android/camera_metadata.cpp\n@@ -110,12 +110,12 @@ bool CameraMetadata::resize(size_t count, size_t size)\n }\n \n bool CameraMetadata::addEntry(uint32_t tag, const void *data, size_t count,\n-\t\t\t size_t sizeofT)\n+\t\t\t size_t elementSize)\n {\n \tif (!valid_)\n \t\treturn false;\n \n-\tif (!resize(1, count * sizeofT)) {\n+\tif (!resize(1, count * elementSize)) {\n \t\tLOG(CameraMetadata, Error) << \"Failed to resize\";\n \t\tvalid_ = false;\n \t\treturn false;\ndiff --git a/src/android/camera_metadata.h b/src/android/camera_metadata.h\nindex 07afd4b25ae7..56df6f1c9008 100644\n--- a/src/android/camera_metadata.h\n+++ b/src/android/camera_metadata.h\n@@ -72,7 +72,8 @@ public:\n \t\treturn updateEntry(tag, data.data(), data.size());\n \t}\n \n-\tbool addEntry(uint32_t tag, const void *data, size_t count, size_t sizeofT);\n+\tbool addEntry(uint32_t tag, const void *data, size_t count,\n+\t\t size_t elementSize);\n \tbool updateEntry(uint32_t tag, const void *data, size_t count);\n \n \tcamera_metadata_t *get();\n", "prefixes": [ "libcamera-devel", "1/4" ] }