Patch Detail
Show a patch.
GET /api/patches/12277/?format=api
{ "id": 12277, "url": "https://patchwork.libcamera.org/api/patches/12277/?format=api", "web_url": "https://patchwork.libcamera.org/patch/12277/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210513152116.17666-7-jacopo@jmondi.org>", "date": "2021-05-13T15:21:14", "name": "[libcamera-devel,v3,6/8] libcamera: ipu3: imgu: Fix BSD height size comparison", "commit_ref": "5be6313d325a91e47251b831ee7c33a3e58c0cfb", "pull_url": null, "state": "accepted", "archived": false, "hash": "931fde495cfb4efac1b850d57c554801313690f8", "submitter": { "id": 3, "url": "https://patchwork.libcamera.org/api/people/3/?format=api", "name": "Jacopo Mondi", "email": "jacopo@jmondi.org" }, "delegate": { "id": 15, "url": "https://patchwork.libcamera.org/api/users/15/?format=api", "username": "jmondi", "first_name": "Jacopo", "last_name": "Mondi", "email": "jacopo@jmondi.org" }, "mbox": "https://patchwork.libcamera.org/patch/12277/mbox/", "series": [ { "id": 2026, "url": "https://patchwork.libcamera.org/api/series/2026/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2026", "date": "2021-05-13T15:21:08", "name": "ipu3: imgu: Improve ImgU calculation procedure", "version": 3, "mbox": "https://patchwork.libcamera.org/series/2026/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/12277/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/12277/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 735CEC31F1\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 13 May 2021 15:20:49 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0E1CB68923;\n\tThu, 13 May 2021 17:20:49 +0200 (CEST)", "from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net\n\t[217.70.183.198])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BDD0A688E4\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 13 May 2021 17:20:45 +0200 (CEST)", "from uno.homenet.telecomitalia.it\n\t(host-79-53-131-195.retail.telecomitalia.it [79.53.131.195])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay6-d.mail.gandi.net (Postfix) with ESMTPSA id 3BB75C000C;\n\tThu, 13 May 2021 15:20:44 +0000 (UTC)" ], "X-Originating-IP": "79.53.131.195", "From": "Jacopo Mondi <jacopo@jmondi.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 13 May 2021 17:21:14 +0200", "Message-Id": "<20210513152116.17666-7-jacopo@jmondi.org>", "X-Mailer": "git-send-email 2.31.1", "In-Reply-To": "<20210513152116.17666-1-jacopo@jmondi.org>", "References": "<20210513152116.17666-1-jacopo@jmondi.org>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v3 6/8] libcamera: ipu3: imgu: Fix BSD\n\theight size comparison", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Fix a size comparison when iterating on the BDS sizes to accepts\nvalues that are equal to the minimum accepted height.\n\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\nTested-by: Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>\nReviewed-by: Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nReviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n---\n src/libcamera/pipeline/ipu3/imgu.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/pipeline/ipu3/imgu.cpp b/src/libcamera/pipeline/ipu3/imgu.cpp\nindex 5912ae4dfc87..df5a1b5b0826 100644\n--- a/src/libcamera/pipeline/ipu3/imgu.cpp\n+++ b/src/libcamera/pipeline/ipu3/imgu.cpp\n@@ -177,7 +177,7 @@ void calculateBDSHeight(ImgUDevice::Pipe *pipe, const Size &iif, const Size &gdc\n \t\t}\n \t} else {\n \t\tifHeight = utils::alignUp(iif.height, IF_ALIGN_H);\n-\t\twhile (ifHeight > minIFHeight && ifHeight / bdsSF >= minBDSHeight) {\n+\t\twhile (ifHeight >= minIFHeight && ifHeight / bdsSF >= minBDSHeight) {\n \n \t\t\tbdsHeight = ifHeight / bdsSF;\n \t\t\tif (std::fmod(ifHeight, 1.0) == 0 && std::fmod(bdsHeight, 1.0) == 0) {\n", "prefixes": [ "libcamera-devel", "v3", "6/8" ] }