Patch Detail
Show a patch.
GET /api/patches/12273/?format=api
{ "id": 12273, "url": "https://patchwork.libcamera.org/api/patches/12273/?format=api", "web_url": "https://patchwork.libcamera.org/patch/12273/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210513152116.17666-3-jacopo@jmondi.org>", "date": "2021-05-13T15:21:10", "name": "[libcamera-devel,v3,2/8] libcamera: ipu3: imgu: Filter resolutions < IF_CROP_MAX", "commit_ref": "1da35058ec65e2ec17c788fd0aad7b80a269b469", "pull_url": null, "state": "accepted", "archived": false, "hash": "fa77cf01d8810ea486fb00917af5e3cca611e193", "submitter": { "id": 3, "url": "https://patchwork.libcamera.org/api/people/3/?format=api", "name": "Jacopo Mondi", "email": "jacopo@jmondi.org" }, "delegate": { "id": 15, "url": "https://patchwork.libcamera.org/api/users/15/?format=api", "username": "jmondi", "first_name": "Jacopo", "last_name": "Mondi", "email": "jacopo@jmondi.org" }, "mbox": "https://patchwork.libcamera.org/patch/12273/mbox/", "series": [ { "id": 2026, "url": "https://patchwork.libcamera.org/api/series/2026/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2026", "date": "2021-05-13T15:21:08", "name": "ipu3: imgu: Improve ImgU calculation procedure", "version": 3, "mbox": "https://patchwork.libcamera.org/series/2026/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/12273/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/12273/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4E6F8C31F1\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 13 May 2021 15:20:41 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8557C68926;\n\tThu, 13 May 2021 17:20:40 +0200 (CEST)", "from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net\n\t[217.70.183.198])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D5243688E4\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 13 May 2021 17:20:38 +0200 (CEST)", "from uno.homenet.telecomitalia.it\n\t(host-79-53-131-195.retail.telecomitalia.it [79.53.131.195])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay6-d.mail.gandi.net (Postfix) with ESMTPSA id 41868C0006;\n\tThu, 13 May 2021 15:20:38 +0000 (UTC)" ], "X-Originating-IP": "79.53.131.195", "From": "Jacopo Mondi <jacopo@jmondi.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 13 May 2021 17:21:10 +0200", "Message-Id": "<20210513152116.17666-3-jacopo@jmondi.org>", "X-Mailer": "git-send-email 2.31.1", "In-Reply-To": "<20210513152116.17666-1-jacopo@jmondi.org>", "References": "<20210513152116.17666-1-jacopo@jmondi.org>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v3 2/8] libcamera: ipu3: imgu: Filter\n\tresolutions < IF_CROP_MAX", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "As reported in https://bugs.libcamera.org/show_bug.cgi?id=32\nallowing resolutions < IF_CROP_MAX leads to a not manageable number\nconfigurations to be tested, slowing down the ImgU pipe configuration\nto a point which is not acceptable for production devices.\n\nFilter all resolutions < IF_CROP_MAX to maintain the run-time complexity\nacceptable and remove the safety check that was meant to avoid overflows\nwhen computing the IF rectangle sizes.\n\nBug: https://bugs.libcamera.org/show_bug.cgi?id=32\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n src/libcamera/pipeline/ipu3/imgu.cpp | 21 +++++++++++++++------\n 1 file changed, 15 insertions(+), 6 deletions(-)", "diff": "diff --git a/src/libcamera/pipeline/ipu3/imgu.cpp b/src/libcamera/pipeline/ipu3/imgu.cpp\nindex acc625ab0fac..f25f14a71e9e 100644\n--- a/src/libcamera/pipeline/ipu3/imgu.cpp\n+++ b/src/libcamera/pipeline/ipu3/imgu.cpp\n@@ -392,6 +392,17 @@ ImgUDevice::PipeConfig ImgUDevice::calculatePipeConfig(Pipe *pipe)\n \tLOG(IPU3, Debug) << \"vf: \" << pipe->viewfinder.toString();\n \n \tconst Size &in = pipe->input;\n+\n+\t/*\n+\t * \\todo Filter out all resolutions < IF_CROP_MAX.\n+\t * See https://bugs.libcamera.org/show_bug.cgi?id=32\n+\t */\n+\tif (in.width < IF_CROP_MAX_W || in.height < IF_CROP_MAX_H) {\n+\t\tLOG(IPU3, Error) << \"Input resolution \" << in.toString()\n+\t\t\t\t << \" not supported\";\n+\t\treturn {};\n+\t}\n+\n \tSize gdc = calculateGDC(pipe);\n \n \tfloat bdsSF = static_cast<float>(in.width) / gdc.width;\n@@ -400,10 +411,8 @@ ImgUDevice::PipeConfig ImgUDevice::calculatePipeConfig(Pipe *pipe)\n \t/* Populate the configurations vector by scaling width and height. */\n \tunsigned int ifWidth = utils::alignUp(in.width, IF_ALIGN_W);\n \tunsigned int ifHeight = utils::alignUp(in.height, IF_ALIGN_H);\n-\tunsigned int minIfWidth = std::min(IF_ALIGN_W,\n-\t\t\t\t\t in.width - IF_CROP_MAX_W);\n-\tunsigned int minIfHeight = std::min(IF_ALIGN_H,\n-\t\t\t\t\t in.height - IF_CROP_MAX_H);\n+\tunsigned int minIfWidth = in.width - IF_CROP_MAX_W;\n+\tunsigned int minIfHeight = in.height - IF_CROP_MAX_H;\n \twhile (ifWidth >= minIfWidth) {\n \t\twhile (ifHeight >= minIfHeight) {\n \t\t\tSize iif{ ifWidth, ifHeight };\n@@ -417,8 +426,8 @@ ImgUDevice::PipeConfig ImgUDevice::calculatePipeConfig(Pipe *pipe)\n \t/* Repeat search by scaling width first. */\n \tifWidth = utils::alignUp(in.width, IF_ALIGN_W);\n \tifHeight = utils::alignUp(in.height, IF_ALIGN_H);\n-\tminIfWidth = std::min(IF_ALIGN_W, in.width - IF_CROP_MAX_W);\n-\tminIfHeight = std::min(IF_ALIGN_H, in.height - IF_CROP_MAX_H);\n+\tminIfWidth = in.width - IF_CROP_MAX_W;\n+\tminIfHeight = in.height - IF_CROP_MAX_H;\n \twhile (ifHeight >= minIfHeight) {\n \t\t/*\n \t\t * \\todo This procedure is probably broken:\n", "prefixes": [ "libcamera-devel", "v3", "2/8" ] }