Patch Detail
Show a patch.
GET /api/patches/12183/?format=api
{ "id": 12183, "url": "https://patchwork.libcamera.org/api/patches/12183/?format=api", "web_url": "https://patchwork.libcamera.org/patch/12183/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210503104152.34048-15-jacopo@jmondi.org>", "date": "2021-05-03T10:41:49", "name": "[libcamera-devel,v5,14/17] libcamera: raspberry: Report sensor timestamp", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "4997ce028cb307a1c95bd9639efc3c54f13f70e2", "submitter": { "id": 3, "url": "https://patchwork.libcamera.org/api/people/3/?format=api", "name": "Jacopo Mondi", "email": "jacopo@jmondi.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/12183/mbox/", "series": [ { "id": 1994, "url": "https://patchwork.libcamera.org/api/series/1994/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1994", "date": "2021-05-03T10:41:35", "name": "Support SensorTimestamp metadata", "version": 5, "mbox": "https://patchwork.libcamera.org/series/1994/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/12183/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/12183/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CE01ABDE79\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 3 May 2021 10:41:22 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 74BCA68940;\n\tMon, 3 May 2021 12:41:22 +0200 (CEST)", "from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net\n\t[217.70.183.199])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 001FE60511\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 3 May 2021 12:41:16 +0200 (CEST)", "from uno.lan (93-34-118-233.ip49.fastwebnet.it [93.34.118.233])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay9-d.mail.gandi.net (Postfix) with ESMTPSA id C1DD5FF802\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 3 May 2021 10:41:16 +0000 (UTC)" ], "X-Originating-IP": "93.34.118.233", "From": "Jacopo Mondi <jacopo@jmondi.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 3 May 2021 12:41:49 +0200", "Message-Id": "<20210503104152.34048-15-jacopo@jmondi.org>", "X-Mailer": "git-send-email 2.31.1", "In-Reply-To": "<20210503104152.34048-1-jacopo@jmondi.org>", "References": "<20210503104152.34048-1-jacopo@jmondi.org>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v5 14/17] libcamera: raspberry: Report\n\tsensor timestamp", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Report the sensor's timestamp in the Request metadata by using the\nUnicam::Image buffer timestamp as an initial approximation.\n\nThe buffer's timestamp is recorded at DMA-transfer time, and it does not\ntheoretically matches the 'start of exposure' definition, but when used\nto compare two consecutive frames it gives an acceptable estimation of\nthe sensor frame period duration.\n\nReviewed-by: Hirokazu Honda <hiroh@chromium.org>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nReviewed-by: Naushir Patuck <naush@raspberrypi.com>\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 12 ++++++++++++\n 1 file changed, 12 insertions(+)", "diff": "diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\nindex 91f44f6844b3..b22564938cdc 100644\n--- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n+++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n@@ -1409,6 +1409,18 @@ void RPiCameraData::unicamBufferDequeue(FrameBuffer *buffer)\n \t\t\t<< \", timestamp: \" << buffer->metadata().timestamp;\n \n \tif (stream == &unicam_[Unicam::Image]) {\n+\t\t/*\n+\t\t * Record the sensor timestamp in the Request.\n+\t\t *\n+\t\t * \\todo Do not assume the request in the front of the queue\n+\t\t * is the correct one\n+\t\t */\n+\t\tRequest *request = requestQueue_.front();\n+\t\tASSERT(request);\n+\n+\t\trequest->metadata().set(controls::SensorTimestamp,\n+\t\t\t\t\tbuffer->metadata().timestamp);\n+\n \t\t/*\n \t\t * Lookup the sensor controls used for this frame sequence from\n \t\t * DelayedControl and queue them along with the frame buffer.\n", "prefixes": [ "libcamera-devel", "v5", "14/17" ] }