Patch Detail
Show a patch.
GET /api/patches/12144/?format=api
{ "id": 12144, "url": "https://patchwork.libcamera.org/api/patches/12144/?format=api", "web_url": "https://patchwork.libcamera.org/patch/12144/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210430160026.190724-6-jacopo@jmondi.org>", "date": "2021-04-30T16:00:15", "name": "[libcamera-devel,v4,05/16] libcamera: ipu3: Report sensor timestamp", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "d49f7ac4a07e8882ea5525b7a4e036e9aec37bff", "submitter": { "id": 3, "url": "https://patchwork.libcamera.org/api/people/3/?format=api", "name": "Jacopo Mondi", "email": "jacopo@jmondi.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/12144/mbox/", "series": [ { "id": 1990, "url": "https://patchwork.libcamera.org/api/series/1990/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1990", "date": "2021-04-30T16:00:10", "name": "Support SensorTimestamp metadata", "version": 4, "mbox": "https://patchwork.libcamera.org/series/1990/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/12144/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/12144/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B3040BDE4C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 30 Apr 2021 15:59:56 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2FF5268909;\n\tFri, 30 Apr 2021 17:59:56 +0200 (CEST)", "from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net\n\t[217.70.183.199])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 57AAC68909\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 30 Apr 2021 17:59:53 +0200 (CEST)", "from uno.LocalDomain (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay9-d.mail.gandi.net (Postfix) with ESMTPSA id 3E1EAFF808;\n\tFri, 30 Apr 2021 15:59:52 +0000 (UTC)" ], "X-Originating-IP": "93.61.96.190", "From": "Jacopo Mondi <jacopo@jmondi.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 30 Apr 2021 18:00:15 +0200", "Message-Id": "<20210430160026.190724-6-jacopo@jmondi.org>", "X-Mailer": "git-send-email 2.31.1", "In-Reply-To": "<20210430160026.190724-1-jacopo@jmondi.org>", "References": "<20210430160026.190724-1-jacopo@jmondi.org>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v4 05/16] libcamera: ipu3: Report sensor\n\ttimestamp", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Report the sensor's timestamp in the Request metadata by using the\nCIO2 buffer timestamp as an initial approximation.\n\nThe buffer's timestamp is recorded at DMA-transfer time, and it does not\ntheoretically matches the 'start of exposure' definition, but when used\nto compare two consecutive frames it gives an acceptable estimation of\nthe sensor frame period duration.\n\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nReviewed-by: Hirokazu Honda <hiroh@chromium.org>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n src/libcamera/pipeline/ipu3/ipu3.cpp | 9 +++++++++\n 1 file changed, 9 insertions(+)", "diff": "diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\nindex 73306cea6b37..88b7bd1e52c3 100644\n--- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n+++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n@@ -1255,6 +1255,15 @@ void IPU3CameraData::cio2BufferReady(FrameBuffer *buffer)\n \n \tRequest *request = info->request;\n \n+\t/*\n+\t * Record the sensor's timestamp in the request metadata.\n+\t *\n+\t * \\todo The sensor timestamp should be better estimated by connecting\n+\t * to the V4L2Device::frameStart signal.\n+\t */\n+\trequest->metadata().set(controls::SensorTimestamp,\n+\t\t\t\tbuffer->metadata().timestamp);\n+\n \t/* If the buffer is cancelled force a complete of the whole request. */\n \tif (buffer->metadata().status == FrameMetadata::FrameCancelled) {\n \t\tfor (auto it : request->buffers()) {\n", "prefixes": [ "libcamera-devel", "v4", "05/16" ] }