Patch Detail
Show a patch.
GET /api/patches/12141/?format=api
{ "id": 12141, "url": "https://patchwork.libcamera.org/api/patches/12141/?format=api", "web_url": "https://patchwork.libcamera.org/patch/12141/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210430160026.190724-3-jacopo@jmondi.org>", "date": "2021-04-30T16:00:12", "name": "[libcamera-devel,v4,02/16] test: control_list: Check for Brightness presence", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "78f4c7e8056230b9ec3aee3355b00ec9746de28b", "submitter": { "id": 3, "url": "https://patchwork.libcamera.org/api/people/3/?format=api", "name": "Jacopo Mondi", "email": "jacopo@jmondi.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/12141/mbox/", "series": [ { "id": 1990, "url": "https://patchwork.libcamera.org/api/series/1990/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1990", "date": "2021-04-30T16:00:10", "name": "Support SensorTimestamp metadata", "version": 4, "mbox": "https://patchwork.libcamera.org/series/1990/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/12141/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/12141/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D53D1BDE4C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 30 Apr 2021 15:59:52 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 38D6C6891A;\n\tFri, 30 Apr 2021 17:59:52 +0200 (CEST)", "from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net\n\t[217.70.183.199])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C4546688E4\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 30 Apr 2021 17:59:49 +0200 (CEST)", "from uno.LocalDomain (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay9-d.mail.gandi.net (Postfix) with ESMTPSA id 83653FF80B;\n\tFri, 30 Apr 2021 15:59:48 +0000 (UTC)" ], "X-Originating-IP": "93.61.96.190", "From": "Jacopo Mondi <jacopo@jmondi.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 30 Apr 2021 18:00:12 +0200", "Message-Id": "<20210430160026.190724-3-jacopo@jmondi.org>", "X-Mailer": "git-send-email 2.31.1", "In-Reply-To": "<20210430160026.190724-1-jacopo@jmondi.org>", "References": "<20210430160026.190724-1-jacopo@jmondi.org>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v4 02/16] test: control_list: Check for\n\tBrightness presence", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The current test verifies that after adding a new control to a list\nalready populated with one control the new one is present.\n\nHowever the test wrongly tests for its presence twice instead of\nmaking sure the existing control is still there.\n\nFix this by checking for the presence of both controls after the\nupdate, and fix the error message accordingly.\n\nFixes: a8c40942b99e (\"libcamera: controls: Improve the API towards applications\")\nReviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\nReviewed-by: Hirokazu Honda <hiroh@chromium.org>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n test/controls/control_list.cpp | 5 +++--\n 1 file changed, 3 insertions(+), 2 deletions(-)", "diff": "diff --git a/test/controls/control_list.cpp b/test/controls/control_list.cpp\nindex b5a49dc17000..2b321ddd6fa4 100644\n--- a/test/controls/control_list.cpp\n+++ b/test/controls/control_list.cpp\n@@ -108,9 +108,10 @@ protected:\n \t\tlist.set(controls::Brightness, 0.0f);\n \t\tlist.set(controls::Contrast, 1.5f);\n \n-\t\tif (!list.contains(controls::Contrast) ||\n+\t\tif (!list.contains(controls::Brightness) ||\n \t\t !list.contains(controls::Contrast)) {\n-\t\t\tcout << \"List should contain Contrast control\" << endl;\n+\t\t\tcout << \"List should contain Brightness and Contrast controls\"\n+\t\t\t << endl;\n \t\t\treturn TestFail;\n \t\t}\n \n", "prefixes": [ "libcamera-devel", "v4", "02/16" ] }