Patch Detail
Show a patch.
GET /api/patches/12101/?format=api
{ "id": 12101, "url": "https://patchwork.libcamera.org/api/patches/12101/?format=api", "web_url": "https://patchwork.libcamera.org/patch/12101/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210423104711.401547-4-paul.elder@ideasonboard.com>", "date": "2021-04-23T10:47:11", "name": "[libcamera-devel,v3,3/3] ipa: mojom: Put core.mojom in the libcamera namespace", "commit_ref": "0f2189ba309baf4b7c26443a7e53c81e979d6f62", "pull_url": null, "state": "accepted", "archived": false, "hash": "bc577707c0cf5c6367ee5c562ec131e43b4a4c1d", "submitter": { "id": 17, "url": "https://patchwork.libcamera.org/api/people/17/?format=api", "name": "Paul Elder", "email": "paul.elder@ideasonboard.com" }, "delegate": { "id": 17, "url": "https://patchwork.libcamera.org/api/users/17/?format=api", "username": "epaul", "first_name": "Paul", "last_name": "Elder", "email": "paul.elder@ideasonboard.com" }, "mbox": "https://patchwork.libcamera.org/patch/12101/mbox/", "series": [ { "id": 1971, "url": "https://patchwork.libcamera.org/api/series/1971/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1971", "date": "2021-04-23T10:47:08", "name": "Fix support for core.mojom structs", "version": 3, "mbox": "https://patchwork.libcamera.org/series/1971/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/12101/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/12101/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 56FB5BDB15\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 23 Apr 2021 10:47:28 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BE89268883;\n\tFri, 23 Apr 2021 12:47:27 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E7D00602D1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 23 Apr 2021 12:47:26 +0200 (CEST)", "from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 87CF8B1A;\n\tFri, 23 Apr 2021 12:47:25 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"MGCK1dFu\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1619174846;\n\tbh=Y1yxJ7uN9vavLW0cwUkaBPAb3Ddc3YGdaRFDwKlOwck=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=MGCK1dFunstnju7qPS7nJcffWcOiYS+rYbMBoM6quIE02Hrzyx5Flss8WNeNP1QeH\n\tRFh64Kz3ZL2Bt3M5GNQdibUkFhhvwDXOUCmVGub2jTve62K22hv2WXvyr9muVZzIoa\n\t4hbmWcQcrJMUn9yQd1Kj2WEq1NY7CuxC+MjwV/dU=", "From": "Paul Elder <paul.elder@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 23 Apr 2021 19:47:11 +0900", "Message-Id": "<20210423104711.401547-4-paul.elder@ideasonboard.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20210423104711.401547-1-paul.elder@ideasonboard.com>", "References": "<20210423104711.401547-1-paul.elder@ideasonboard.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v3 3/3] ipa: mojom: Put core.mojom in the\n\tlibcamera namespace", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Put core.mojom in the libcamera namespace, as all structs that are\ndefined in core.mojom are meant to be in that namespace. Fix the structs\nthat are used in the other mojom files accordingly.\n\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\n\n---\nNew in v3\n---\n include/libcamera/ipa/core.mojom | 2 ++\n include/libcamera/ipa/ipu3.mojom | 11 +++++-----\n include/libcamera/ipa/raspberrypi.mojom | 29 +++++++++++++------------\n include/libcamera/ipa/rkisp1.mojom | 13 ++++++-----\n include/libcamera/ipa/vimc.mojom | 2 +-\n 5 files changed, 31 insertions(+), 26 deletions(-)", "diff": "diff --git a/include/libcamera/ipa/core.mojom b/include/libcamera/ipa/core.mojom\nindex 70de71ea..6caaa63e 100644\n--- a/include/libcamera/ipa/core.mojom\n+++ b/include/libcamera/ipa/core.mojom\n@@ -1,5 +1,7 @@\n /* SPDX-License-Identifier: LGPL-2.1-or-later */\n \n+module libcamera;\n+\n /*\n * Things that can be defined here (and in other mojom files):\n * - consts\ndiff --git a/include/libcamera/ipa/ipu3.mojom b/include/libcamera/ipa/ipu3.mojom\nindex 5d13e7ea..a717b1e6 100644\n--- a/include/libcamera/ipa/ipu3.mojom\n+++ b/include/libcamera/ipa/ipu3.mojom\n@@ -17,22 +17,23 @@ struct IPU3Event {\n \tIPU3Operations op;\n \tuint32 frame;\n \tuint32 bufferId;\n-\tControlList controls;\n+\tlibcamera.ControlList controls;\n };\n \n struct IPU3Action {\n \tIPU3Operations op;\n-\tControlList controls;\n+\tlibcamera.ControlList controls;\n };\n \n interface IPAIPU3Interface {\n-\tinit(IPASettings settings) => (int32 ret);\n+\tinit(libcamera.IPASettings settings) => (int32 ret);\n \tstart() => (int32 ret);\n \tstop();\n \n-\tconfigure(map<uint32, ControlInfoMap> entityControls, Size bdsOutputSize) => ();\n+\tconfigure(map<uint32, libcamera.ControlInfoMap> entityControls,\n+\t\t libcamera.Size bdsOutputSize) => ();\n \n-\tmapBuffers(array<IPABuffer> buffers);\n+\tmapBuffers(array<libcamera.IPABuffer> buffers);\n \tunmapBuffers(array<uint32> ids);\n \n \t[async] processEvent(IPU3Event ev);\ndiff --git a/include/libcamera/ipa/raspberrypi.mojom b/include/libcamera/ipa/raspberrypi.mojom\nindex f38c2261..42321bee 100644\n--- a/include/libcamera/ipa/raspberrypi.mojom\n+++ b/include/libcamera/ipa/raspberrypi.mojom\n@@ -26,22 +26,23 @@ struct ISPConfig {\n \tuint32 embeddedBufferId;\n \tuint32 bayerBufferId;\n \tbool embeddedBufferPresent;\n-\tControlList controls;\n+\tlibcamera.ControlList controls;\n };\n \n struct IPAConfig {\n \tuint32 transform;\n-\tFileDescriptor lsTableHandle;\n+\tlibcamera.FileDescriptor lsTableHandle;\n };\n \n struct StartConfig {\n-\tControlList controls;\n+\tlibcamera.ControlList controls;\n \tint32 dropFrameCount;\n };\n \n interface IPARPiInterface {\n-\tinit(IPASettings settings) => (int32 ret, SensorConfig sensorConfig);\n-\tstart(ControlList controls) => (StartConfig startConfig);\n+\tinit(libcamera.IPASettings settings)\n+\t\t=> (int32 ret, SensorConfig sensorConfig);\n+\tstart(libcamera.ControlList controls) => (StartConfig startConfig);\n \tstop();\n \n \t/**\n@@ -62,11 +63,11 @@ interface IPARPiInterface {\n \t * The \\a ipaConfig and \\a controls parameters carry data passed by the\n \t * pipeline handler to the IPA and back.\n \t */\n-\tconfigure(CameraSensorInfo sensorInfo,\n-\t\t map<uint32, IPAStream> streamConfig,\n-\t\t map<uint32, ControlInfoMap> entityControls,\n+\tconfigure(libcamera.CameraSensorInfo sensorInfo,\n+\t\t map<uint32, libcamera.IPAStream> streamConfig,\n+\t\t map<uint32, libcamera.ControlInfoMap> entityControls,\n \t\t IPAConfig ipaConfig)\n-\t\t=> (int32 ret, ControlList controls);\n+\t\t=> (int32 ret, libcamera.ControlList controls);\n \n \t/**\n \t * \\fn mapBuffers()\n@@ -94,7 +95,7 @@ interface IPARPiInterface {\n \t *\n \t * \\sa unmapBuffers()\n \t */\n-\tmapBuffers(array<IPABuffer> buffers);\n+\tmapBuffers(array<libcamera.IPABuffer> buffers);\n \n \t/**\n \t * \\fn unmapBuffers()\n@@ -109,14 +110,14 @@ interface IPARPiInterface {\n \tunmapBuffers(array<uint32> ids);\n \n \t[async] signalStatReady(uint32 bufferId);\n-\t[async] signalQueueRequest(ControlList controls);\n+\t[async] signalQueueRequest(libcamera.ControlList controls);\n \t[async] signalIspPrepare(ISPConfig data);\n };\n \n interface IPARPiEventInterface {\n-\tstatsMetadataComplete(uint32 bufferId, ControlList controls);\n+\tstatsMetadataComplete(uint32 bufferId, libcamera.ControlList controls);\n \trunIsp(uint32 bufferId);\n \tembeddedComplete(uint32 bufferId);\n-\tsetIspControls(ControlList controls);\n-\tsetDelayedControls(ControlList controls);\n+\tsetIspControls(libcamera.ControlList controls);\n+\tsetDelayedControls(libcamera.ControlList controls);\n };\ndiff --git a/include/libcamera/ipa/rkisp1.mojom b/include/libcamera/ipa/rkisp1.mojom\nindex 29f726e1..cca871a0 100644\n--- a/include/libcamera/ipa/rkisp1.mojom\n+++ b/include/libcamera/ipa/rkisp1.mojom\n@@ -16,12 +16,12 @@ struct RkISP1Event {\n \tRkISP1Operations op;\n \tuint32 frame;\n \tuint32 bufferId;\n-\tControlList controls;\n+\tlibcamera.ControlList controls;\n };\n \n struct RkISP1Action {\n \tRkISP1Operations op;\n-\tControlList controls;\n+\tlibcamera.ControlList controls;\n };\n \n interface IPARkISP1Interface {\n@@ -29,11 +29,12 @@ interface IPARkISP1Interface {\n \tstart() => (int32 ret);\n \tstop();\n \n-\tconfigure(CameraSensorInfo sensorInfo,\n-\t\t map<uint32, IPAStream> streamConfig,\n-\t\t map<uint32, ControlInfoMap> entityControls) => (int32 ret);\n+\tconfigure(libcamera.CameraSensorInfo sensorInfo,\n+\t\t map<uint32, libcamera.IPAStream> streamConfig,\n+\t\t map<uint32, libcamera.ControlInfoMap> entityControls)\n+\t\t=> (int32 ret);\n \n-\tmapBuffers(array<IPABuffer> buffers);\n+\tmapBuffers(array<libcamera.IPABuffer> buffers);\n \tunmapBuffers(array<uint32> ids);\n \n \t[async] processEvent(RkISP1Event ev);\ndiff --git a/include/libcamera/ipa/vimc.mojom b/include/libcamera/ipa/vimc.mojom\nindex 165d9401..be4b85b8 100644\n--- a/include/libcamera/ipa/vimc.mojom\n+++ b/include/libcamera/ipa/vimc.mojom\n@@ -14,7 +14,7 @@ enum IPAOperationCode {\n };\n \n interface IPAVimcInterface {\n-\tinit(IPASettings settings) => (int32 ret);\n+\tinit(libcamera.IPASettings settings) => (int32 ret);\n \tstart() => (int32 ret);\n \tstop();\n };\n", "prefixes": [ "libcamera-devel", "v3", "3/3" ] }