Patch Detail
Show a patch.
GET /api/patches/12066/?format=api
{ "id": 12066, "url": "https://patchwork.libcamera.org/api/patches/12066/?format=api", "web_url": "https://patchwork.libcamera.org/patch/12066/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210422080816.364948-3-paul.elder@ideasonboard.com>", "date": "2021-04-22T08:08:16", "name": "[libcamera-devel,v2,2/2] utils: ipc: Include instead of forward-declare CameraSensorInfo", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "83aeeab2c6c5e200b038a98dd4865a7c6cfa4e31", "submitter": { "id": 17, "url": "https://patchwork.libcamera.org/api/people/17/?format=api", "name": "Paul Elder", "email": "paul.elder@ideasonboard.com" }, "delegate": { "id": 17, "url": "https://patchwork.libcamera.org/api/users/17/?format=api", "username": "epaul", "first_name": "Paul", "last_name": "Elder", "email": "paul.elder@ideasonboard.com" }, "mbox": "https://patchwork.libcamera.org/patch/12066/mbox/", "series": [ { "id": 1961, "url": "https://patchwork.libcamera.org/api/series/1961/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1961", "date": "2021-04-22T08:08:14", "name": "Fix support for core.mojom structs", "version": 2, "mbox": "https://patchwork.libcamera.org/series/1961/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/12066/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/12066/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 83139BDB17\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 22 Apr 2021 08:08:41 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3E4336885B;\n\tThu, 22 Apr 2021 10:08:41 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C2A886885F\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 22 Apr 2021 10:08:39 +0200 (CEST)", "from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1E83B3EE;\n\tThu, 22 Apr 2021 10:08:37 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"NC4ywZ9W\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1619078919;\n\tbh=SOzuJjUTvZpXQuuKs08dmNZm2d6VLGX2/il63teBihs=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=NC4ywZ9WbiKEZtE0f89yc6KPy0xunV6xvDbn1aHsQxfXVZwPYA1j1MbawwIaBIdba\n\twhgKZtee1tU94+sv6IRZXxGeMqxLZcU9uxwgDLiO1UJy7OTwXJRNy2gsMFHFTpBqfV\n\tCLBZtC5kP6XPV4EO+zvDhhVF2eJJ0U0uVERmSpe4=", "From": "Paul Elder <paul.elder@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 22 Apr 2021 17:08:16 +0900", "Message-Id": "<20210422080816.364948-3-paul.elder@ideasonboard.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20210422080816.364948-1-paul.elder@ideasonboard.com>", "References": "<20210422080816.364948-1-paul.elder@ideasonboard.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v2 2/2] utils: ipc: Include instead of\n\tforward-declare CameraSensorInfo", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "For structs defined in core.mojom that have the skipHeader tag, if\nthey're only used in function parameters (in a mojom file) then a\nforward-declaration is sufficient. However, if the struct is used in\nanother struct in a mojom file, then the forward-declaration is\ninsufficient, and the definition needs to be included. Do so for\nCameraSensorInfo, which is the only forward-declared struct in\nipa_interface.h, and update the documentation comment.\n\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\n---\nNew in v2\n\n include/libcamera/ipa/ipa_interface.h | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)", "diff": "diff --git a/include/libcamera/ipa/ipa_interface.h b/include/libcamera/ipa/ipa_interface.h\nindex 5d99e2cf..dfe1b40a 100644\n--- a/include/libcamera/ipa/ipa_interface.h\n+++ b/include/libcamera/ipa/ipa_interface.h\n@@ -18,15 +18,15 @@\n #include <libcamera/geometry.h>\n #include <libcamera/signal.h>\n \n+#include \"libcamera/internal/camera_sensor.h\"\n+\n namespace libcamera {\n \n /*\n * Structs that are defined in core.mojom and have the skipHeader tag must be\n- * forward-declared or #included here.\n+ * #included here.\n */\n \n-struct CameraSensorInfo;\n-\n class IPAInterface\n {\n public:\n", "prefixes": [ "libcamera-devel", "v2", "2/2" ] }