Patch Detail
Show a patch.
GET /api/patches/12035/?format=api
{ "id": 12035, "url": "https://patchwork.libcamera.org/api/patches/12035/?format=api", "web_url": "https://patchwork.libcamera.org/patch/12035/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210421160319.42251-4-jacopo@jmondi.org>", "date": "2021-04-21T16:03:06", "name": "[libcamera-devel,v3,03/16] test: control_list: Test ControlList::merge()", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "e9ffff2322a8ce0a5fb7c66888a7fa8d8a0a0a77", "submitter": { "id": 3, "url": "https://patchwork.libcamera.org/api/people/3/?format=api", "name": "Jacopo Mondi", "email": "jacopo@jmondi.org" }, "delegate": { "id": 15, "url": "https://patchwork.libcamera.org/api/users/15/?format=api", "username": "jmondi", "first_name": "Jacopo", "last_name": "Mondi", "email": "jacopo@jmondi.org" }, "mbox": "https://patchwork.libcamera.org/patch/12035/mbox/", "series": [ { "id": 1957, "url": "https://patchwork.libcamera.org/api/series/1957/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1957", "date": "2021-04-21T16:03:03", "name": "Support SensorTimestamp metadata", "version": 3, "mbox": "https://patchwork.libcamera.org/series/1957/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/12035/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/12035/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 77564BDB17\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 21 Apr 2021 16:02:49 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EFF2068860;\n\tWed, 21 Apr 2021 18:02:48 +0200 (CEST)", "from relay10.mail.gandi.net (relay10.mail.gandi.net\n\t[217.70.178.230])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5550A68846\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 21 Apr 2021 18:02:44 +0200 (CEST)", "from uno.lan (93-34-118-233.ip49.fastwebnet.it [93.34.118.233])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay10.mail.gandi.net (Postfix) with ESMTPSA id E1FE924000D;\n\tWed, 21 Apr 2021 16:02:43 +0000 (UTC)" ], "From": "Jacopo Mondi <jacopo@jmondi.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 21 Apr 2021 18:03:06 +0200", "Message-Id": "<20210421160319.42251-4-jacopo@jmondi.org>", "X-Mailer": "git-send-email 2.31.1", "In-Reply-To": "<20210421160319.42251-1-jacopo@jmondi.org>", "References": "<20210421160319.42251-1-jacopo@jmondi.org>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v3 03/16] test: control_list: Test\n\tControlList::merge()", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Test the newly introduce ControlList::merge() method by creating\na new list with a single control and merging it with the existing one.\n\nTest that the merged list contains all the controls and their values\nare not changed.\n\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n test/controls/control_list.cpp | 40 ++++++++++++++++++++++++++++++++++\n 1 file changed, 40 insertions(+)", "diff": "diff --git a/test/controls/control_list.cpp b/test/controls/control_list.cpp\nindex 2b321ddd6fa4..91b38993abf9 100644\n--- a/test/controls/control_list.cpp\n+++ b/test/controls/control_list.cpp\n@@ -150,6 +150,46 @@ protected:\n \t\t\treturn TestFail;\n \t\t}\n \n+\t\t/*\n+\t\t * Create a new list with a new control and merge it with the\n+\t\t * existing one, verifying that the existing controls\n+\t\t * values does not get changed.\n+\t\t */\n+\t\tControlList mergeList(controls::controls, &validator);\n+\t\tmergeList.set(controls::Saturation, 0.4f);\n+\n+\t\tmergeList.merge(list);\n+\t\tif (mergeList.size() != 3) {\n+\t\t\tcout << \"Merged list should contain three elements\" << endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\tif (!mergeList.contains(controls::Brightness) ||\n+\t\t !mergeList.contains(controls::Contrast) ||\n+\t\t !mergeList.contains(controls::Saturation)) {\n+\t\t\tcout << \"Merged list does not contain all controls it should\"\n+\t\t\t << endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\tif (mergeList.get(controls::Brightness) != 0.5f) {\n+\t\t\tcout << \"Brightness control value changed after merging lists\"\n+\t\t\t << endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\tif (mergeList.get(controls::Contrast) != 1.1f) {\n+\t\t\tcout << \"Contrast control value changed after merging lists\"\n+\t\t\t << endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\tif (mergeList.get(controls::Saturation) != 0.4f) {\n+\t\t\tcout << \"Saturation control value changed after merging lists\"\n+\t\t\t << endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n \t\treturn TestPass;\n \t}\n };\n", "prefixes": [ "libcamera-devel", "v3", "03/16" ] }