Patch Detail
Show a patch.
GET /api/patches/11981/?format=api
{ "id": 11981, "url": "https://patchwork.libcamera.org/api/patches/11981/?format=api", "web_url": "https://patchwork.libcamera.org/patch/11981/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210418172712.61536-3-sebastian.fricke@posteo.net>", "date": "2021-04-18T17:27:12", "name": "[libcamera-devel,v2] ipa: cam_helper.hpp: Correct a wrong choice of term", "commit_ref": "446cb01d14470298f881c7bed4100c073f3ef835", "pull_url": null, "state": "accepted", "archived": false, "hash": "d952e47e625d530b4aa414e8a8cfb5210f205a2f", "submitter": { "id": 78, "url": "https://patchwork.libcamera.org/api/people/78/?format=api", "name": "Sebastian Fricke", "email": "sebastian.fricke@posteo.net" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/11981/mbox/", "series": [ { "id": 1947, "url": "https://patchwork.libcamera.org/api/series/1947/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1947", "date": "2021-04-18T17:27:12", "name": "[libcamera-devel,v2] ipa: cam_helper.hpp: Correct a wrong choice of term", "version": 2, "mbox": "https://patchwork.libcamera.org/series/1947/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/11981/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/11981/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 29F36BD812\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSun, 18 Apr 2021 17:27:43 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DCF5A6880B;\n\tSun, 18 Apr 2021 19:27:42 +0200 (CEST)", "from mout02.posteo.de (mout02.posteo.de [185.67.36.66])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B39DD602CA\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 18 Apr 2021 19:27:41 +0200 (CEST)", "from submission (posteo.de [89.146.220.130]) \n\tby mout02.posteo.de (Postfix) with ESMTPS id 48E9B2400FC\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 18 Apr 2021 19:27:41 +0200 (CEST)", "from customer (localhost [127.0.0.1])\n\tby submission (posteo.de) with ESMTPSA id 4FNcMw6QQHz9rxD;\n\tSun, 18 Apr 2021 19:27:40 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=posteo.net header.i=@posteo.net\n\theader.b=\"ZoCuRURy\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017;\n\tt=1618766861; bh=LOboeNbyDE+Iw6WLkNVKOnJElmmDna+dPcosSZV7fIE=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=ZoCuRURy/oWb49mWz2vx4GuEV1+t1GwkFchUb69g5IM3JBRUhPAb9lo9gqeyc3rJ3\n\tLhBeZbDS4JIHY3xl8+tMLlW/+yyZ4AI4fB2lRvaiT1UPhZQRd9rR5dup67zRlwS+hn\n\tBbNa48hcWHl1Z5CpNW+p/yFG5pe1ZrbMTkeg5OtebdRaJjv1lxmsBIKZM1UbqHnS0c\n\t4IpGoy3mQpvPSotb3kTwJVkenTvA5d9x/2jgQeK/+q7u95AsLN0gW9OtEscNmHFCTq\n\tCLBEhpzK5MFoARLxTS90Ri4/eYRxStKCXLTSZrEeh38S0NG+LTdCUve7efNd4r/gBb\n\tNxkitq+yhk0MQ==", "From": "Sebastian Fricke <sebastian.fricke@posteo.net>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Sun, 18 Apr 2021 17:27:12 +0000", "Message-Id": "<20210418172712.61536-3-sebastian.fricke@posteo.net>", "In-Reply-To": "<20210418172712.61536-1-sebastian.fricke@posteo.net>", "References": "<20210418172712.61536-1-sebastian.fricke@posteo.net>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v2] ipa: cam_helper.hpp: Correct a wrong\n\tchoice of term", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Sensors provide embedded data buffers and not metadata buffers,\nreplace the incorrect term with the correct one.\n\nSigned-off-by: Sebastian Fricke <sebastian.fricke@posteo.net>\nReviewed-by: David Plowman <david.plowman@raspberrypi.com>\n---\n src/ipa/raspberrypi/cam_helper.hpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/ipa/raspberrypi/cam_helper.hpp b/src/ipa/raspberrypi/cam_helper.hpp\nindex eaf73019..c3ed5362 100644\n--- a/src/ipa/raspberrypi/cam_helper.hpp\n+++ b/src/ipa/raspberrypi/cam_helper.hpp\n@@ -35,7 +35,7 @@ namespace RPiController {\n //\n // A method to query if the sensor outputs embedded data that can be parsed.\n //\n-// A parser to parse the metadata buffers provided by some sensors (for\n+// A parser to parse the embedded data buffers provided by some sensors (for\n // example, the imx219 does; the ov5647 doesn't). This allows us to know for\n // sure the exposure and gain of the frame we're looking at. CamHelper\n // provides methods for converting analogue gains to and from the sensor's\n", "prefixes": [ "libcamera-devel", "v2" ] }