Patch Detail
Show a patch.
GET /api/patches/11976/?format=api
{ "id": 11976, "url": "https://patchwork.libcamera.org/api/patches/11976/?format=api", "web_url": "https://patchwork.libcamera.org/patch/11976/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210418090459.38506-4-naush@raspberrypi.com>", "date": "2021-04-18T09:04:58", "name": "[libcamera-devel,v3,3/4] ipa: raspberrypi: Add move/copy ctors and operators to Metadata class", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "a809860e1cca3a702145f281e8db1271eede49a5", "submitter": { "id": 34, "url": "https://patchwork.libcamera.org/api/people/34/?format=api", "name": "Naushir Patuck", "email": "naush@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/11976/mbox/", "series": [ { "id": 1944, "url": "https://patchwork.libcamera.org/api/series/1944/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1944", "date": "2021-04-18T09:04:55", "name": "ipa: raspberrypi: Rate-limit the controller algorithms", "version": 3, "mbox": "https://patchwork.libcamera.org/series/1944/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/11976/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/11976/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 84860BD812\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSun, 18 Apr 2021 09:05:10 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 99B8068816;\n\tSun, 18 Apr 2021 11:05:09 +0200 (CEST)", "from mail-ed1-x52d.google.com (mail-ed1-x52d.google.com\n\t[IPv6:2a00:1450:4864:20::52d])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DEB0068803\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 18 Apr 2021 11:05:06 +0200 (CEST)", "by mail-ed1-x52d.google.com with SMTP id g17so36431839edm.6\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 18 Apr 2021 02:05:06 -0700 (PDT)", "from naush-laptop.patuck.local ([88.97.76.4])\n\tby smtp.gmail.com with ESMTPSA id\n\tz4sm9080679edb.97.2021.04.18.02.05.05\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tSun, 18 Apr 2021 02:05:06 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"fMsGmWtI\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=uule6aP/GbUVKt6rRXc2oaEhZT9hc7570Iq0GDDxCU0=;\n\tb=fMsGmWtIYkreFvpGOwnQsQaU5u+qXC7mqSrY6XSMTX/9lqc7anbItR10Ed7ao9vYyK\n\tiX+QoNDaXQAlZB2uOg/R7gO7cKRmHBcwPkUphrrH9LAnKUEflV1L7P3B9KvTbk97A6ht\n\tF4Jzg8cidHeI4TWgym0SJSzwi2yqM+GsSPXIyKc21QzeXvAR9ydA+WxjHDRab2AmYhN+\n\tN7JxrWmSJRykk/8NWqzPEpoJCgA29WPmTBWNZw3TU1GM0wtiIl/8maotwglEQ9wcAaDM\n\tYgJddHkWkTRfhzIGzO7rOrnqR6mbdrZL3Vnz8Z6Z9Z6z5LXobQdchXs7wlX2r8FlWpXR\n\tAZGQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=uule6aP/GbUVKt6rRXc2oaEhZT9hc7570Iq0GDDxCU0=;\n\tb=HLTMUlsUBQJVqqJqvZ2NyXGE6VaVBFtOx0d3BlqTa+oepn87u50Y3n/8/XzyfuPQgH\n\tTUBC5F96BOmpQAR+Zw0y3cOv+thIpMMQtUkfpmBrRzSYSmyw22vhXDsBRLyz2P62ZgKB\n\tWqPplmknJjzYlxXFacjzh0sSg81XzHfaf8iEbxfQRCZTAK6Flkbb7lUAbxTmjTnYPlk+\n\th23/GtdEqBJe2qLf0a+cK1H/LNdDETaebyZcr2JSGNl7h8N3jplYkEuhyU4KbY99Yf33\n\thgLR7+jhiqfxQPnr8aQQJEJYYkWYpzujVF+xGkKwp9uKhnLeUX6qaYKOPP2nARJ+LS/P\n\t3eHw==", "X-Gm-Message-State": "AOAM533OddoLX+WHa1/qhj1GyjJJ7pXPXMgMX0fYuhV0RlCM7ztWMGHP\n\tpE4iFRkRmTQ5FEsOJougHnVfumL2i97S4A==", "X-Google-Smtp-Source": "ABdhPJz7bIrSlqvxl1DSz4K0AoH4bjS2PtC9oEDz9udF4D/B7DgAMRKZ9WkJnKCW73ZWa8L4nKpG2g==", "X-Received": "by 2002:aa7:c7cc:: with SMTP id\n\to12mr19683388eds.291.1618736706365; \n\tSun, 18 Apr 2021 02:05:06 -0700 (PDT)", "From": "Naushir Patuck <naush@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Sun, 18 Apr 2021 10:04:58 +0100", "Message-Id": "<20210418090459.38506-4-naush@raspberrypi.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20210418090459.38506-1-naush@raspberrypi.com>", "References": "<20210418090459.38506-1-naush@raspberrypi.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v3 3/4] ipa: raspberrypi: Add move/copy\n\tctors and operators to Metadata class", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add a default, move and copy constructor as well as a move operator\nimplementation RPiController::Metadata class.\n\nSigned-off-by: Naushir Patuck <naush@raspberrypi.com>\nReviewed-by: David Plowman <david.plowman@raspberrypi.com>\n---\n src/ipa/raspberrypi/controller/metadata.hpp | 24 +++++++++++++++++++++\n 1 file changed, 24 insertions(+)", "diff": "diff --git a/src/ipa/raspberrypi/controller/metadata.hpp b/src/ipa/raspberrypi/controller/metadata.hpp\nindex 07dd28ed9e0a..319f2320fc70 100644\n--- a/src/ipa/raspberrypi/controller/metadata.hpp\n+++ b/src/ipa/raspberrypi/controller/metadata.hpp\n@@ -19,6 +19,21 @@ namespace RPiController {\n class Metadata\n {\n public:\n+\tMetadata() = default;\n+\n+\tMetadata(Metadata const &other)\n+\t{\n+\t\tstd::lock_guard<std::mutex> other_lock(other.mutex_);\n+\t\tdata_ = other.data_;\n+\t}\n+\n+\tMetadata(Metadata &&other)\n+\t{\n+\t\tstd::lock_guard<std::mutex> other_lock(other.mutex_);\n+\t\tdata_ = std::move(other.data_);\n+\t\tother.data_.clear();\n+\t}\n+\n \ttemplate<typename T>\n \tvoid Set(std::string const &tag, T const &value)\n \t{\n@@ -51,6 +66,15 @@ public:\n \t\treturn *this;\n \t}\n \n+\tMetadata &operator=(Metadata &&other)\n+\t{\n+\t\tstd::lock_guard<std::mutex> lock(mutex_);\n+\t\tstd::lock_guard<std::mutex> other_lock(other.mutex_);\n+\t\tdata_ = std::move(other.data_);\n+\t\tother.data_.clear();\n+\t\treturn *this;\n+\t}\n+\n \ttemplate<typename T>\n \tT *GetLocked(std::string const &tag)\n \t{\n", "prefixes": [ "libcamera-devel", "v3", "3/4" ] }