Patch Detail
Show a patch.
GET /api/patches/11974/?format=api
{ "id": 11974, "url": "https://patchwork.libcamera.org/api/patches/11974/?format=api", "web_url": "https://patchwork.libcamera.org/patch/11974/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210418090459.38506-2-naush@raspberrypi.com>", "date": "2021-04-18T09:04:56", "name": "[libcamera-devel,v3,1/4] ipa: raspberrypi: Store dropped frame count in a member variable", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "99b0cf3fca595fc87c0da11ee01a39e1f067c84f", "submitter": { "id": 34, "url": "https://patchwork.libcamera.org/api/people/34/?format=api", "name": "Naushir Patuck", "email": "naush@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/11974/mbox/", "series": [ { "id": 1944, "url": "https://patchwork.libcamera.org/api/series/1944/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1944", "date": "2021-04-18T09:04:55", "name": "ipa: raspberrypi: Rate-limit the controller algorithms", "version": 3, "mbox": "https://patchwork.libcamera.org/series/1944/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/11974/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/11974/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 207DCBD812\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSun, 18 Apr 2021 09:05:08 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D3C8A68818;\n\tSun, 18 Apr 2021 11:05:07 +0200 (CEST)", "from mail-ed1-x529.google.com (mail-ed1-x529.google.com\n\t[IPv6:2a00:1450:4864:20::529])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 86E46687F3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 18 Apr 2021 11:05:05 +0200 (CEST)", "by mail-ed1-x529.google.com with SMTP id w18so37209552edc.0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 18 Apr 2021 02:05:05 -0700 (PDT)", "from naush-laptop.patuck.local ([88.97.76.4])\n\tby smtp.gmail.com with ESMTPSA id\n\tz4sm9080679edb.97.2021.04.18.02.05.03\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tSun, 18 Apr 2021 02:05:04 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"TgitGanK\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=Jo8WkXMl8c5cRR6Ta7ynE+2nvwPxIi03CyEKeDa4jWM=;\n\tb=TgitGanKKA/DKYLvYo1DhDfma713OjA1IrGJx23PZAZc4aKlUDpAg8vW71im0err/b\n\tMCPhGvZieYw3Hq/WdUFVwhKRD2ReszHqVz5lly+Vi3b5Ir+/NGFfcjE0/S50eCbja5LF\n\t8crTKJ6imC6bBcn7X5sREDqlUAq86nQcXXPUZDql0fEKiLh+1+1FKGox+6K2N7jSUZP8\n\tgPS/c1F7niK/7zLP0I9552NqnFJnhFjMDxS3nIQktxRRJg+Er8Zj2fb2hlcSQyOlOZUG\n\tIpBBd+0h+r0Q6QNgxEHlZLrFgiecP+GQ1nkRh1rBNXvrf4faq5zyB+2GGcJwgLGg+CDn\n\tRGxQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=Jo8WkXMl8c5cRR6Ta7ynE+2nvwPxIi03CyEKeDa4jWM=;\n\tb=moHOv5ulZoRR9CTZAiOqPZMvxaMukfDLTX3+abM+MWfUR/llx6ekrcImQTqa88MikB\n\tvWqxOHV2x+/2Dq3pjVdLmj0Ks1qCHs3uFc5qsDS4GOtW4+CBjhz9QlSZeKkIlbtzlV/n\n\t5ARbuoT/uInnR+wcVV/i0MEtfJcVgj5y/yMOf19g6j8TLSiox5arjsPYLQ5SpHBXK3uq\n\tBFLg2lhyyQ0T1mFhqm7iJ1oCn8UujPmFQGbyrmrLt47hMtGX5T+itrTZzH0d4mAcV29J\n\tC429UiE3Uqn/5XRFuenBI4sExBNQ9aY9MPYtSyyJUuJ73F+36Corc68L1Yml+mEHAqpu\n\tw+qQ==", "X-Gm-Message-State": "AOAM532LJhtXvMUwRBX6reJJ/6BKo34MY2Yf4iyQbqHrXCLxk6CiRWr5\n\tC5vHThh8aOQY5j/qyvBbgz6cvyJx8uhrVQ==", "X-Google-Smtp-Source": "ABdhPJwbc8Qfe7fr6Q+cV41dVmTuTvBeWAJYPfVp1+dOC8KaltGAWWY3TGL1aPMAafOFK9pQRvKEcw==", "X-Received": "by 2002:a05:6402:26ca:: with SMTP id\n\tx10mr4833468edd.386.1618736704714; \n\tSun, 18 Apr 2021 02:05:04 -0700 (PDT)", "From": "Naushir Patuck <naush@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Sun, 18 Apr 2021 10:04:56 +0100", "Message-Id": "<20210418090459.38506-2-naush@raspberrypi.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20210418090459.38506-1-naush@raspberrypi.com>", "References": "<20210418090459.38506-1-naush@raspberrypi.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v3 1/4] ipa: raspberrypi: Store dropped\n\tframe count in a member variable", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Store the number of dropped frames on startup in a member variable. This\nwill be used in a subsequent change for rate limiting the controller\nalgorithms.\n\nSigned-off-by: Naushir Patuck <naush@raspberrypi.com>\nReviewed-by: David Plowman <david.plowman@raspberrypi.com>\n---\n src/ipa/raspberrypi/raspberrypi.cpp | 14 ++++++++------\n 1 file changed, 8 insertions(+), 6 deletions(-)", "diff": "diff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp\nindex b0f61d351e3a..f6d1ab16a290 100644\n--- a/src/ipa/raspberrypi/raspberrypi.cpp\n+++ b/src/ipa/raspberrypi/raspberrypi.cpp\n@@ -143,6 +143,9 @@ private:\n \t/* How many frames we should avoid running control algos on. */\n \tunsigned int mistrustCount_;\n \n+\t/* Number of frames that need to be dropped on startup. */\n+\tunsigned int dropFrameCount_;\n+\n \t/* LS table allocation passed in from the pipeline handler. */\n \tFileDescriptor lsTableHandle_;\n \tvoid *lsTable_;\n@@ -220,9 +223,8 @@ void IPARPi::start(const ControlList &controls, ipa::RPi::StartConfig *startConf\n \t */\n \tframeCount_ = 0;\n \tcheckCount_ = 0;\n-\tunsigned int dropFrame = 0;\n \tif (firstStart_) {\n-\t\tdropFrame = helper_->HideFramesStartup();\n+\t\tdropFrameCount_ = helper_->HideFramesStartup();\n \t\tmistrustCount_ = helper_->MistrustFramesStartup();\n \n \t\t/*\n@@ -250,14 +252,14 @@ void IPARPi::start(const ControlList &controls, ipa::RPi::StartConfig *startConf\n \t\t\t\tawbConvergenceFrames += mistrustCount_;\n \t\t}\n \n-\t\tdropFrame = std::max({ dropFrame, agcConvergenceFrames, awbConvergenceFrames });\n-\t\tLOG(IPARPI, Debug) << \"Drop \" << dropFrame << \" frames on startup\";\n+\t\tdropFrameCount_ = std::max({ dropFrameCount_, agcConvergenceFrames, awbConvergenceFrames });\n+\t\tLOG(IPARPI, Debug) << \"Drop \" << dropFrameCount_ << \" frames on startup\";\n \t} else {\n-\t\tdropFrame = helper_->HideFramesModeSwitch();\n+\t\tdropFrameCount_ = helper_->HideFramesModeSwitch();\n \t\tmistrustCount_ = helper_->MistrustFramesModeSwitch();\n \t}\n \n-\tstartConfig->dropFrameCount = dropFrame;\n+\tstartConfig->dropFrameCount = dropFrameCount_;\n \n \tfirstStart_ = false;\n }\n", "prefixes": [ "libcamera-devel", "v3", "1/4" ] }