Patch Detail
Show a patch.
GET /api/patches/11968/?format=api
{ "id": 11968, "url": "https://patchwork.libcamera.org/api/patches/11968/?format=api", "web_url": "https://patchwork.libcamera.org/patch/11968/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210416160320.68125-1-kieran.bingham@ideasonboard.com>", "date": "2021-04-16T16:03:20", "name": "[libcamera-devel] libcamera: pipeline: ipu3: Check for failures when loading IPA", "commit_ref": "9b5478e7259a403f847083ec4af239fa70428768", "pull_url": null, "state": "accepted", "archived": false, "hash": "abb0b778b385679ee1cd0073d07d4c94286c1c08", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/11968/mbox/", "series": [ { "id": 1941, "url": "https://patchwork.libcamera.org/api/series/1941/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1941", "date": "2021-04-16T16:03:20", "name": "[libcamera-devel] libcamera: pipeline: ipu3: Check for failures when loading IPA", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1941/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/11968/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/11968/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CA67ABD235\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 16 Apr 2021 16:03:30 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4E9526880A;\n\tFri, 16 Apr 2021 18:03:30 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BFC8568806\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 16 Apr 2021 18:03:28 +0200 (CEST)", "from Q.local (cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net\n\t[86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4931F5A5;\n\tFri, 16 Apr 2021 18:03:28 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"gVndJcQg\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1618589008;\n\tbh=61Ss0ftl3CmD40PQomIOF9Y4/JUDpVrWK7m8N3bRE3s=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=gVndJcQgMGDwtN6c8CoRxIkW5VRzzc4UqBNvwjOOw8A/I1V5AaAdFk+ZIBP/sQxdb\n\tN1NuyFYhZPR5F12WdyH3kgbGI9+zCQdaAK7jLkh31UBRThkJ1yvvrCBQyaUHTZBIrB\n\tXBaWNaCwPdoXkAKk0ovCfEgstf3ex+VJ4RoQnbxw=", "From": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "To": "libcamera devel <libcamera-devel@lists.libcamera.org>", "Date": "Fri, 16 Apr 2021 17:03:20 +0100", "Message-Id": "<20210416160320.68125-1-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.25.1", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH] libcamera: pipeline: ipu3: Check for\n\tfailures when loading IPA", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The ipa_->init() method can fail if the IPA can't load correctly.\nThis should be caught by the pipeline handler to prevent continuing\nwith an invalid IPA.\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/libcamera/pipeline/ipu3/ipu3.cpp | 6 +++++-\n 1 file changed, 5 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\nindex 519cad4f8148..51446fcf5bc1 100644\n--- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n+++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n@@ -1145,7 +1145,11 @@ int IPU3CameraData::loadIPA()\n \tipa_->queueFrameAction.connect(this, &IPU3CameraData::queueFrameAction);\n \n \tCameraSensor *sensor = cio2_.sensor();\n-\tipa_->init(IPASettings{ \"\", sensor->model() });\n+\tint ret = ipa_->init(IPASettings{ \"\", sensor->model() });\n+\tif (ret) {\n+\t\tLOG(IPU3, Error) << \"Failed to initialise the IPU3 IPA\";\n+\t\treturn ret;\n+\t}\n \n \treturn 0;\n }\n", "prefixes": [ "libcamera-devel" ] }