Patch Detail
Show a patch.
GET /api/patches/11924/?format=api
{ "id": 11924, "url": "https://patchwork.libcamera.org/api/patches/11924/?format=api", "web_url": "https://patchwork.libcamera.org/patch/11924/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210413215256.2734772-1-niklas.soderlund@ragnatech.se>", "date": "2021-04-13T21:52:56", "name": "[libcamera-devel] lc-compliance: Initialize the event loop pointer", "commit_ref": "6c96861ea36f0596fbf4440e457d9366e6855d19", "pull_url": null, "state": "accepted", "archived": false, "hash": "cee037586e7acfbbe903593939b8ae6256724267", "submitter": { "id": 5, "url": "https://patchwork.libcamera.org/api/people/5/?format=api", "name": "Niklas Söderlund", "email": "niklas.soderlund@ragnatech.se" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/11924/mbox/", "series": [ { "id": 1925, "url": "https://patchwork.libcamera.org/api/series/1925/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1925", "date": "2021-04-13T21:52:56", "name": "[libcamera-devel] lc-compliance: Initialize the event loop pointer", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1925/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/11924/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/11924/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3F84FBD224\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 13 Apr 2021 21:53:05 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0BEF4687D6;\n\tTue, 13 Apr 2021 23:53:05 +0200 (CEST)", "from bin-mail-out-06.binero.net (bin-mail-out-06.binero.net\n\t[195.74.38.229])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9A38D602D1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 13 Apr 2021 23:53:03 +0200 (CEST)", "from bismarck.berto.se (p54ac5521.dip0.t-ipconnect.de\n\t[84.172.85.33])\n\tby bin-vsp-out-03.atm.binero.net (Halon) with ESMTPA\n\tid 9bf08c9c-9ca2-11eb-a9ab-0050569116f7;\n\tTue, 13 Apr 2021 23:53:02 +0200 (CEST)" ], "X-Halon-ID": "9bf08c9c-9ca2-11eb-a9ab-0050569116f7", "Authorized-sender": "niklas.soderlund@fsdn.se", "From": "=?utf-8?q?Niklas_S=C3=B6derlund?= <niklas.soderlund@ragnatech.se>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 13 Apr 2021 23:52:56 +0200", "Message-Id": "<20210413215256.2734772-1-niklas.soderlund@ragnatech.se>", "X-Mailer": "git-send-email 2.31.1", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH] lc-compliance: Initialize the event loop\n\tpointer", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The event loop pointer loop_ was not initialized. This have no effect on\nthe current code flow but could in the future lead to hard debug\nproblems.\n\nSigned-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n---\n src/lc-compliance/simple_capture.cpp | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/lc-compliance/simple_capture.cpp b/src/lc-compliance/simple_capture.cpp\nindex 0ff720bfd0052e45..8f714d3b5e73e28e 100644\n--- a/src/lc-compliance/simple_capture.cpp\n+++ b/src/lc-compliance/simple_capture.cpp\n@@ -10,7 +10,8 @@\n using namespace libcamera;\n \n SimpleCapture::SimpleCapture(std::shared_ptr<Camera> camera)\n-\t: camera_(camera), allocator_(std::make_unique<FrameBufferAllocator>(camera))\n+\t: loop_(nullptr), camera_(camera),\n+\t allocator_(std::make_unique<FrameBufferAllocator>(camera))\n {\n }\n \n", "prefixes": [ "libcamera-devel" ] }