Patch Detail
Show a patch.
GET /api/patches/11909/?format=api
{ "id": 11909, "url": "https://patchwork.libcamera.org/api/patches/11909/?format=api", "web_url": "https://patchwork.libcamera.org/patch/11909/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210413122534.342138-2-kieran.bingham@ideasonboard.com>", "date": "2021-04-13T12:25:32", "name": "[libcamera-devel,1/3] libcamera: ipa_proxy: Scope ProxyState to IPAProxy", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "01bc9d3bb1390619a806a24a9a2864de2c9883fc", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/11909/mbox/", "series": [ { "id": 1918, "url": "https://patchwork.libcamera.org/api/series/1918/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1918", "date": "2021-04-13T12:25:31", "name": "Documentation cleanup", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1918/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/11909/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/11909/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 35A17BD224\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 13 Apr 2021 12:25:43 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E5E1E68800;\n\tTue, 13 Apr 2021 14:25:42 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 97D0E687EC\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 13 Apr 2021 14:25:40 +0200 (CEST)", "from Q.local (cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net\n\t[86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C50F18AF;\n\tTue, 13 Apr 2021 14:25:39 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"dwoioEfL\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1618316739;\n\tbh=L42dyyRK+Oit+tEx0yz6PHx9kue8aWuC+IXDn8z+Gck=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=dwoioEfLA2eKNnRlD9GU2riBUoz7Fm3DcUdVTeoZ9jQqdRc5UPI6eUSaxqaDkm7f9\n\tezRNljtRK7gf1LeW0nxTVfaCkTvpyxdAtRhQF4mGJ3ROte1D/mZaqfO2ZKQiVMGvKg\n\tUUWqZT4qJNn/dApWjaE64ok5diL+6QceAOt1T/r4=", "From": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "To": "libcamera devel <libcamera-devel@lists.libcamera.org>", "Date": "Tue, 13 Apr 2021 13:25:32 +0100", "Message-Id": "<20210413122534.342138-2-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20210413122534.342138-1-kieran.bingham@ideasonboard.com>", "References": "<20210413122534.342138-1-kieran.bingham@ideasonboard.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH 1/3] libcamera: ipa_proxy: Scope\n\tProxyState to IPAProxy", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The ProxyState is only used by the IPAProxy, so it should remain inside\nthat scope. This helps clarify the usage, and improves the\ndocumentation by bringing the (future) ProxyState documentation into the\nclass.\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n include/libcamera/internal/ipa_proxy.h | 12 ++++++------\n 1 file changed, 6 insertions(+), 6 deletions(-)", "diff": "diff --git a/include/libcamera/internal/ipa_proxy.h b/include/libcamera/internal/ipa_proxy.h\nindex 9fe446c35f04..ea9f0760c2fc 100644\n--- a/include/libcamera/internal/ipa_proxy.h\n+++ b/include/libcamera/internal/ipa_proxy.h\n@@ -17,15 +17,15 @@ namespace libcamera {\n \n class IPAModule;\n \n-enum ProxyState {\n-\tProxyStopped,\n-\tProxyStopping,\n-\tProxyRunning,\n-};\n-\n class IPAProxy : public IPAInterface\n {\n public:\n+\tenum ProxyState {\n+\t\tProxyStopped,\n+\t\tProxyStopping,\n+\t\tProxyRunning,\n+\t};\n+\n \tIPAProxy(IPAModule *ipam);\n \t~IPAProxy();\n \n", "prefixes": [ "libcamera-devel", "1/3" ] }