Patch Detail
Show a patch.
GET /api/patches/11879/?format=api
{ "id": 11879, "url": "https://patchwork.libcamera.org/api/patches/11879/?format=api", "web_url": "https://patchwork.libcamera.org/patch/11879/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210409043208.1823330-6-hiroh@chromium.org>", "date": "2021-04-09T04:32:08", "name": "[libcamera-devel,RFC,5/5] android: CameraDevice: Report queried test pattern modes", "commit_ref": null, "pull_url": null, "state": "rfc", "archived": false, "hash": "b1c03721e41dbdf5bbcb341586d62e20de5bb979", "submitter": { "id": 63, "url": "https://patchwork.libcamera.org/api/people/63/?format=api", "name": "Hirokazu Honda", "email": "hiroh@chromium.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/11879/mbox/", "series": [ { "id": 1906, "url": "https://patchwork.libcamera.org/api/series/1906/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1906", "date": "2021-04-09T04:32:03", "name": "Report available test pattern modes", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1906/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/11879/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/11879/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 771A9BD16B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 9 Apr 2021 04:32:25 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 34772687F7;\n\tFri, 9 Apr 2021 06:32:25 +0200 (CEST)", "from mail-pf1-x42e.google.com (mail-pf1-x42e.google.com\n\t[IPv6:2607:f8b0:4864:20::42e])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 917FF687F6\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 9 Apr 2021 06:32:22 +0200 (CEST)", "by mail-pf1-x42e.google.com with SMTP id s11so3416993pfm.1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 08 Apr 2021 21:32:22 -0700 (PDT)", "from hiroh2.tok.corp.google.com\n\t([2401:fa00:8f:2:7567:510e:1b47:ce92])\n\tby smtp.gmail.com with ESMTPSA id\n\til6sm737275pjb.56.2021.04.08.21.32.19\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 08 Apr 2021 21:32:20 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"HnxANvM/\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=rt0niqZ40i9cEjc69uBp4Vek+/PtndSNNMtfOnooYt4=;\n\tb=HnxANvM/9MKi5Uri8y7yzZv19onvBtdHJ4hYt/Z3YAW74OVTrzjlBeB6JYmODiPM54\n\tLSnwYvCt6qm10v8gyrrMjssM9bbST3QvTsvyszhqdjnijsskNyMPvYsta5pl9O5L3CTA\n\tfneDA6RDzzXI/O9LZgvrGgcpg2bTWMu0P/+bI=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=rt0niqZ40i9cEjc69uBp4Vek+/PtndSNNMtfOnooYt4=;\n\tb=BwnJSgjQ0ajw4h27cit/zXbuUZBRwYu7/sm18gSFBlTjoE2yTADPVuvhB0brdG5d7i\n\t9mziHf626pV9LoXsV8bueGdH59wx37pZT0DXm6Q5rb2fPE9eE2dpUY9h9FfHHZSVOOgS\n\tEaJD5Yiq87me5AttxrfSRsaABpkxi/Vqmgb8EuZBVXpo4/l0fy4TpUYXytCEe0mvyhqp\n\tCO+cj0Uf7Zjf2HqfFAS0uWUlsg3pf8MmkMlT/WZ98fdk0j2UFgvQux5CICxXdHSVxuwF\n\t9reQtUeK4s04S+3inizbRNssjJowPALHpZJlnvN282cu3Z2VxD6lAb3TIJX4fmnVppST\n\tB1MQ==", "X-Gm-Message-State": "AOAM5300o3S7O7g7MA/oHo1ynvLLOqd2u6DUUTz56ziSq5r28dWntAAS\n\tm7aMRSrHz5BTlrf1aePtT+AlsuYSF8Y/5Q==", "X-Google-Smtp-Source": "ABdhPJz/BJwhXy2mYFCuJiSUI9atbM+sySGSALys9PoEnfmW9szAp9nOu7YXeICD8yZ0vfbE3iEcMg==", "X-Received": "by 2002:a63:604:: with SMTP id 4mr11261168pgg.267.1617942741087; \n\tThu, 08 Apr 2021 21:32:21 -0700 (PDT)", "From": "Hirokazu Honda <hiroh@chromium.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 9 Apr 2021 13:32:08 +0900", "Message-Id": "<20210409043208.1823330-6-hiroh@chromium.org>", "X-Mailer": "git-send-email 2.31.1.295.g9ea45b61b8-goog", "In-Reply-To": "<20210409043208.1823330-1-hiroh@chromium.org>", "References": "<20210409043208.1823330-1-hiroh@chromium.org>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [RFC PATCH 5/5] android: CameraDevice: Report\n\tqueried test pattern modes", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Report test pattern modes obtained by Camera::controls().\n\nSigned-off-by: Hirokazu Honda <hiroh@chromium.org>\n---\n src/android/camera_device.cpp | 18 ++++++++++++++----\n 1 file changed, 14 insertions(+), 4 deletions(-)", "diff": "diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\nindex 89044efa..8701cc69 100644\n--- a/src/android/camera_device.cpp\n+++ b/src/android/camera_device.cpp\n@@ -1075,12 +1075,22 @@ const camera_metadata_t *CameraDevice::getStaticMetadata()\n \n \tstaticMetadata_->addEntry(ANDROID_SENSOR_ORIENTATION, &orientation_, 1);\n \n-\tstd::vector<int32_t> testPatterModes = {\n-\t\tANDROID_SENSOR_TEST_PATTERN_MODE_OFF,\n+\tconst auto &sensorTestPatternsInfo =\n+\t\tcontrolsInfo.find(&controls::draft::SensorTestPatternMode);\n+\tstd::vector<int32_t> testPatternModes = {\n+\t\tANDROID_SENSOR_TEST_PATTERN_MODE_OFF\n \t};\n+\tif (sensorTestPatternsInfo != controlsInfo.end()) {\n+\t\tconst auto &values = sensorTestPatternsInfo->second.values();\n+\t\tif (!values.empty()) {\n+\t\t\ttestPatternModes.clear();\n+\t\t\tfor (const auto &value : values)\n+\t\t\t\ttestPatternModes.push_back(value.get<int32_t>());\n+\t\t}\n+\t}\n \tstaticMetadata_->addEntry(ANDROID_SENSOR_AVAILABLE_TEST_PATTERN_MODES,\n-\t\t\t\t testPatterModes.data(),\n-\t\t\t\t testPatterModes.size());\n+\t\t\t\t testPatternModes.data(),\n+\t\t\t\t testPatternModes.size());\n \n \tstd::vector<float> physicalSize = {\n \t\t2592, 1944,\n", "prefixes": [ "libcamera-devel", "RFC", "5/5" ] }