Patch Detail
Show a patch.
GET /api/patches/11871/?format=api
{ "id": 11871, "url": "https://patchwork.libcamera.org/api/patches/11871/?format=api", "web_url": "https://patchwork.libcamera.org/patch/11871/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210408133634.16815-2-david.plowman@raspberrypi.com>", "date": "2021-04-08T13:36:32", "name": "[libcamera-devel,v2,1/3] ipa: raspberrypi: Make CamHelper exposure methods virtual", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "7fa0a8cb40fac1ec7942491ae2dbd76623b110c3", "submitter": { "id": 42, "url": "https://patchwork.libcamera.org/api/people/42/?format=api", "name": "David Plowman", "email": "david.plowman@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/11871/mbox/", "series": [ { "id": 1905, "url": "https://patchwork.libcamera.org/api/series/1905/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1905", "date": "2021-04-08T13:36:31", "name": "Raspberry Pi: handle sensors more flexibly", "version": 2, "mbox": "https://patchwork.libcamera.org/series/1905/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/11871/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/11871/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 21424BD16B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 8 Apr 2021 13:36:43 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9F5C6687F8;\n\tThu, 8 Apr 2021 15:36:41 +0200 (CEST)", "from mail-wr1-x433.google.com (mail-wr1-x433.google.com\n\t[IPv6:2a00:1450:4864:20::433])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 78F01602CC\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 8 Apr 2021 15:36:40 +0200 (CEST)", "by mail-wr1-x433.google.com with SMTP id f6so2167431wrv.12\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 08 Apr 2021 06:36:40 -0700 (PDT)", "from pi4-davidp.lan (plowpeople3.plus.com. [80.229.223.72])\n\tby smtp.gmail.com with ESMTPSA id\n\tz18sm13132522wmc.27.2021.04.08.06.36.39\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 08 Apr 2021 06:36:39 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"fO71p/dT\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=mrjhT2FmHfGM+ETL2c8tGFpgFd9U4oNZSbU5UloGtqs=;\n\tb=fO71p/dTsgRkASA+2kJHgAqOz7xU5NzsTI/JKbkmAEU3d9dcouDa74bRuwviOPPHYc\n\tyuD66h0c1r7IYTDYi5Or1ZEh0E/v0dnqTXHr4mwK3x9ZNNICwh0mH/xJ2DXZSW0LjgR4\n\tXf/PYWKlxYfUCJ0Lj/bPLEW0T+Lxbrz+BXSoqz85HrMwny6Mo7+WPjJhKTDEseA+Mt3m\n\tQAkcCI3pKeGttfhMG6LBIGa/ycO33EwZ8F4UHH9kCVjEmXfyQXBsJDoKhNPcZGkQ1ARl\n\t0J9xcBTGSN7oraVVKj5+zgMVYFZOji/KrcsoyLMyIZSxMVxReCp7WdOxQFChmFomgqKG\n\t3E5g==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=mrjhT2FmHfGM+ETL2c8tGFpgFd9U4oNZSbU5UloGtqs=;\n\tb=ITLHJnr4SUoCCA/XM6zKTx6M9OejbsB10jbB+GSj+gPZVFaP+mSTECDDJveoQVI463\n\tQ4cWbEbyddDiNDEjrqPD3+PQrtj7d7wkhBW+KrJ0TcUlscYNKBCtH9ZY8+UThHNoN8k6\n\tcdHBxFyDGleylaJIUtY9fLm61UPur36wND5z8hH1jT1VQI8mPBG6oO2qDudHUl2DGvRF\n\tWr0v5NOGzrAdQb/08Zv5v7JHLsrrckn4i88PBme31EkM7Zkq04pi0Iiew19Fz64KlUQT\n\tCVU8Llm0m2XjN64lsHbwl+iOrU6ltlJPQWGuh3nUrG6v34erqxZVo+RiO6DcznS1tTLk\n\tr2aQ==", "X-Gm-Message-State": "AOAM532p0/esJvNssJmrPbei6J6rrHywJBVwIXMkaKG5QCkSghGCJaaz\n\tlTW8KmlQXw2foG6jyxaJl+/H7Ur05IerFg==", "X-Google-Smtp-Source": "ABdhPJyyWcNVJsRVyT/keBNVl8KDqQ0l+DNhITvlfVy+xmiT0JogyQR46P3yJqEASNG1NhFvT0m/nA==", "X-Received": "by 2002:adf:f908:: with SMTP id\n\tb8mr11244846wrr.184.1617888999952; \n\tThu, 08 Apr 2021 06:36:39 -0700 (PDT)", "From": "David Plowman <david.plowman@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 8 Apr 2021 14:36:32 +0100", "Message-Id": "<20210408133634.16815-2-david.plowman@raspberrypi.com>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20210408133634.16815-1-david.plowman@raspberrypi.com>", "References": "<20210408133634.16815-1-david.plowman@raspberrypi.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v2 1/3] ipa: raspberrypi: Make CamHelper\n\texposure methods virtual", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "This allows derived classes to override them if they have any special\nbehaviours to implement. For instance if a particular camera mode\nproduces a different signal level to other modes, you might choose to\naddress that in the gain or exposure methods.\n\nSigned-off-by: David Plowman <david.plowman@raspberrypi.com>\n---\n src/ipa/raspberrypi/cam_helper.hpp | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/ipa/raspberrypi/cam_helper.hpp b/src/ipa/raspberrypi/cam_helper.hpp\nindex 1b2d6eec..4053a870 100644\n--- a/src/ipa/raspberrypi/cam_helper.hpp\n+++ b/src/ipa/raspberrypi/cam_helper.hpp\n@@ -66,8 +66,8 @@ public:\n \tvirtual ~CamHelper();\n \tvoid SetCameraMode(const CameraMode &mode);\n \tMdParser &Parser() const { return *parser_; }\n-\tuint32_t ExposureLines(double exposure_us) const;\n-\tdouble Exposure(uint32_t exposure_lines) const; // in us\n+\tvirtual uint32_t ExposureLines(double exposure_us) const;\n+\tvirtual double Exposure(uint32_t exposure_lines) const; // in us\n \tvirtual uint32_t GetVBlanking(double &exposure_us, double minFrameDuration,\n \t\t\t\t double maxFrameDuration) const;\n \tvirtual uint32_t GainCode(double gain) const = 0;\n", "prefixes": [ "libcamera-devel", "v2", "1/3" ] }