Patch Detail
Show a patch.
GET /api/patches/11858/?format=api
{ "id": 11858, "url": "https://patchwork.libcamera.org/api/patches/11858/?format=api", "web_url": "https://patchwork.libcamera.org/patch/11858/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210407141041.31087-1-jacopo@jmondi.org>", "date": "2021-04-07T14:10:41", "name": "[libcamera-devel] libcamera: camera_data: Document requestSequence_", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "0b583f21e28468bcaec8d77bb3cf6b91733e37a8", "submitter": { "id": 3, "url": "https://patchwork.libcamera.org/api/people/3/?format=api", "name": "Jacopo Mondi", "email": "jacopo@jmondi.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/11858/mbox/", "series": [ { "id": 1900, "url": "https://patchwork.libcamera.org/api/series/1900/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1900", "date": "2021-04-07T14:10:41", "name": "[libcamera-devel] libcamera: camera_data: Document requestSequence_", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1900/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/11858/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/11858/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BCD5EBD1F6\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 7 Apr 2021 14:10:31 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1F595687A2;\n\tWed, 7 Apr 2021 16:10:31 +0200 (CEST)", "from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net\n\t[217.70.183.199])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3AEA7687A1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 7 Apr 2021 16:10:29 +0200 (CEST)", "from uno.lan (93-34-118-233.ip49.fastwebnet.it [93.34.118.233])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay9-d.mail.gandi.net (Postfix) with ESMTPSA id BC700FF80D;\n\tWed, 7 Apr 2021 14:10:28 +0000 (UTC)" ], "X-Originating-IP": "93.34.118.233", "From": "Jacopo Mondi <jacopo@jmondi.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 7 Apr 2021 16:10:41 +0200", "Message-Id": "<20210407141041.31087-1-jacopo@jmondi.org>", "X-Mailer": "git-send-email 2.31.1", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH] libcamera: camera_data: Document\n\trequestSequence_", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The CameraData::requestSequence_ field was not documented. Fix it.\n\nAlso remove an empty line the class declaration as the field is not\nspecial compared to the other existing ones.\n\nFixes the doxygen warning\n/include/libcamera/internal/pipeline_handler.h:51: warning: Member\nrequestSequence_ (variable) of class libcamera::CameraData is not\ndocumented.\n\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\n\n---\nIsn't it a bit fishy that the counter is never reset ?\n\n---\n include/libcamera/internal/pipeline_handler.h | 1 -\n src/libcamera/pipeline_handler.cpp | 8 ++++++++\n 2 files changed, 8 insertions(+), 1 deletion(-)\n\n--\n2.31.1", "diff": "diff --git a/include/libcamera/internal/pipeline_handler.h b/include/libcamera/internal/pipeline_handler.h\nindex c6454db6b2c4..82fdc1fee9b9 100644\n--- a/include/libcamera/internal/pipeline_handler.h\n+++ b/include/libcamera/internal/pipeline_handler.h\n@@ -47,7 +47,6 @@ public:\n \tstd::list<Request *> queuedRequests_;\n \tControlInfoMap controlInfo_;\n \tControlList properties_;\n-\n \tuint32_t requestSequence_;\n\n private:\ndiff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp\nindex 433c05f60db0..7f4fa1b4ba89 100644\n--- a/src/libcamera/pipeline_handler.cpp\n+++ b/src/libcamera/pipeline_handler.cpp\n@@ -97,6 +97,14 @@ LOG_DEFINE_CATEGORY(Pipeline)\n * when creating the camera, and shall not be modified afterwards.\n */\n\n+/**\n+ * \\var CameraData::requestSequence_\n+ * \\brief The request sequence counter\n+ *\n+ * The request sequence counter is increased when a new Request is queued to\n+ * the camera and monotonically increases during the whole library lifetime.\n+ */\n+\n /**\n * \\class PipelineHandler\n * \\brief Create and manage cameras based on a set of media devices\n", "prefixes": [ "libcamera-devel" ] }