Patch Detail
Show a patch.
GET /api/patches/11835/?format=api
{ "id": 11835, "url": "https://patchwork.libcamera.org/api/patches/11835/?format=api", "web_url": "https://patchwork.libcamera.org/patch/11835/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210404210353.268967-1-pnguyen@baylibre.com>", "date": "2021-04-04T21:03:53", "name": "[libcamera-devel] pipeline: simple: Fix an issue in breadth-first search", "commit_ref": "0373490ef64340ed42a21500b6f9a3575b890ba5", "pull_url": null, "state": "accepted", "archived": false, "hash": "8d3034bcce7915b8431ed4e8e8023a28ae2a2131", "submitter": { "id": 79, "url": "https://patchwork.libcamera.org/api/people/79/?format=api", "name": "Phi-bang Nguyen", "email": "pnguyen@baylibre.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/11835/mbox/", "series": [ { "id": 1891, "url": "https://patchwork.libcamera.org/api/series/1891/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1891", "date": "2021-04-04T21:03:53", "name": "[libcamera-devel] pipeline: simple: Fix an issue in breadth-first search", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1891/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/11835/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/11835/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CDC97BD695\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSun, 4 Apr 2021 21:04:27 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2B6E268787;\n\tSun, 4 Apr 2021 23:04:27 +0200 (CEST)", "from mail-wr1-x432.google.com (mail-wr1-x432.google.com\n\t[IPv6:2a00:1450:4864:20::432])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id ED60F6877C\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 4 Apr 2021 23:04:25 +0200 (CEST)", "by mail-wr1-x432.google.com with SMTP id a6so3295203wrw.8\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 04 Apr 2021 14:04:25 -0700 (PDT)", "from localhost.localdomain (206.159.69.91.rev.sfr.net.\n\t[91.69.159.206]) by smtp.googlemail.com with ESMTPSA id\n\ts21sm21169803wmc.10.2021.04.04.14.04.24\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tSun, 04 Apr 2021 14:04:24 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=baylibre-com.20150623.gappssmtp.com\n\theader.i=@baylibre-com.20150623.gappssmtp.com\n\theader.b=\"KadKlyWq\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=baylibre-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=RQzIuUQgZrycDpSkQWiGzWHc26o0OXGmSsI/bMpczf0=;\n\tb=KadKlyWqMcFNTGFY6vHb8L8JM126zKd9z40XrzmFq5ixTskH6S9aWAi8PLy/w/s62x\n\tY7ff95X+q93VjZaLq5RLPyco/tYauQt1bTrNPhn4WauAKfocDJteL2ihmWv2y34JlGgJ\n\tP3XdD0LhI8tBIx7HQOu94ZetWiM+Iy6Q27O7NnXdc6j5AFLBkxihccCTtI5/S34mWELd\n\t4R3tbcXTif6vpJ37Y2ZJKrbVPr689e/KjOMjsMMrRojL47+vOOBi0TF+I6rPMG19mJMG\n\tjyiQDTEB0vE/oz0JP+m++A/P4ZeyM+KO9dHBpZiBxyKoKLMffqRiCAx9OCF0yplAcCtk\n\thSNg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=RQzIuUQgZrycDpSkQWiGzWHc26o0OXGmSsI/bMpczf0=;\n\tb=pzABXFfUq07tur59G0kPpOX/OX1DKKH+P6iA0CwPyBZ7zkUehQL4BNZfscZ0zEULPk\n\tP4DsjH51W9m0azmEmhKY+VNzYgvVOe4pV/ZWCCoxEJmsqVP/lZf2vLFC9gR5JD+7oVn5\n\tRtZ3hJyije7jK+vHJJPDXc6r2IBAfmIoAgll7UnkBNDnRh5A31VVgMIP7huegkvtUKiV\n\tQa3VwdH8WmsvqEtX+iwMRoakRNldQcPZIr2S+9hPmvVItVv9ZlJE4ZULoYdt5KBNdJZq\n\ttMcOQNL1LH+vCZIu3fblxbU5txT9q4WJArAPdKoeN4tIVve5W4luweAQCjDnr8S9P2je\n\t6UzA==", "X-Gm-Message-State": "AOAM532sfczGHcBux93wtF+OnLQ+Kyd+/CRWgDgSrXPO5czYXWKC4dxw\n\tUIn2zAVzw4xngK9HCB7c1l9iCu8t7bwIoQ==", "X-Google-Smtp-Source": "ABdhPJyPGgaRgYz7P+RRTQmS6y46hHUA44Ek1KOnt3Ob4koyqornOpM9PbtFq3HCveZm0K36G0sD6A==", "X-Received": "by 2002:a05:6000:1ce:: with SMTP id\n\tt14mr25583946wrx.85.1617570265326; \n\tSun, 04 Apr 2021 14:04:25 -0700 (PDT)", "From": "Phi-Bang Nguyen <pnguyen@baylibre.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Sun, 4 Apr 2021 23:03:53 +0200", "Message-Id": "<20210404210353.268967-1-pnguyen@baylibre.com>", "X-Mailer": "git-send-email 2.25.1", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH] pipeline: simple: Fix an issue in\n\tbreadth-first search", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "When seting up the pipeline, the latest entity in the queue is\ntaken but the oldest one is poped. This is a mistake. Fix it.\n\nFixes: 4671911df040 (\"pipeline: simple: Use breadth-first search\nto setup media pipeline\")\n\nSigned-off-by: Phi-Bang Nguyen <pnguyen@baylibre.com>\n---\n src/libcamera/pipeline/simple/simple.cpp | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)", "diff": "diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\nindex f81a4d15..a2dbc336 100644\n--- a/src/libcamera/pipeline/simple/simple.cpp\n+++ b/src/libcamera/pipeline/simple/simple.cpp\n@@ -288,12 +288,12 @@ SimpleCameraData::SimpleCameraData(SimplePipelineHandler *pipe,\n \n \t/* Remember at each entity where we came from. */\n \tstd::unordered_map<MediaEntity *, Entity> parents;\n-\tqueue.push(sensor);\n-\n \tMediaEntity *entity = nullptr;\n \n+\tqueue.push(sensor);\n+\n \twhile (!queue.empty()) {\n-\t\tentity = queue.back();\n+\t\tentity = queue.front();\n \t\tqueue.pop();\n \n \t\t/* Found the capture device. */\n", "prefixes": [ "libcamera-devel" ] }