Patch Detail
Show a patch.
GET /api/patches/11828/?format=api
{ "id": 11828, "url": "https://patchwork.libcamera.org/api/patches/11828/?format=api", "web_url": "https://patchwork.libcamera.org/patch/11828/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210403131015.1590399-4-hiroh@chromium.org>", "date": "2021-04-03T13:10:15", "name": "[libcamera-devel,v4,4/4] android: CameraDevice: Deny non ROTATION_0 stream configuration", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "1a19f59d5284f4125628d71ee76d84d74120dd83", "submitter": { "id": 63, "url": "https://patchwork.libcamera.org/api/people/63/?format=api", "name": "Hirokazu Honda", "email": "hiroh@chromium.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/11828/mbox/", "series": [ { "id": 1885, "url": "https://patchwork.libcamera.org/api/series/1885/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1885", "date": "2021-04-03T13:10:13", "name": null, "version": 4, "mbox": "https://patchwork.libcamera.org/series/1885/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/11828/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/11828/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0AA88C0DA3\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSat, 3 Apr 2021 13:10:29 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B28F268798;\n\tSat, 3 Apr 2021 15:10:28 +0200 (CEST)", "from mail-pl1-x636.google.com (mail-pl1-x636.google.com\n\t[IPv6:2607:f8b0:4864:20::636])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 59B7168791\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 3 Apr 2021 15:10:27 +0200 (CEST)", "by mail-pl1-x636.google.com with SMTP id t5so1698701plg.9\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 03 Apr 2021 06:10:27 -0700 (PDT)", "from hiroh2.tok.corp.google.com\n\t([2401:fa00:8f:2:d1f5:1b96:f027:f646])\n\tby smtp.gmail.com with ESMTPSA id\n\th6sm11303271pfb.157.2021.04.03.06.10.24\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tSat, 03 Apr 2021 06:10:25 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"FzOruzt3\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=mNIc070cnoO6de/trc4kKmm+W/FgPNJRZXCbAsx3nNY=;\n\tb=FzOruzt3IJzWrPxDbawKMbqjoYD7W4jfc+0EaVqwNO3OFTMNpX8U3qP5vfsWfhxV88\n\th5ykwqPkT/q20nzj+3b2sW/PfZiMM+/pbA/f+QHkrkgBZgRSGiZCrLpHzZyGzmWHrWwZ\n\tWiTE46GSkgPN3WsHpWRTDvHtDoxa/+LuvyGEU=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=mNIc070cnoO6de/trc4kKmm+W/FgPNJRZXCbAsx3nNY=;\n\tb=gR/qCrLzErKXikASQ3B7ldifbYjb2laSI2fnXFlrmBu86Z3p/OZpLYe0+V3AijMeN4\n\tK+68hPhYjQD6ouq06sxXMa1amsCx3vtoclS22AFHAbyj9G2C8IVlbXqtfnjNKpDejgTR\n\tqO0CXqQZYgYrxUMc9BfeaKkqUL+FtglrkrBe2QLnpZmEve6cJzUJeLhTeLmRPrZQtWVR\n\tckNs11NDazRLzth29UUiDCvQyHt7x1ous2diLF0waHdrGXkYDAc9qqKebipsksMUZw9I\n\tUbNyXpYjWzzZNImDyt9D/dYy4loDOQiWTf2w7s53jlzp9ndXdus6YZE7caLyi62nRvOh\n\tF5/w==", "X-Gm-Message-State": "AOAM530R6mWYPhApGJuDPVMHaHM1K/q08EdhcxZ2aDOnkD035JcYZhXE\n\tGeAZ5h7VZTWuVmRaTJDpTSHUJ3cxCSfNvA==", "X-Google-Smtp-Source": "ABdhPJwd0x6mqoSZuqsnXiNkDRQCNIgVlTJ51SM5Q9mJMKn4D56wpWaaFpLBy9Jfkjh8w0AjF/coJw==", "X-Received": "by 2002:a17:903:22d1:b029:e7:1052:a979 with SMTP id\n\ty17-20020a17090322d1b02900e71052a979mr16729357plg.16.1617455425772; \n\tSat, 03 Apr 2021 06:10:25 -0700 (PDT)", "From": "Hirokazu Honda <hiroh@chromium.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Sat, 3 Apr 2021 22:10:15 +0900", "Message-Id": "<20210403131015.1590399-4-hiroh@chromium.org>", "X-Mailer": "git-send-email 2.31.0.208.g409f899ff0-goog", "In-Reply-To": "<20210403131015.1590399-1-hiroh@chromium.org>", "References": "<20210403131015.1590399-1-hiroh@chromium.org>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v4 4/4] android: CameraDevice: Deny non\n\tROTATION_0 stream configuration", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "libcamera doesn't handle crop_rotate_scale_degrees. Therefore,\nif it is requested, that is, crop_rotate_scale_degrees is not\nCAMERA3_STREAM_ROTATION_0, the configuration should fail.\n\nSigned-off-by: Hirokazu Honda <hiroh@chromium.org>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nReviewed-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n src/android/camera_device.cpp | 12 ++++++++++++\n 1 file changed, 12 insertions(+)", "diff": "diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\nindex ddac56da..2c8f76e7 100644\n--- a/src/android/camera_device.cpp\n+++ b/src/android/camera_device.cpp\n@@ -1656,6 +1656,18 @@ int CameraDevice::configureStreams(camera3_stream_configuration_t *stream_list)\n \t\tif (!format.isValid())\n \t\t\treturn -EINVAL;\n \n+\t\t/* \\todo Support rotation. */\n+\t\tif (stream->rotation != CAMERA3_STREAM_ROTATION_0) {\n+\t\t\tLOG(HAL, Error) << \"Rotation is not supported\";\n+\t\t\treturn -EINVAL;\n+\t\t}\n+#if defined(OS_CHROMEOS)\n+\t\tif (stream->crop_rotate_scale_degrees != CAMERA3_STREAM_ROTATION_0) {\n+\t\t\tLOG(HAL, Error) << \"Rotation is not supported\";\n+\t\t\treturn -EINVAL;\n+\t\t}\n+#endif\n+\n \t\t/* Defer handling of MJPEG streams until all others are known. */\n \t\tif (stream->format == HAL_PIXEL_FORMAT_BLOB) {\n \t\t\tif (jpegStream) {\n", "prefixes": [ "libcamera-devel", "v4", "4/4" ] }