Patch Detail
Show a patch.
GET /api/patches/11822/?format=api
{ "id": 11822, "url": "https://patchwork.libcamera.org/api/patches/11822/?format=api", "web_url": "https://patchwork.libcamera.org/patch/11822/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210402021238.1297591-3-hiroh@chromium.org>", "date": "2021-04-02T02:12:38", "name": "[libcamera-devel,v5,2/2] android: CameraDevice: Fix Camera3RequestDescriptor leakage", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "72f69ab1b9c1b7868cb21afde67edacf2f1c23f5", "submitter": { "id": 63, "url": "https://patchwork.libcamera.org/api/people/63/?format=api", "name": "Hirokazu Honda", "email": "hiroh@chromium.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/11822/mbox/", "series": [ { "id": 1882, "url": "https://patchwork.libcamera.org/api/series/1882/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1882", "date": "2021-04-02T02:12:36", "name": "Fix Camera3RequestDescriptor leakage", "version": 5, "mbox": "https://patchwork.libcamera.org/series/1882/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/11822/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/11822/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CF629BD695\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 2 Apr 2021 02:12:51 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 329D568780;\n\tFri, 2 Apr 2021 04:12:51 +0200 (CEST)", "from mail-pl1-x629.google.com (mail-pl1-x629.google.com\n\t[IPv6:2607:f8b0:4864:20::629])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0C4A268780\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 2 Apr 2021 04:12:50 +0200 (CEST)", "by mail-pl1-x629.google.com with SMTP id f17so1931058plr.0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 01 Apr 2021 19:12:49 -0700 (PDT)", "from hiroh2.tok.corp.google.com\n\t([2401:fa00:8f:2:908:1da:b07c:32bc])\n\tby smtp.gmail.com with ESMTPSA id p4sm86902pjk.57.2021.04.01.19.12.47\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 01 Apr 2021 19:12:47 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"aOoWuYX8\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=JCSQ+v9lhJGtYTCD7hMrSkJDED8YDPSBgNcSanoVgks=;\n\tb=aOoWuYX8UD2ABfbrFV0FfsnNor9EDp20LRSsUzDT+tqdCucwM56cCo3hNY9ZivBITm\n\tkaZ92YfrYnewI+gwYlH2YKyW3WRSAM7KUhGjYJISNbJPSGcGs4VPmCJnXS8nXN7BsYhN\n\tv9mNN0bCmMqKo+5h2ReARx9DFWr4qZfzSRlpk=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=JCSQ+v9lhJGtYTCD7hMrSkJDED8YDPSBgNcSanoVgks=;\n\tb=XeqMKUA1HKIR6PanWmAFS5arMXTXHvaT3WmR+Zw8l9Olmap68oJuFEeFM312Q6Mbom\n\tDKxOe8NqEF8z/lu1PG6gRkwx0mdMwxgX8QNLi6TyFxXJE9lwzLH+nIjlqkcia+u6dYAj\n\tbU9PiYRxbs1TJxTiJ1+FufRpSJkIThJENXHYRokTcXnZ5edXInIJ1OBWrlCari2PfG0f\n\t+kxOJRxb5hV2RrrhA6VjfDu4wEpdeQyH5NQJNAvAdtwmL7I/J9XkkwhxeTRT2beXhzBD\n\tseKO5hRsprd/MXl5taDBFPcy34Egaytz0B69oPzXXm87i+gssqPShe88UcPIKQvJLbBy\n\tdkcg==", "X-Gm-Message-State": "AOAM533uyISxO2Eqs+YxoRvks/7dS5pVd40h8o6IZQwTnnvr1bruneHO\n\tt4OkWA06abSqQU5+iYeMy1A4oXrQcSkTgQ==", "X-Google-Smtp-Source": "ABdhPJwefR5VvlxTxtPXG6uEIOVwDXz4sJWr2Uoo0mXkez6VgjoIlvqYxttR0Xpk8i7vaHrKDzfShw==", "X-Received": "by 2002:a17:903:10d:b029:e7:3875:33ed with SMTP id\n\ty13-20020a170903010db02900e7387533edmr10791120plc.34.1617329568320; \n\tThu, 01 Apr 2021 19:12:48 -0700 (PDT)", "From": "Hirokazu Honda <hiroh@chromium.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 2 Apr 2021 11:12:38 +0900", "Message-Id": "<20210402021238.1297591-3-hiroh@chromium.org>", "X-Mailer": "git-send-email 2.31.0.208.g409f899ff0-goog", "In-Reply-To": "<20210402021238.1297591-1-hiroh@chromium.org>", "References": "<20210402021238.1297591-1-hiroh@chromium.org>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v5 2/2] android: CameraDevice: Fix\n\tCamera3RequestDescriptor leakage", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "CameraDevice creates Camera3RequestDescriptor in\nprocessCaptureRequest() and disallocates in requestComplete().\nCamera3RequestDescriptor can never be destroyed if\nrequestComplete() is never called. This avoid the memory\nleakage by storing them in map CameraRequestDescriptor.\n\nSigned-off-by: Hirokazu Honda <hiroh@chromium.org>\n---\n src/android/camera_device.cpp | 83 +++++++++++++++++++++--------------\n src/android/camera_device.h | 11 +++--\n src/android/camera_worker.cpp | 4 +-\n src/android/camera_worker.h | 2 +-\n 4 files changed, 60 insertions(+), 40 deletions(-)", "diff": "diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\nindex b45d3a54..3d98e54c 100644\n--- a/src/android/camera_device.cpp\n+++ b/src/android/camera_device.cpp\n@@ -9,9 +9,11 @@\n #include \"camera_ops.h\"\n #include \"post_processor.h\"\n \n+#include <chrono>\n #include <cmath>\n #include <fstream>\n #include <sys/mman.h>\n+#include <thread>\n #include <tuple>\n #include <vector>\n \n@@ -287,15 +289,11 @@ CameraDevice::Camera3RequestDescriptor::Camera3RequestDescriptor(\n \n \t/*\n \t * Create the libcamera::Request unique_ptr<> to tie its lifetime\n-\t * to the descriptor's one. Set the descriptor's address as the\n-\t * request's cookie to retrieve it at completion time.\n+\t * to the descriptor's one.\n \t */\n-\trequest_ = std::make_unique<CaptureRequest>(camera,\n-\t\t\t\t\t\t reinterpret_cast<uint64_t>(this));\n+\trequest_ = std::make_unique<CaptureRequest>(camera);\n }\n \n-CameraDevice::Camera3RequestDescriptor::~Camera3RequestDescriptor() = default;\n-\n /*\n * \\class CameraDevice\n *\n@@ -672,6 +670,7 @@ void CameraDevice::stop()\n \tworker_.stop();\n \tcamera_->stop();\n \n+\tdescriptors_.clear();\n \trunning_ = false;\n }\n \n@@ -1818,8 +1817,8 @@ int CameraDevice::processCaptureRequest(camera3_capture_request_t *camera3Reques\n \t * The descriptor and the associated memory reserved here are freed\n \t * at request complete time.\n \t */\n-\tCamera3RequestDescriptor *descriptor =\n-\t\tnew Camera3RequestDescriptor(camera_.get(), camera3Request);\n+\tCamera3RequestDescriptor descriptor(camera_.get(), camera3Request);\n+\n \t/*\n \t * \\todo The Android request model is incremental, settings passed in\n \t * previous requests are to be effective until overridden explicitly in\n@@ -1829,12 +1828,12 @@ int CameraDevice::processCaptureRequest(camera3_capture_request_t *camera3Reques\n \tif (camera3Request->settings)\n \t\tlastSettings_ = camera3Request->settings;\n \telse\n-\t\tdescriptor->settings_ = lastSettings_;\n+\t\tdescriptor.settings_ = lastSettings_;\n \n-\tLOG(HAL, Debug) << \"Queueing request \" << descriptor->request_->cookie()\n-\t\t\t<< \" with \" << descriptor->buffers_.size() << \" streams\";\n-\tfor (unsigned int i = 0; i < descriptor->buffers_.size(); ++i) {\n-\t\tconst camera3_stream_buffer_t &camera3Buffer = descriptor->buffers_[i];\n+\tLOG(HAL, Debug) << \"Queueing request \" << descriptor.request_->cookie()\n+\t\t\t<< \" with \" << descriptor.buffers_.size() << \" streams\";\n+\tfor (unsigned int i = 0; i < descriptor.buffers_.size(); ++i) {\n+\t\tconst camera3_stream_buffer_t &camera3Buffer = descriptor.buffers_[i];\n \t\tcamera3_stream *camera3Stream = camera3Buffer.stream;\n \t\tCameraStream *cameraStream = static_cast<CameraStream *>(camera3Stream->priv);\n \n@@ -1867,7 +1866,7 @@ int CameraDevice::processCaptureRequest(camera3_capture_request_t *camera3Reques\n \t\t\t * lifetime management only.\n \t\t\t */\n \t\t\tbuffer = createFrameBuffer(*camera3Buffer.buffer);\n-\t\t\tdescriptor->frameBuffers_.emplace_back(buffer);\n+\t\t\tdescriptor.frameBuffers_.emplace_back(buffer);\n \t\t\tLOG(HAL, Debug) << ss.str() << \" (direct)\";\n \t\t\tbreak;\n \n@@ -1886,11 +1885,10 @@ int CameraDevice::processCaptureRequest(camera3_capture_request_t *camera3Reques\n \n \t\tif (!buffer) {\n \t\t\tLOG(HAL, Error) << \"Failed to create buffer\";\n-\t\t\tdelete descriptor;\n \t\t\treturn -ENOMEM;\n \t\t}\n \n-\t\tdescriptor->request_->addBuffer(cameraStream->stream(), buffer,\n+\t\tdescriptor.request_->addBuffer(cameraStream->stream(), buffer,\n \t\t\t\t\t\tcamera3Buffer.acquire_fence);\n \t}\n \n@@ -1898,11 +1896,16 @@ int CameraDevice::processCaptureRequest(camera3_capture_request_t *camera3Reques\n \t * Translate controls from Android to libcamera and queue the request\n \t * to the CameraWorker thread.\n \t */\n-\tint ret = processControls(descriptor);\n+\tint ret = processControls(&descriptor);\n \tif (ret)\n \t\treturn ret;\n \n-\tworker_.queueRequest(descriptor->request_.get());\n+\tworker_.queueRequest(descriptor.request_.get());\n+\n+\t{\n+\t\tstd::scoped_lock<std::mutex> lock(mutex_);\n+\t\tdescriptors_[descriptor.request_->cookie()] = std::move(descriptor);\n+\t}\n \n \treturn 0;\n }\n@@ -1912,8 +1915,18 @@ void CameraDevice::requestComplete(Request *request)\n \tconst Request::BufferMap &buffers = request->buffers();\n \tcamera3_buffer_status status = CAMERA3_BUFFER_STATUS_OK;\n \tstd::unique_ptr<CameraMetadata> resultMetadata;\n-\tCamera3RequestDescriptor *descriptor =\n-\t\treinterpret_cast<Camera3RequestDescriptor *>(request->cookie());\n+\n+\tCamera3RequestDescriptor descriptor;\n+\t{\n+\t\tstd::scoped_lock<std::mutex> lock(mutex_);\n+\t\tauto it = descriptors_.find(request->cookie());\n+\t\tif (it == descriptors_.end()) {\n+\t\t\tLOG(HAL, Error) << \"Unknown request: \" << request->cookie();\n+\t\t\tstatus = CAMERA3_BUFFER_STATUS_ERROR;\n+\t\t\treturn;\n+\t\t}\n+\t\tdescriptor = std::move(it->second);\n+\t}\n \n \tif (request->status() != Request::RequestComplete) {\n \t\tLOG(HAL, Error) << \"Request not successfully completed: \"\n@@ -1922,7 +1935,7 @@ void CameraDevice::requestComplete(Request *request)\n \t}\n \n \tLOG(HAL, Debug) << \"Request \" << request->cookie() << \" completed with \"\n-\t\t\t<< descriptor->buffers_.size() << \" streams\";\n+\t\t\t<< descriptor.buffers_.size() << \" streams\";\n \n \t/*\n \t * \\todo The timestamp used for the metadata is currently always taken\n@@ -1931,10 +1944,10 @@ void CameraDevice::requestComplete(Request *request)\n \t * pipeline handlers) timestamp in the Request itself.\n \t */\n \tuint64_t timestamp = buffers.begin()->second->metadata().timestamp;\n-\tresultMetadata = getResultMetadata(*descriptor, timestamp);\n+\tresultMetadata = getResultMetadata(descriptor, timestamp);\n \n \t/* Handle any JPEG compression. */\n-\tfor (camera3_stream_buffer_t &buffer : descriptor->buffers_) {\n+\tfor (camera3_stream_buffer_t &buffer : descriptor.buffers_) {\n \t\tCameraStream *cameraStream =\n \t\t\tstatic_cast<CameraStream *>(buffer.stream->priv);\n \n@@ -1949,7 +1962,7 @@ void CameraDevice::requestComplete(Request *request)\n \n \t\tint ret = cameraStream->process(*src,\n \t\t\t\t\t\t*buffer.buffer,\n-\t\t\t\t\t\tdescriptor->settings_,\n+\t\t\t\t\t\tdescriptor.settings_,\n \t\t\t\t\t\tresultMetadata.get());\n \t\tif (ret) {\n \t\t\tstatus = CAMERA3_BUFFER_STATUS_ERROR;\n@@ -1966,17 +1979,17 @@ void CameraDevice::requestComplete(Request *request)\n \n \t/* Prepare to call back the Android camera stack. */\n \tcamera3_capture_result_t captureResult = {};\n-\tcaptureResult.frame_number = descriptor->frameNumber_;\n-\tcaptureResult.num_output_buffers = descriptor->buffers_.size();\n-\tfor (camera3_stream_buffer_t &buffer : descriptor->buffers_) {\n+\tcaptureResult.frame_number = descriptor.frameNumber_;\n+\tcaptureResult.num_output_buffers = descriptor.buffers_.size();\n+\tfor (camera3_stream_buffer_t &buffer : descriptor.buffers_) {\n \t\tbuffer.acquire_fence = -1;\n \t\tbuffer.release_fence = -1;\n \t\tbuffer.status = status;\n \t}\n-\tcaptureResult.output_buffers = descriptor->buffers_.data();\n+\tcaptureResult.output_buffers = descriptor.buffers_.data();\n \n \tif (status == CAMERA3_BUFFER_STATUS_OK) {\n-\t\tnotifyShutter(descriptor->frameNumber_, timestamp);\n+\t\tnotifyShutter(descriptor.frameNumber_, timestamp);\n \n \t\tcaptureResult.partial_result = 1;\n \t\tcaptureResult.result = resultMetadata->get();\n@@ -1989,13 +2002,15 @@ void CameraDevice::requestComplete(Request *request)\n \t\t * is here signalled. Make sure the error path plays well with\n \t\t * the camera stack state machine.\n \t\t */\n-\t\tnotifyError(descriptor->frameNumber_,\n-\t\t\t descriptor->buffers_[0].stream);\n+\t\tnotifyError(descriptor.frameNumber_,\n+\t\t\t descriptor.buffers_[0].stream);\n \t}\n \n-\tcallbacks_->process_capture_result(callbacks_, &captureResult);\n-\n-\tdelete descriptor;\n+\t{\n+\t\tstd::scoped_lock<std::mutex> lock(mutex_);\n+\t\tdescriptors_.erase(request->cookie());\n+\t\tcallbacks_->process_capture_result(callbacks_, &captureResult);\n+\t}\n }\n \n std::string CameraDevice::logPrefix() const\ndiff --git a/src/android/camera_device.h b/src/android/camera_device.h\nindex 39cf95ad..e4ee0cb0 100644\n--- a/src/android/camera_device.h\n+++ b/src/android/camera_device.h\n@@ -9,6 +9,7 @@\n \n #include <map>\n #include <memory>\n+#include <mutex>\n #include <tuple>\n #include <vector>\n \n@@ -61,7 +62,6 @@ public:\n \tint configureStreams(camera3_stream_configuration_t *stream_list);\n \tint processCaptureRequest(camera3_capture_request_t *request);\n \tvoid requestComplete(libcamera::Request *request);\n-\n protected:\n \tstd::string logPrefix() const override;\n \n@@ -69,11 +69,13 @@ private:\n \tCameraDevice(unsigned int id, std::shared_ptr<libcamera::Camera> camera);\n \n \tstruct Camera3RequestDescriptor {\n+\t\tCamera3RequestDescriptor() = default;\n+\t\t~Camera3RequestDescriptor() = default;\n \t\tCamera3RequestDescriptor(libcamera::Camera *camera,\n \t\t\t\t\t const camera3_capture_request_t *camera3Request);\n-\t\t~Camera3RequestDescriptor();\n+\t\tCamera3RequestDescriptor &operator=(Camera3RequestDescriptor &&) = default;\n \n-\t\tuint32_t frameNumber_;\n+\t\tuint32_t frameNumber_ = 0;\n \t\tstd::vector<camera3_stream_buffer_t> buffers_;\n \t\tstd::vector<std::unique_ptr<libcamera::FrameBuffer>> frameBuffers_;\n \t\tCameraMetadata settings_;\n@@ -124,6 +126,9 @@ private:\n \tstd::map<int, libcamera::PixelFormat> formatsMap_;\n \tstd::vector<CameraStream> streams_;\n \n+\tstd::mutex mutex_;\n+\tstd::map<uint64_t, Camera3RequestDescriptor> descriptors_;\n+\n \tstd::string maker_;\n \tstd::string model_;\n \ndiff --git a/src/android/camera_worker.cpp b/src/android/camera_worker.cpp\nindex df436460..300ddde0 100644\n--- a/src/android/camera_worker.cpp\n+++ b/src/android/camera_worker.cpp\n@@ -26,10 +26,10 @@ LOG_DECLARE_CATEGORY(HAL)\n * by the CameraWorker which queues it to the libcamera::Camera after handling\n * fences.\n */\n-CaptureRequest::CaptureRequest(libcamera::Camera *camera, uint64_t cookie)\n+CaptureRequest::CaptureRequest(libcamera::Camera *camera)\n \t: camera_(camera)\n {\n-\trequest_ = camera_->createRequest(cookie);\n+\trequest_ = camera_->createRequest(reinterpret_cast<uint64_t>(this));\n }\n \n void CaptureRequest::addBuffer(Stream *stream, FrameBuffer *buffer, int fence)\ndiff --git a/src/android/camera_worker.h b/src/android/camera_worker.h\nindex d7060576..64b1658b 100644\n--- a/src/android/camera_worker.h\n+++ b/src/android/camera_worker.h\n@@ -22,7 +22,7 @@ class CameraDevice;\n class CaptureRequest\n {\n public:\n-\tCaptureRequest(libcamera::Camera *camera, uint64_t cookie);\n+\tCaptureRequest(libcamera::Camera *camera);\n \n \tconst std::vector<int> &fences() const { return acquireFences_; }\n \tlibcamera::ControlList &controls() { return request_->controls(); }\n", "prefixes": [ "libcamera-devel", "v5", "2/2" ] }