Patch Detail
Show a patch.
GET /api/patches/11788/?format=api
{ "id": 11788, "url": "https://patchwork.libcamera.org/api/patches/11788/?format=api", "web_url": "https://patchwork.libcamera.org/patch/11788/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210330075626.996126-1-naush@raspberrypi.com>", "date": "2021-03-30T07:56:26", "name": "[libcamera-devel] pipeline: raspberrypi: Fix typo in a comment", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "ff67306a993d9f1e4420491b74bc9974936844ec", "submitter": { "id": 34, "url": "https://patchwork.libcamera.org/api/people/34/?format=api", "name": "Naushir Patuck", "email": "naush@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/11788/mbox/", "series": [ { "id": 1869, "url": "https://patchwork.libcamera.org/api/series/1869/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1869", "date": "2021-03-30T07:56:26", "name": "[libcamera-devel] pipeline: raspberrypi: Fix typo in a comment", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1869/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/11788/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/11788/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 81B66C0DA3\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 30 Mar 2021 07:56:35 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A93FF68786;\n\tTue, 30 Mar 2021 09:56:34 +0200 (CEST)", "from mail-wm1-x336.google.com (mail-wm1-x336.google.com\n\t[IPv6:2a00:1450:4864:20::336])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 844D26877C\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 30 Mar 2021 09:56:32 +0200 (CEST)", "by mail-wm1-x336.google.com with SMTP id\n\ty124-20020a1c32820000b029010c93864955so9720995wmy.5\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 30 Mar 2021 00:56:32 -0700 (PDT)", "from naush-laptop.patuck.local ([88.97.76.4])\n\tby smtp.gmail.com with ESMTPSA id\n\ty18sm33251106wrq.61.2021.03.30.00.56.30\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 30 Mar 2021 00:56:31 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"OAFl6fsj\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=b3eatZDCgsI1kFnVCfHq0Wjd0BC0RTxt2A4BaHUITXw=;\n\tb=OAFl6fsj6GsLySTtchu0dvyd1dfYqYI02bTTkfFKvIK7ASkIrc5RLNPTva5kvZ57QL\n\tDSwkZe6y7EXAawO7r42XZqKo4ZR+c3oOfjqn9mjuczcepAjkOvCh6l4cdDgtCaAjas9d\n\tX7IuaPEFcKNgBEUwmun1F8bNXoQ7A6pGSpKpAnRZsJRKQtwbaPPPFDzudq+IsrcgH9ru\n\tIpKKebhCLf/WseGIdK0D5kX2cNg2uCg5nk3BIgkp1eKSPf7JY01Y1OPlDPHaLuQYZ2sv\n\tAtK6+rJI8y42J3M8eskBYleCe9S04ozRtVFhfLh32B9fwsSLJEkG0sPbeMF1y+OfkqqH\n\tVt0Q==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=b3eatZDCgsI1kFnVCfHq0Wjd0BC0RTxt2A4BaHUITXw=;\n\tb=rEnUjqcuYb9ECsg3Z7HzeJXPeMp0kDYLi5zWNGeD0BuOy5s0Lp1MQRmWzrPS57KPnn\n\tcp2nvgxDe+IyMI241jGtOXPxguWJhBtTcM9ZanyvTg3jfMcQE/UiEyS493yncTMrj0Xv\n\tv4WBLq7WU4CbbtjTepDR3gbxXbI3KNSQTURihHbobcFUgvCzKQceyWNprL9+dwKuFUNV\n\tKgdWDCYJTdZLpve/RecSzmKfgomxH9WPD/lrDgxkjSLtnprFr2ro0OtEXBAtQ2EI8A5p\n\tjmtyztpBjY7iui5Nvb6unAAPrzzKw04AVeK+NYSunIpmpTh5lOXSd5VX90FMiq9e08ig\n\t4Icg==", "X-Gm-Message-State": "AOAM533yxHaaicf6qClrHZO7l7Hpy+/khuP1kpRG27sBGYp70GbVW4HH\n\tH8cBsFvWlu3Dg7CxV/4GMLlLAaMBJgXlCQ==", "X-Google-Smtp-Source": "ABdhPJxkxXu0U2j3feJEsK+UPbejQbtzcS6/r9UOntES0fpAHJjl0G4iJtLB0yQHV0idDjS3jXrsuQ==", "X-Received": "by 2002:a1c:bac2:: with SMTP id\n\tk185mr2747106wmf.148.1617090991913; \n\tTue, 30 Mar 2021 00:56:31 -0700 (PDT)", "From": "Naushir Patuck <naush@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 30 Mar 2021 08:56:26 +0100", "Message-Id": "<20210330075626.996126-1-naush@raspberrypi.com>", "X-Mailer": "git-send-email 2.25.1", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH] pipeline: raspberrypi: Fix typo in a\n\tcomment", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "s/embedded/bayer/\n\nSigned-off-by: Naushir Patuck <naush@raspberrypi.com>\n---\n src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\nindex f22e286ed87a..2a917455500f 100644\n--- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n+++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n@@ -1802,7 +1802,7 @@ bool RPiCameraData::findMatchingBuffers(BayerFrame &bayerFrame, FrameBuffer *&em\n \t\t\t * pending embedded data buffers.\n \t\t\t */\n \t\t\tif (bayerRequeueCount == unicam_[Unicam::Image].getBuffers().size()) {\n-\t\t\t\t/* The embedded queue must be empty at this point! */\n+\t\t\t\t/* The bayer queue must be empty at this point! */\n \t\t\t\tASSERT(bayerQueue_.empty());\n \n \t\t\t\tLOG(RPI, Warning) << \"Flushing embedded data stream!\";\n", "prefixes": [ "libcamera-devel" ] }