Patch Detail
Show a patch.
GET /api/patches/11762/?format=api
{ "id": 11762, "url": "https://patchwork.libcamera.org/api/patches/11762/?format=api", "web_url": "https://patchwork.libcamera.org/patch/11762/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210329091552.157208-2-hiroh@chromium.org>", "date": "2021-03-29T09:15:50", "name": "[libcamera-devel,v2,1/3] libcamera: PipelineHandler: Make queueRequest() void function", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "274915f5c19e2a87de405e0f699054853fff18b8", "submitter": { "id": 63, "url": "https://patchwork.libcamera.org/api/people/63/?format=api", "name": "Hirokazu Honda", "email": "hiroh@chromium.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/11762/mbox/", "series": [ { "id": 1860, "url": "https://patchwork.libcamera.org/api/series/1860/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1860", "date": "2021-03-29T09:15:49", "name": "Add RequestError to Request::Status", "version": 2, "mbox": "https://patchwork.libcamera.org/series/1860/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/11762/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/11762/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 58459C32EA\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 29 Mar 2021 09:16:05 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1217A6878B;\n\tMon, 29 Mar 2021 11:16:05 +0200 (CEST)", "from mail-pj1-x102b.google.com (mail-pj1-x102b.google.com\n\t[IPv6:2607:f8b0:4864:20::102b])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 46BD86877F\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 29 Mar 2021 11:16:01 +0200 (CEST)", "by mail-pj1-x102b.google.com with SMTP id s21so5711174pjq.1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 29 Mar 2021 02:16:01 -0700 (PDT)", "from hiroh2.tok.corp.google.com\n\t([2401:fa00:8f:2:1db7:ae60:9288:b906])\n\tby smtp.gmail.com with ESMTPSA id\n\tn2sm15818122pga.57.2021.03.29.02.15.58\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 29 Mar 2021 02:15:59 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"edWZ2U0F\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=ftjJzwNrmvPJW7qbqGOAURJROo1hW/N8tjWhheZFH0M=;\n\tb=edWZ2U0F6DwA+a3IAKsKXVBs7j4jglXYNDAuh5lDLI2KCDCONnAvRlBLDcCjqHz6Ds\n\tT9gbUEVNWVl36Cd1hoGTFNnnfnKBm9ao++ejx8Kqhtzc7Z4BkrD2cR3JcljVZGUtNeuw\n\t4/ADsnqxpdbMCoJeLaiV2EBoIli1AYPVmpoxA=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=ftjJzwNrmvPJW7qbqGOAURJROo1hW/N8tjWhheZFH0M=;\n\tb=mZZH5Nnpsz4HfDnX/1SBIvbfPbRrP1RaInzSAuyGxRCXEsaFAziuSPeK+i1C84G6Ro\n\tIDTQz5siHUX2/n93vWNMVlNjbq354N7vdbmy0iLV87XrpPG5RitEi+jDguAHafK1L4Yq\n\tNr5Q1fdRICQPbWlu9JhPUkB6s5YIPSf9ScNROtL5EbrBWgYa5atYiv6M/Pzi19V15jCG\n\twg3sI1LTmUIBiHCo8Fd9m/nVNKxnETdUp+SPiHW6R9b15eFtlYr575d7DYjWH6G0z9nA\n\tfxQfaZb0+uw5hUOsR42ADGE2P7FnGJKKlqNBTatNmXzx7s4WqYRp7wtRCSY1qYZ+UaJC\n\tzCmg==", "X-Gm-Message-State": "AOAM531reyUEOin1zbdxNgQQ9AAa2ALN3i19IltPIzN+l3k5Thg7rpxi\n\t0RuHgb6UxjTRZx/FhRnqpmt7wE9donMhEQ==", "X-Google-Smtp-Source": "ABdhPJyGON3ZsOpr2Dej7+kPYU4Qw1qV1QGgRm6ENJKV628onx+D97OecieooYxgYzqIPVvGaXzKZg==", "X-Received": "by 2002:a17:902:e546:b029:e5:ec5e:6bf4 with SMTP id\n\tn6-20020a170902e546b02900e5ec5e6bf4mr27475880plf.41.1617009359807; \n\tMon, 29 Mar 2021 02:15:59 -0700 (PDT)", "From": "Hirokazu Honda <hiroh@chromium.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 29 Mar 2021 18:15:50 +0900", "Message-Id": "<20210329091552.157208-2-hiroh@chromium.org>", "X-Mailer": "git-send-email 2.31.0.291.g576ba9dcdaf-goog", "In-Reply-To": "<20210329091552.157208-1-hiroh@chromium.org>", "References": "<20210329091552.157208-1-hiroh@chromium.org>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v2 1/3] libcamera: PipelineHandler: Make\n\tqueueRequest() void function", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "PipelineHandler::queueRequest() is asynchronously invoked in\nCamera::queueRequest(). Therefore the return value of\nPipelineHandler::queueRequest() is useless. This changes the\nfunction to a void function.\n\nSigned-off-by: Hirokazu Honda <hiroh@chromium.org>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n include/libcamera/internal/pipeline_handler.h | 2 +-\n src/libcamera/camera.cpp | 6 ++++--\n src/libcamera/pipeline_handler.cpp | 6 +-----\n 3 files changed, 6 insertions(+), 8 deletions(-)", "diff": "diff --git a/include/libcamera/internal/pipeline_handler.h b/include/libcamera/internal/pipeline_handler.h\nindex 6aca0b46..093b94c6 100644\n--- a/include/libcamera/internal/pipeline_handler.h\n+++ b/include/libcamera/internal/pipeline_handler.h\n@@ -79,7 +79,7 @@ public:\n \tvirtual int start(Camera *camera, const ControlList *controls) = 0;\n \tvirtual void stop(Camera *camera) = 0;\n \n-\tint queueRequest(Request *request);\n+\tvoid queueRequest(Request *request);\n \n \tbool completeBuffer(Request *request, FrameBuffer *buffer);\n \tvoid completeRequest(Request *request);\ndiff --git a/src/libcamera/camera.cpp b/src/libcamera/camera.cpp\nindex 84edbb8f..2611c701 100644\n--- a/src/libcamera/camera.cpp\n+++ b/src/libcamera/camera.cpp\n@@ -996,8 +996,10 @@ int Camera::queueRequest(Request *request)\n \t\t}\n \t}\n \n-\treturn d->pipe_->invokeMethod(&PipelineHandler::queueRequest,\n-\t\t\t\t ConnectionTypeQueued, request);\n+\td->pipe_->invokeMethod(&PipelineHandler::queueRequest,\n+\t\t\t ConnectionTypeQueued, request);\n+\n+\treturn 0;\n }\n \n /**\ndiff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp\nindex d22991d3..eba00ed3 100644\n--- a/src/libcamera/pipeline_handler.cpp\n+++ b/src/libcamera/pipeline_handler.cpp\n@@ -371,10 +371,8 @@ const ControlList &PipelineHandler::properties(const Camera *camera) const\n * signalled by the pipeline handler using the completeRequest() method.\n *\n * \\context This function is called from the CameraManager thread.\n- *\n- * \\return 0 on success or a negative error code otherwise\n */\n-int PipelineHandler::queueRequest(Request *request)\n+void PipelineHandler::queueRequest(Request *request)\n {\n \tLIBCAMERA_TRACEPOINT(request_queue, request);\n \n@@ -385,8 +383,6 @@ int PipelineHandler::queueRequest(Request *request)\n \tint ret = queueRequestDevice(camera, request);\n \tif (ret)\n \t\tdata->queuedRequests_.remove(request);\n-\n-\treturn ret;\n }\n \n /**\n", "prefixes": [ "libcamera-devel", "v2", "1/3" ] }