Patch Detail
Show a patch.
GET /api/patches/11749/?format=api
{ "id": 11749, "url": "https://patchwork.libcamera.org/api/patches/11749/?format=api", "web_url": "https://patchwork.libcamera.org/patch/11749/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210328224528.55468-4-hiroh@chromium.org>", "date": "2021-03-28T22:45:28", "name": "[libcamera-devel,v2,3/3] android: CameraDevice: Deny non ROTATION_0 stream configuration", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "d771cf6a65fc86900ef3cc9af24df1cefc194640", "submitter": { "id": 63, "url": "https://patchwork.libcamera.org/api/people/63/?format=api", "name": "Hirokazu Honda", "email": "hiroh@chromium.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/11749/mbox/", "series": [ { "id": 1855, "url": "https://patchwork.libcamera.org/api/series/1855/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1855", "date": "2021-03-28T22:45:25", "name": "Regard crop_rotate_scale_degrees in configuration", "version": 2, "mbox": "https://patchwork.libcamera.org/series/1855/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/11749/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/11749/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 44588C32EA\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSun, 28 Mar 2021 22:45:44 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 073E268788;\n\tMon, 29 Mar 2021 00:45:44 +0200 (CEST)", "from mail-pj1-x1033.google.com (mail-pj1-x1033.google.com\n\t[IPv6:2607:f8b0:4864:20::1033])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 668BB6877C\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 29 Mar 2021 00:45:40 +0200 (CEST)", "by mail-pj1-x1033.google.com with SMTP id\n\til9-20020a17090b1649b0290114bcb0d6c2so6823520pjb.0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 28 Mar 2021 15:45:40 -0700 (PDT)", "from hiroh2.tok.corp.google.com\n\t([2401:fa00:8f:2:1db7:ae60:9288:b906])\n\tby smtp.gmail.com with ESMTPSA id\n\tq25sm14814244pff.104.2021.03.28.15.45.37\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tSun, 28 Mar 2021 15:45:38 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"S0wUsJah\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=3XFw66zLJldvVab3br52TbLvk9ogclQY85vQlEPbt3k=;\n\tb=S0wUsJahy2O3TKZENIF0sc2jNLgm394tokG2JLG6aUf73yWoZncONvRO/BqagEfwoS\n\tf6Pfq2YuveMWASbgpk/EDdvKEeUBvvXQVZ2VUAgZ//Ca0mpVrvj2mX7mE5YtCTEcwsR7\n\t2w7+PDiSGC0mgXaM7duTwhe9J7Rfisc00Ij2Q=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=3XFw66zLJldvVab3br52TbLvk9ogclQY85vQlEPbt3k=;\n\tb=dNmC8yMtePm4cNTBEmxxTD+ggX4UdNbgHJebNcsJLAMJl4PhVUeFYnTYSPIs4hy7GZ\n\t1JGtxwtRImmqHMxSNgq6B+W2rf/8GLIN23ze5X6ADwj4tZs5x8UR1PdgXDooZLGeEWKs\n\tqmnAA3D/UUm9x5P0SjkOpdNRpkn9Ufu+SLTgK28Bk3/LH2ZeiYH6+3PxhJvvjX8MnCni\n\tz10PHj75ILIkutpOp0mOIEwqs1js7XoYTLYZQAEHRDnORZso5pXI4mR4hya0uPClLr4A\n\t5Yjtqle9T7sGrqUiFt3mksG51/1Kbmht8ukNyzBjXf/GkII0elMP8dTrYZSzPps8sF5T\n\tFO/w==", "X-Gm-Message-State": "AOAM530w1SjGxdEG61HUlXmJE1oj61ahUm7zHeH2FT4TdWwgXBZKACTd\n\tx/me/gKkxdfNg7QLzqqd9qW2PcTnSdfpoA==", "X-Google-Smtp-Source": "ABdhPJyL8fzkXFv/ZuZ4KrNYpQlRCeoCKiFNn6SZmSDUiHWyzenP1RmNgQuj9T9b7TyExwPVZ1stIg==", "X-Received": "by 2002:a17:903:188:b029:e6:52f4:1b2d with SMTP id\n\tz8-20020a1709030188b02900e652f41b2dmr26407183plg.58.1616971538798; \n\tSun, 28 Mar 2021 15:45:38 -0700 (PDT)", "From": "Hirokazu Honda <hiroh@chromium.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 29 Mar 2021 07:45:28 +0900", "Message-Id": "<20210328224528.55468-4-hiroh@chromium.org>", "X-Mailer": "git-send-email 2.31.0.291.g576ba9dcdaf-goog", "In-Reply-To": "<20210328224528.55468-1-hiroh@chromium.org>", "References": "<20210328224528.55468-1-hiroh@chromium.org>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v2 3/3] android: CameraDevice: Deny non\n\tROTATION_0 stream configuration", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Libcamera doesn't handle crop_rotate_scale_degrees. Therefore,\nif it is requested, that is, crop_rotate_scale_degrees is not\nCAMERA3_STREAM_ROTATION_0, the configuration should fail.\n\nSigned-off-by: Hirokazu Honda <hiroh@chromium.org>\n---\n src/android/camera_device.cpp | 7 +++++++\n 1 file changed, 7 insertions(+)\n\n--\n2.31.0.291.g576ba9dcdaf-goog", "diff": "diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\nindex d3368b19..11c0f35a 100644\n--- a/src/android/camera_device.cpp\n+++ b/src/android/camera_device.cpp\n@@ -1647,6 +1647,13 @@ int CameraDevice::configureStreams(camera3_stream_configuration_t *stream_list)\n \t\tif (!format.isValid())\n \t\t\treturn -EINVAL;\n\n+\t\t/* \\todo Support rotation. */\n+\t\tif (stream->rotation != CAMERA3_STREAM_ROTATION_0 ||\n+\t\t stream->crop_rotate_scale_degrees != CAMERA3_STREAM_ROTATION_0) {\n+\t\t\tLOG(HAL, Error) << \"Rotation is not supported\";\n+\t\t\treturn -EINVAL;\n+\t\t}\n+\n \t\t/* Defer handling of MJPEG streams until all others are known. */\n \t\tif (stream->format == HAL_PIXEL_FORMAT_BLOB) {\n \t\t\tif (jpegStream) {\n", "prefixes": [ "libcamera-devel", "v2", "3/3" ] }