Patch Detail
Show a patch.
GET /api/patches/11742/?format=api
{ "id": 11742, "url": "https://patchwork.libcamera.org/api/patches/11742/?format=api", "web_url": "https://patchwork.libcamera.org/patch/11742/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210328170302.36104-1-sebastian.fricke@posteo.net>", "date": "2021-03-28T17:03:03", "name": "[libcamera-devel] ipa: raspberrypi: Fix typo and improve wording", "commit_ref": "6b98965877a87deffc87388c66f62bb28539aaed", "pull_url": null, "state": "accepted", "archived": false, "hash": "a9110bf0cec5e5d66596022172b5f25647b2779e", "submitter": { "id": 78, "url": "https://patchwork.libcamera.org/api/people/78/?format=api", "name": "Sebastian Fricke", "email": "sebastian.fricke@posteo.net" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/11742/mbox/", "series": [ { "id": 1851, "url": "https://patchwork.libcamera.org/api/series/1851/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1851", "date": "2021-03-28T17:03:03", "name": "[libcamera-devel] ipa: raspberrypi: Fix typo and improve wording", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1851/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/11742/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/11742/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 95265C32ED\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSun, 28 Mar 2021 17:03:34 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0B0166877F;\n\tSun, 28 Mar 2021 19:03:34 +0200 (CEST)", "from mout02.posteo.de (mout02.posteo.de [185.67.36.66])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 119736084F\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 28 Mar 2021 19:03:33 +0200 (CEST)", "from submission (posteo.de [89.146.220.130]) \n\tby mout02.posteo.de (Postfix) with ESMTPS id 6F25D2400FB\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 28 Mar 2021 19:03:32 +0200 (CEST)", "from customer (localhost [127.0.0.1])\n\tby submission (posteo.de) with ESMTPSA id 4F7hqm0yJlz6tm6;\n\tSun, 28 Mar 2021 19:03:32 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=posteo.net header.i=@posteo.net\n\theader.b=\"VEKlLPjo\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017;\n\tt=1616951012; bh=ZWbAYLLCEhklBMiQBFr3nm7kcRAGTAd8tBrPmdwZe8c=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=VEKlLPjouoCKwCCZRyxiSx/T728KRpCwFRhcRMpNQNENTXi/oSVAsSZetlxV0B9KC\n\tEFabJzIK0QvgCGmIsxNVTfaDBHJx6Tnlw+2NVjDjOaNFYembrkrHK4Q26xxWKD/YTd\n\tVzYFOJxZEKVtX6ThnaVT3+c+CqA/Kpu3HYZSc5Awlsnbc5/ogW2EXSVyZTWc+B5FwE\n\tDgdfMfbrCZXgxnByRqgfhxKaWJt0oHd3l5IOLsIyZdjJ9dHRp7y/kRLZdl0Ka4RCh8\n\tHlnS+AG5AsVVoKRXCrnzM6BfhmGpxhConj6clLW+0Jv9ddXGygdTiDPx5KWH0JQ7Ru\n\turMpThLA4KuNw==", "From": "Sebastian Fricke <sebastian.fricke@posteo.net>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Sun, 28 Mar 2021 19:03:03 +0200", "Message-Id": "<20210328170302.36104-1-sebastian.fricke@posteo.net>", "X-Mailer": "git-send-email 2.25.1", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH] ipa: raspberrypi: Fix typo and improve\n\twording", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "s/Return the validated limits out though metadata./\n Return the validated limits via metadata./\n\nSigned-off-by: Sebastian Fricke <sebastian.fricke@posteo.net>\n---\nIt is probably debatable, if we should remove that comment completely,\nas the code is quite self explanatory. But it might help.\n---\n src/ipa/raspberrypi/raspberrypi.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp\nindex ed2d9a54..dad6395f 100644\n--- a/src/ipa/raspberrypi/raspberrypi.cpp\n+++ b/src/ipa/raspberrypi/raspberrypi.cpp\n@@ -1066,7 +1066,7 @@ void IPARPi::applyFrameDurations(double minFrameDuration, double maxFrameDuratio\n \t\t\t\t minSensorFrameDuration, maxSensorFrameDuration);\n \tmaxFrameDuration_ = std::max(maxFrameDuration_, minFrameDuration_);\n \n-\t/* Return the validated limits out though metadata. */\n+\t/* Return the validated limits via metadata. */\n \tlibcameraMetadata_.set(controls::FrameDurations,\n \t\t\t { static_cast<int64_t>(minFrameDuration_),\n \t\t\t\t static_cast<int64_t>(maxFrameDuration_) });\n", "prefixes": [ "libcamera-devel" ] }