Patch Detail
Show a patch.
GET /api/patches/11741/?format=api
{ "id": 11741, "url": "https://patchwork.libcamera.org/api/patches/11741/?format=api", "web_url": "https://patchwork.libcamera.org/patch/11741/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210328142711.29702-1-sebastian.fricke@posteo.net>", "date": "2021-03-28T14:27:12", "name": "[libcamera-devel] pipeline: raspberrypi: Remove unused getFormat call", "commit_ref": "e99fc4b0d52957cf4ec493a55f2855d2d6ae201b", "pull_url": null, "state": "accepted", "archived": false, "hash": "d3a5da44821999df823ac82d9e8fe2590e4bca0d", "submitter": { "id": 78, "url": "https://patchwork.libcamera.org/api/people/78/?format=api", "name": "Sebastian Fricke", "email": "sebastian.fricke@posteo.net" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/11741/mbox/", "series": [ { "id": 1850, "url": "https://patchwork.libcamera.org/api/series/1850/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1850", "date": "2021-03-28T14:27:12", "name": "[libcamera-devel] pipeline: raspberrypi: Remove unused getFormat call", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1850/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/11741/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/11741/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C5654C32EA\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSun, 28 Mar 2021 14:27:29 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BF09D6877F;\n\tSun, 28 Mar 2021 16:27:28 +0200 (CEST)", "from mout01.posteo.de (mout01.posteo.de [185.67.36.65])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 263B06084F\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 28 Mar 2021 16:27:27 +0200 (CEST)", "from submission (posteo.de [89.146.220.130]) \n\tby mout01.posteo.de (Postfix) with ESMTPS id 5173A160061\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 28 Mar 2021 16:27:26 +0200 (CEST)", "from customer (localhost [127.0.0.1])\n\tby submission (posteo.de) with ESMTPSA id 4F7dMd5pmdz6tmN;\n\tSun, 28 Mar 2021 16:27:25 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=posteo.net header.i=@posteo.net\n\theader.b=\"cI0hdAsN\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017;\n\tt=1616941646; bh=8N6uYAo+2oRE3m/npdlaxMe+fMSetpglXti67CHZs2s=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=cI0hdAsN9n7B69jzPa/oczHpROoxeSsu1lxNhoG3+PJcE26fwn06R5/lFhLS83AQV\n\t9GmFf48Icy4cdcBBOlzmLUmNpyIG/mR3FeQrBqmgtZBmONn8kYQDLKrGSJcOfb0Mer\n\tKTDtoBNagxUo4DOmehpTvo0rYlTKstJXext1UhBGhsC59AevEqBvYbxuh6jKBiHZqj\n\tj6CTQv0Pg9Z2gUP6cMux3c4RXtek/L27MA3B78BJXbCTxThwXxAVPq4IvONOcAxGxr\n\tvIMA1eJMCMR+kHSFbRvQXTEIZ8nOiohW44m4pcpPJJlzTCXvwVcjYNB77uhqvt+AQM\n\t+k+VdQ8+5rtrw==", "From": "Sebastian Fricke <sebastian.fricke@posteo.net>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Sun, 28 Mar 2021 16:27:12 +0200", "Message-Id": "<20210328142711.29702-1-sebastian.fricke@posteo.net>", "X-Mailer": "git-send-email 2.25.1", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH] pipeline: raspberrypi: Remove unused\n\tgetFormat call", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The comment states, that we get the device format to pass it to the IPA,\nbut the variable `sensorFormat` is not used again after it's assignment.\nRemove it, together with the comment.\n\nSigned-off-by: Sebastian Fricke <sebastian.fricke@posteo.net>\n---\nTested on Raspberry Pi 4 with IMX219 without issues.\n---\n src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 3 ---\n 1 file changed, 3 deletions(-)", "diff": "diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\nindex 378a5227..f22e286e 100644\n--- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n+++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n@@ -1238,9 +1238,6 @@ int RPiCameraData::configureIPA(const CameraConfiguration *config)\n \tstd::map<unsigned int, ControlInfoMap> entityControls;\n \tipa::RPi::IPAConfig ipaConfig;\n \n-\t/* Get the device format to pass to the IPA. */\n-\tV4L2DeviceFormat sensorFormat;\n-\tunicam_[Unicam::Image].dev()->getFormat(&sensorFormat);\n \t/* Inform IPA of stream configuration and sensor controls. */\n \tunsigned int i = 0;\n \tfor (auto const &stream : isp_) {\n", "prefixes": [ "libcamera-devel" ] }