Patch Detail
Show a patch.
GET /api/patches/11728/?format=api
{ "id": 11728, "url": "https://patchwork.libcamera.org/api/patches/11728/?format=api", "web_url": "https://patchwork.libcamera.org/patch/11728/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210325174254.7977-1-sebastian.fricke@posteo.net>", "date": "2021-03-25T17:42:54", "name": "[libcamera-devel] ipa: rkisp1: Do not set controls during configure", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "e6ce3fe209ad2491bf90b8e16b62cc31f9a02461", "submitter": { "id": 78, "url": "https://patchwork.libcamera.org/api/people/78/?format=api", "name": "Sebastian Fricke", "email": "sebastian.fricke@posteo.net" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/11728/mbox/", "series": [ { "id": 1838, "url": "https://patchwork.libcamera.org/api/series/1838/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1838", "date": "2021-03-25T17:42:54", "name": "[libcamera-devel] ipa: rkisp1: Do not set controls during configure", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1838/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/11728/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/11728/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4E598BDC66\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 25 Mar 2021 17:43:04 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 92D0268D65;\n\tThu, 25 Mar 2021 18:43:03 +0100 (CET)", "from mout01.posteo.de (mout01.posteo.de [185.67.36.65])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id ED7D9603FE\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 25 Mar 2021 18:43:01 +0100 (CET)", "from submission (posteo.de [89.146.220.130]) \n\tby mout01.posteo.de (Postfix) with ESMTPS id 5265A16005F\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 25 Mar 2021 18:43:01 +0100 (CET)", "from customer (localhost [127.0.0.1])\n\tby submission (posteo.de) with ESMTPSA id 4F5srh4Rngz6tmR;\n\tThu, 25 Mar 2021 18:43:00 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=posteo.net header.i=@posteo.net\n\theader.b=\"ElHOIclV\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017;\n\tt=1616694181; bh=gPKnu3pz4XZiIdIESbNrs0TCIN+L4vuyG0zo2gWAmZE=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=ElHOIclVz/okx3b0oqXR6LH3QQFLe84tnVJNwNOWwB+CbUy6R5WOlgMVfFB3HGUwn\n\tloCiXhuR7ETW8E1GuOHkR9QT2YwUp/zLMIbe+otCAc8g7MKeHk4dOHaABfLvf8sBOF\n\td+HUQE9TtJK86+Yv5uM8C2FGkxcPSKGOwIuAfRJt/4SHj0tYoVQBQ6CzAVrJQac52V\n\tTUwk3sPJ0/WzN6hjREtHA2bNPLLzMwubCFmhXjKs5Dkxrr9FQqtOJ/c2UfsnzJA9pf\n\tuD6YaqaL240xc7EUaHSFOCds8lNr6DnerL1JK8IWcj0S6uHZsv9fCiOo3aDvDesjP2\n\tPMsLXg7aOiCkw==", "From": "Sebastian Fricke <sebastian.fricke@posteo.net>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 25 Mar 2021 18:42:54 +0100", "Message-Id": "<20210325174254.7977-1-sebastian.fricke@posteo.net>", "X-Mailer": "git-send-email 2.25.1", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH] ipa: rkisp1: Do not set controls during\n\tconfigure", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The configure operation is synchronous and should not send events back\nto the pipeline handler.\n\nIf information needs to be returned from configure it should be handled\nthrough the interface directly.\n\nMove the initial call to setControls() out of configure() and into the\nstart() method which is called after the IPA running_ state is updated.\n\nSigned-off-by: Sebastian Fricke <sebastian.fricke@posteo.net>\n---\n src/ipa/rkisp1/rkisp1.cpp | 10 ++++++++--\n 1 file changed, 8 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\nindex d2a10bb9..b0698903 100644\n--- a/src/ipa/rkisp1/rkisp1.cpp\n+++ b/src/ipa/rkisp1/rkisp1.cpp\n@@ -32,7 +32,7 @@ class IPARkISP1 : public ipa::rkisp1::IPARkISP1Interface\n {\n public:\n \tint init(unsigned int hwRevision) override;\n-\tint start() override { return 0; }\n+\tint start() override;\n \tvoid stop() override {}\n \n \tint configure(const CameraSensorInfo &info,\n@@ -80,6 +80,13 @@ int IPARkISP1::init(unsigned int hwRevision)\n \treturn 0;\n }\n \n+int IPARkISP1::start()\n+{\n+ setControls(0);\n+\n+ return 0;\n+}\n+\n /**\n * \\todo The RkISP1 pipeline currently provides an empty CameraSensorInfo\n * if the connected sensor does not provide enough information to properly\n@@ -121,7 +128,6 @@ int IPARkISP1::configure([[maybe_unused]] const CameraSensorInfo &info,\n \t\t<< \"Exposure: \" << minExposure_ << \"-\" << maxExposure_\n \t\t<< \" Gain: \" << minGain_ << \"-\" << maxGain_;\n \n-\tsetControls(0);\n \treturn 0;\n }\n \n", "prefixes": [ "libcamera-devel" ] }