Patch Detail
Show a patch.
GET /api/patches/11714/?format=api
{ "id": 11714, "url": "https://patchwork.libcamera.org/api/patches/11714/?format=api", "web_url": "https://patchwork.libcamera.org/patch/11714/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210325134231.1400051-7-kieran.bingham@ideasonboard.com>", "date": "2021-03-25T13:42:24", "name": "[libcamera-devel,v3,04/11] libcamera: request: Add a toString()", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "e085b8c1b2191e7f03b4827c1c7968d9df4f2021", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": { "id": 11, "url": "https://patchwork.libcamera.org/api/users/11/?format=api", "username": "kbingham", "first_name": "Kieran", "last_name": "Bingham", "email": "kieran.bingham@ideasonboard.com" }, "mbox": "https://patchwork.libcamera.org/patch/11714/mbox/", "series": [ { "id": 1832, "url": "https://patchwork.libcamera.org/api/series/1832/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1832", "date": "2021-03-25T13:42:18", "name": "[libcamera-devel,v3,01/11] utils: ipc: proxy: Track IPA with a state machine", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1832/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/11714/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/11714/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0856AC32E9\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 25 Mar 2021 13:42:45 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 82D1668D80;\n\tThu, 25 Mar 2021 14:42:44 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8E03A602D5\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 25 Mar 2021 14:42:37 +0100 (CET)", "from Q.local (cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net\n\t[86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 362268C9;\n\tThu, 25 Mar 2021 14:42:37 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"pjze5PUN\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1616679757;\n\tbh=U/GFlKH0quUlUYD8QEmuZuLLxlaij3Pq//oVy3qUhFU=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=pjze5PUNUJkttqIjQnorxSvnPntRbslCRCNP28JyrmDZagt7ULxPBL1oXU3zUdOr3\n\tUi71Xbz828eCVAmMqauBI3Ib8+IAeBUwTs8TnFjNnvY3Mj6tTX+6uE1dN0xbKpKVpy\n\tmrmF8yUFpqiysUtWvWj9KTnLffcuIFzOtZqQqk8A=", "From": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "To": "libcamera devel <libcamera-devel@lists.libcamera.org>", "Date": "Thu, 25 Mar 2021 13:42:24 +0000", "Message-Id": "<20210325134231.1400051-7-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20210325134231.1400051-1-kieran.bingham@ideasonboard.com>", "References": "<20210325134231.1400051-1-kieran.bingham@ideasonboard.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v3 04/11] libcamera: request: Add a\n\ttoString()", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Provide a toString helper to assist in printing Request state\nfor debug and logging contexts.\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n include/libcamera/request.h | 3 +++\n src/libcamera/request.cpp | 30 +++++++++++++++++++++++++++---\n 2 files changed, 30 insertions(+), 3 deletions(-)", "diff": "diff --git a/include/libcamera/request.h b/include/libcamera/request.h\nindex cd5a24741f8a..4cf5ff3f7d3b 100644\n--- a/include/libcamera/request.h\n+++ b/include/libcamera/request.h\n@@ -10,6 +10,7 @@\n #include <map>\n #include <memory>\n #include <stdint.h>\n+#include <string>\n #include <unordered_set>\n \n #include <libcamera/class.h>\n@@ -56,6 +57,8 @@ public:\n \n \tbool hasPendingBuffers() const { return !pending_.empty(); }\n \n+\tstd::string toString() const;\n+\n private:\n \tLIBCAMERA_DISABLE_COPY(Request)\n \ndiff --git a/src/libcamera/request.cpp b/src/libcamera/request.cpp\nindex fc16b148a599..7b7ef6814686 100644\n--- a/src/libcamera/request.cpp\n+++ b/src/libcamera/request.cpp\n@@ -8,6 +8,7 @@\n #include <libcamera/request.h>\n \n #include <map>\n+#include <sstream>\n \n #include <libcamera/buffer.h>\n #include <libcamera/camera.h>\n@@ -261,6 +262,16 @@ FrameBuffer *Request::findBuffer(const Stream *stream) const\n * otherwise\n */\n \n+/**\n+ * \\fn Request::toString()\n+ * \\brief Generate a string representation of the Request internals\n+ *\n+ * This function facilitates debugging of Request state while it is used\n+ * internally within libcamera.\n+ *\n+ * \\return A string representing the current state of the request\n+ */\n+\n /**\n * \\brief Complete a queued request\n *\n@@ -275,9 +286,7 @@ void Request::complete()\n \n \tstatus_ = cancelled_ ? RequestCancelled : RequestComplete;\n \n-\tLOG(Request, Debug)\n-\t\t<< \"Request has completed - cookie: \" << cookie_\n-\t\t<< (cancelled_ ? \" [Cancelled]\" : \"\");\n+\tLOG(Request, Debug) << toString();\n \n \tLIBCAMERA_TRACEPOINT(request_complete, this);\n }\n@@ -310,4 +319,19 @@ bool Request::completeBuffer(FrameBuffer *buffer)\n \treturn !hasPendingBuffers();\n }\n \n+std::string Request::toString() const\n+{\n+\tstd::stringstream ss;\n+\n+\t/* Pending, Completed, Cancelled(X). */\n+\tstatic const char *statuses = \"PCX\";\n+\n+\t/* Example Output: Request(55:P:1/2:6523524) */\n+\tss << \"Request (\" << sequence_ << \":\" << statuses[status_] << \":\"\n+\t << pending_.size() << \"/\" << bufferMap_.size() << \":\"\n+\t << cookie_ << \")\";\n+\n+\treturn ss.str();\n+}\n+\n } /* namespace libcamera */\n", "prefixes": [ "libcamera-devel", "v3", "04/11" ] }