Patch Detail
Show a patch.
GET /api/patches/11713/?format=api
{ "id": 11713, "url": "https://patchwork.libcamera.org/api/patches/11713/?format=api", "web_url": "https://patchwork.libcamera.org/patch/11713/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210325134231.1400051-6-kieran.bingham@ideasonboard.com>", "date": "2021-03-25T13:42:23", "name": "[libcamera-devel,v3,03/11] libcamera: request: Provide a sequence number", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "e10ae8f74498d2a414c1ec7348caa256a919a126", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": { "id": 11, "url": "https://patchwork.libcamera.org/api/users/11/?format=api", "username": "kbingham", "first_name": "Kieran", "last_name": "Bingham", "email": "kieran.bingham@ideasonboard.com" }, "mbox": "https://patchwork.libcamera.org/patch/11713/mbox/", "series": [ { "id": 1832, "url": "https://patchwork.libcamera.org/api/series/1832/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1832", "date": "2021-03-25T13:42:18", "name": "[libcamera-devel,v3,01/11] utils: ipc: proxy: Track IPA with a state machine", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1832/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/11713/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/11713/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 912ECC32EA\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 25 Mar 2021 13:42:44 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BBE7168D7B;\n\tThu, 25 Mar 2021 14:42:43 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4FE2C68D6D\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 25 Mar 2021 14:42:37 +0100 (CET)", "from Q.local (cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net\n\t[86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D959B560;\n\tThu, 25 Mar 2021 14:42:36 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"kMf0D8aK\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1616679757;\n\tbh=RSzG7AEw4TJuvB9rhe+Mrc8vkXoQZBWw+Jy4hCX5WaI=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=kMf0D8aKNl89+uqXGmkuSlDf/D0t1uPe9JiInmat0p3BlehkDLpjnS5byShgygsDI\n\tA6Wq2Z1GsUqT2G8lT8c1k2fp8E2KqDwDqzuc/J/vnnEJkFwYX1gU3fsalvok/7fjIm\n\tam6INmiacIjvIlHsKvjJr/i5Bt3uuQMnHQsQzWLo=", "From": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "To": "libcamera devel <libcamera-devel@lists.libcamera.org>", "Date": "Thu, 25 Mar 2021 13:42:23 +0000", "Message-Id": "<20210325134231.1400051-6-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20210325134231.1400051-1-kieran.bingham@ideasonboard.com>", "References": "<20210325134231.1400051-1-kieran.bingham@ideasonboard.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v3 03/11] libcamera: request: Provide a\n\tsequence number", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Provide a sequence number on Requests which are added by the pipeline\nhandler.\n\nEach pipeline handler keeps a requestSequence per CameraData and\nincrements everytime a request is queued on that camera.\n\nThe sequence number is associated with the Request and can be utilised\nfor assisting with debugging, and printing the queueing sequence of in\nflight requests.\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n include/libcamera/internal/pipeline_handler.h | 4 +++-\n include/libcamera/request.h | 2 ++\n src/libcamera/pipeline_handler.cpp | 2 ++\n src/libcamera/request.cpp | 11 +++++++++--\n 4 files changed, 16 insertions(+), 3 deletions(-)", "diff": "diff --git a/include/libcamera/internal/pipeline_handler.h b/include/libcamera/internal/pipeline_handler.h\nindex 6aca0b46f43d..9bdda8f3b799 100644\n--- a/include/libcamera/internal/pipeline_handler.h\n+++ b/include/libcamera/internal/pipeline_handler.h\n@@ -38,7 +38,7 @@ class CameraData\n {\n public:\n \texplicit CameraData(PipelineHandler *pipe)\n-\t\t: pipe_(pipe)\n+\t\t: pipe_(pipe), requestSequence_(0)\n \t{\n \t}\n \tvirtual ~CameraData() = default;\n@@ -48,6 +48,8 @@ public:\n \tControlInfoMap controlInfo_;\n \tControlList properties_;\n \n+\tuint32_t requestSequence_;\n+\n private:\n \tLIBCAMERA_DISABLE_COPY(CameraData)\n };\ndiff --git a/include/libcamera/request.h b/include/libcamera/request.h\nindex 6e5aad5f6b75..cd5a24741f8a 100644\n--- a/include/libcamera/request.h\n+++ b/include/libcamera/request.h\n@@ -50,6 +50,7 @@ public:\n \tint addBuffer(const Stream *stream, FrameBuffer *buffer);\n \tFrameBuffer *findBuffer(const Stream *stream) const;\n \n+\tuint32_t sequence() const { return sequence_; }\n \tuint64_t cookie() const { return cookie_; }\n \tStatus status() const { return status_; }\n \n@@ -71,6 +72,7 @@ private:\n \tBufferMap bufferMap_;\n \tstd::unordered_set<FrameBuffer *> pending_;\n \n+\tuint32_t sequence_;\n \tconst uint64_t cookie_;\n \tStatus status_;\n \tbool cancelled_;\ndiff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp\nindex d22991d318c9..e3d4975d9ffd 100644\n--- a/src/libcamera/pipeline_handler.cpp\n+++ b/src/libcamera/pipeline_handler.cpp\n@@ -382,6 +382,8 @@ int PipelineHandler::queueRequest(Request *request)\n \tCameraData *data = cameraData(camera);\n \tdata->queuedRequests_.push_back(request);\n \n+\trequest->sequence_ = data->requestSequence_++;\n+\n \tint ret = queueRequestDevice(camera, request);\n \tif (ret)\n \t\tdata->queuedRequests_.remove(request);\ndiff --git a/src/libcamera/request.cpp b/src/libcamera/request.cpp\nindex 3ad83f3b8418..fc16b148a599 100644\n--- a/src/libcamera/request.cpp\n+++ b/src/libcamera/request.cpp\n@@ -72,8 +72,8 @@ LOG_DEFINE_CATEGORY(Request)\n *\n */\n Request::Request(Camera *camera, uint64_t cookie)\n-\t: camera_(camera), cookie_(cookie), status_(RequestPending),\n-\t cancelled_(false)\n+\t: camera_(camera), sequence_(0), cookie_(cookie),\n+\t status_(RequestPending), cancelled_(false)\n {\n \t/**\n \t * \\todo Should the Camera expose a validator instance, to avoid\n@@ -126,6 +126,7 @@ void Request::reuse(ReuseFlag flags)\n \t\tbufferMap_.clear();\n \t}\n \n+\tsequence_ = 0;\n \tstatus_ = RequestPending;\n \tcancelled_ = false;\n \n@@ -227,6 +228,12 @@ FrameBuffer *Request::findBuffer(const Stream *stream) const\n * \\return The metadata associated with the request\n */\n \n+/**\n+ * \\fn Request::sequence()\n+ * \\brief Retrieve the sequence number for the request\n+ * \\return The request sequence number\n+ */\n+\n /**\n * \\fn Request::cookie()\n * \\brief Retrieve the cookie set when the request was created\n", "prefixes": [ "libcamera-devel", "v3", "03/11" ] }