Patch Detail
Show a patch.
GET /api/patches/11699/?format=api
{ "id": 11699, "url": "https://patchwork.libcamera.org/api/patches/11699/?format=api", "web_url": "https://patchwork.libcamera.org/patch/11699/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210324150125.1318325-6-kieran.bingham@ideasonboard.com>", "date": "2021-03-24T15:01:24", "name": "[libcamera-devel,v3,5/6] libcamera: pipeline: ipu3: Do not mark metadata complete early", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "7234f5cf8f4475fefe391373d52f87598901a3f4", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": { "id": 11, "url": "https://patchwork.libcamera.org/api/users/11/?format=api", "username": "kbingham", "first_name": "Kieran", "last_name": "Bingham", "email": "kieran.bingham@ideasonboard.com" }, "mbox": "https://patchwork.libcamera.org/patch/11699/mbox/", "series": [ { "id": 1828, "url": "https://patchwork.libcamera.org/api/series/1828/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1828", "date": "2021-03-24T15:01:19", "name": "IPU3 Stability", "version": 3, "mbox": "https://patchwork.libcamera.org/series/1828/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/11699/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/11699/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5627DC32E5\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 24 Mar 2021 15:01:38 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D651368D6C;\n\tWed, 24 Mar 2021 16:01:37 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D884F602E3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 24 Mar 2021 16:01:32 +0100 (CET)", "from Q.local (cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net\n\t[86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 76655580;\n\tWed, 24 Mar 2021 16:01:32 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"BOFwVej5\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1616598092;\n\tbh=15bCuzLW/sYhWEqQ8t+ApQSQwoCz/TNRhi3iGNhUb4E=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=BOFwVej5wfSMcJZqPeTJQlUnY/+nRqifBOdJhCUQbLTDD0K18R9j1VzR9GXyvaizq\n\tU7R4FdI75e/unf0mquIvKLco8M4DG4GEsI6zvsH9/2mrLnw4QRmhIs2Dw7jJbsItOX\n\tXDMFmWatDH+kF3vXlDIWorksthZCGh/Yht5Vf2Ug=", "From": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "To": "libcamera devel <libcamera-devel@lists.libcamera.org>", "Date": "Wed, 24 Mar 2021 15:01:24 +0000", "Message-Id": "<20210324150125.1318325-6-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20210324150125.1318325-1-kieran.bingham@ideasonboard.com>", "References": "<20210324150125.1318325-1-kieran.bingham@ideasonboard.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v3 5/6] libcamera: pipeline: ipu3: Do not\n\tmark metadata complete early", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "When the imguOutputBufferReady() detects a cancelled frame, it is\nreporting that the metadata has been processed in order to be able to\ncomplete the cancelled request.\n\nThis causes the FrameInfo to be completed and deleted early, but then an\nactive buffer on the IMGU can complete and be unable to find the\nFrameInfo for it to complete correctly.\n\nDo not mark metadataProcessed early on the event that a single buffer is\ndetected as cancelled. The stopping of the V4L2 devices will ensure\nthat all queued buffers are returned to us and we can follow the normal\nand expected shutdown sequence.\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/libcamera/pipeline/ipu3/ipu3.cpp | 3 ---\n 1 file changed, 3 deletions(-)", "diff": "diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\nindex 34ee600340b1..a8edf906220b 100644\n--- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n+++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n@@ -1232,9 +1232,6 @@ void IPU3CameraData::imguOutputBufferReady(FrameBuffer *buffer)\n \t\tcropRegion_ = request->controls().get(controls::ScalerCrop);\n \trequest->metadata().set(controls::ScalerCrop, cropRegion_);\n \n-\tif (buffer->metadata().status == FrameMetadata::FrameCancelled)\n-\t\tinfo->metadataProcessed = true;\n-\n \tif (frameInfos_.tryComplete(info))\n \t\tpipe_->completeRequest(request);\n }\n", "prefixes": [ "libcamera-devel", "v3", "5/6" ] }