Patch Detail
Show a patch.
GET /api/patches/11671/?format=api
{ "id": 11671, "url": "https://patchwork.libcamera.org/api/patches/11671/?format=api", "web_url": "https://patchwork.libcamera.org/patch/11671/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210323143610.787760-6-naush@raspberrypi.com>", "date": "2021-03-23T14:36:08", "name": "[libcamera-devel,v3,5/7] ipa: raspberrypi: Remove unused member variable", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "867c9e1c4263d1574d8cb99fc610b395aceb6773", "submitter": { "id": 34, "url": "https://patchwork.libcamera.org/api/people/34/?format=api", "name": "Naushir Patuck", "email": "naush@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/11671/mbox/", "series": [ { "id": 1823, "url": "https://patchwork.libcamera.org/api/series/1823/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1823", "date": "2021-03-23T14:36:03", "name": "Raspberry Pi: ipa::init() restructuring", "version": 3, "mbox": "https://patchwork.libcamera.org/series/1823/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/11671/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/11671/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 92BCEC32E7\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 23 Mar 2021 14:36:25 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 400A368D83;\n\tTue, 23 Mar 2021 15:36:25 +0100 (CET)", "from mail-ed1-x533.google.com (mail-ed1-x533.google.com\n\t[IPv6:2a00:1450:4864:20::533])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 850DC68D63\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 23 Mar 2021 15:36:21 +0100 (CET)", "by mail-ed1-x533.google.com with SMTP id dm8so23737751edb.2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 23 Mar 2021 07:36:21 -0700 (PDT)", "from naush-laptop.patuck.local ([88.97.76.4])\n\tby smtp.gmail.com with ESMTPSA id\n\tn6sm11282430eji.37.2021.03.23.07.36.19\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 23 Mar 2021 07:36:20 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"gujPtEfX\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=IBYOmNhWc9VLgjJTDXl+uYxRIPrJR5MK3Zb55BkFyfk=;\n\tb=gujPtEfXy7EvG/l0MAVbigoYUPDz+JBzH90x7LmvGXKtKSLzBeR/OuQ1DWIPgc7YBa\n\tdAIOJK+Ml6NB/ynICLLaRh+tRU+eBrQai8O26bX10OVL4YrHnmij8vvDsl1S855gyQ/j\n\txzLlhOMWcvO3K/nr/Gqk2hCA/SEUxS7KJTR4teFaZD9m9NRYuPlqSqy1Re/b2AVKdeDf\n\tQZMKrq0C/kV4XoKaeBJwlqUVyU76HaMx24W1SgpCneI8+9WDOilVg8YKZBG0jFblwN90\n\t8IaoY6NUTuW9nocpuJS+qy7CTNX5RQrP+l2W/QCxk/GG8pgtfy8LqmKub7sKZYx0e1bF\n\tvNjA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=IBYOmNhWc9VLgjJTDXl+uYxRIPrJR5MK3Zb55BkFyfk=;\n\tb=SoX36g2Ix/oDnFxk0tQv8ykAxVm5UHzqvcQAiCyvlMq6LLbGm7HgBC4yN8sT2hzP83\n\t94viizE4fyptqIYk5a3zCoFemSq3EoWpS7c8AbQC6tVuZ9ZROYhA4jB/HtHEDL68vard\n\tNvCFzM0Zhs2uQwaUHzwgvrtAJKy06fbfxSLP+oVSMQk7LbvRVM/UcvJuizXQkJCmWGXn\n\tHcsKGgbpaDBRyOWU5VabHBn4v4L3XKbmtQT6LYEaoQmPEaiYSDgIAMiKoTK7LQ5APPkW\n\tgBWqsGxeXneXptJfNNLCE2vCjTePsx7ZIfVxdqrfUEFulDCjXWajYoCuOumZOnoYmJ+f\n\tzkyQ==", "X-Gm-Message-State": "AOAM532dGYYnV7Kg4gcJ4l9preIY4f+G7j56Pkm+CLUXl/67obnpFl23\n\t9R5MsDAf+RQ7Vr3cdlPeCxseX5mcozZr/Q==", "X-Google-Smtp-Source": "ABdhPJxsmnq2byDec0OfGiWG4Z9+oudIlYCz/+G/o3aYNi3eNIGp144KnLqTO5oY+sJBsBgducjifA==", "X-Received": "by 2002:aa7:c9d1:: with SMTP id i17mr4807220edt.46.1616510180924;\n\tTue, 23 Mar 2021 07:36:20 -0700 (PDT)", "From": "Naushir Patuck <naush@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 23 Mar 2021 14:36:08 +0000", "Message-Id": "<20210323143610.787760-6-naush@raspberrypi.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20210323143610.787760-1-naush@raspberrypi.com>", "References": "<20210323143610.787760-1-naush@raspberrypi.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v3 5/7] ipa: raspberrypi: Remove unused\n\tmember variable", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The lastMode_ member variable is now unused, so remove it.\n\nSigned-off-by: Naushir Patuck <naush@raspberrypi.com>\nTested-by: David Plowman <david.plowman@raspberrypi.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/ipa/raspberrypi/raspberrypi.cpp | 7 ++-----\n 1 file changed, 2 insertions(+), 5 deletions(-)", "diff": "diff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp\nindex bd20b144f520..93e43f0626fb 100644\n--- a/src/ipa/raspberrypi/raspberrypi.cpp\n+++ b/src/ipa/raspberrypi/raspberrypi.cpp\n@@ -67,8 +67,8 @@ class IPARPi : public ipa::RPi::IPARPiInterface\n {\n public:\n \tIPARPi()\n-\t\t: lastMode_({}), controller_(), frameCount_(0), checkCount_(0),\n-\t\t mistrustCount_(0), lsTable_(nullptr), firstStart_(true)\n+\t\t: controller_(), frameCount_(0), checkCount_(0), mistrustCount_(0),\n+\t\t lsTable_(nullptr), firstStart_(true)\n \t{\n \t}\n \n@@ -128,7 +128,6 @@ private:\n \n \t/* Camera sensor params. */\n \tCameraMode mode_;\n-\tCameraMode lastMode_;\n \n \t/* Raspberry Pi controller specific defines. */\n \tstd::unique_ptr<RPiController::CamHelper> helper_;\n@@ -383,8 +382,6 @@ int IPARPi::configure(const CameraSensorInfo &sensorInfo,\n \t\tresult->controls = std::move(ctrls);\n \t}\n \n-\tlastMode_ = mode_;\n-\n \treturn 0;\n }\n \n", "prefixes": [ "libcamera-devel", "v3", "5/7" ] }