Patch Detail
Show a patch.
GET /api/patches/11665/?format=api
{ "id": 11665, "url": "https://patchwork.libcamera.org/api/patches/11665/?format=api", "web_url": "https://patchwork.libcamera.org/patch/11665/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210323141631.29827-1-laurent.pinchart@ideasonboard.com>", "date": "2021-03-23T14:16:31", "name": "[libcamera-devel] libcamera: camera_manager: Document the CameraManager destructor", "commit_ref": "92cad298fb7d9c459ba96cf06aa8079557e8020f", "pull_url": null, "state": "accepted", "archived": false, "hash": "095a2791b57dc17964be8155e3a58b39e26a0dec", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/11665/mbox/", "series": [ { "id": 1822, "url": "https://patchwork.libcamera.org/api/series/1822/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1822", "date": "2021-03-23T14:16:31", "name": "[libcamera-devel] libcamera: camera_manager: Document the CameraManager destructor", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1822/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/11665/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/11665/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D14D3C32E4\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 23 Mar 2021 14:17:18 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 44D4468D63;\n\tTue, 23 Mar 2021 15:17:18 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DAACE68D5E\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 23 Mar 2021 15:17:16 +0100 (CET)", "from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 31C5A885;\n\tTue, 23 Mar 2021 15:17:16 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"bOk92P3v\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1616509036;\n\tbh=pbz35pOT5dyWAxJnH/T6IUEUlXEMiWUHY3oUiuEop5g=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=bOk92P3vAuDzQakvTYp2jKSeQWRcR9ZcEJu0E43qbdCo4PdpoDxEmRJpXlpNjE/pv\n\tz/kHA+KrewitMwsYNaGIth1s7OMmYwUTX86gHPCyIolOu//mAWYhkeZ4lngHdxTy6E\n\t+PcDrIkxdMasH9f6yK9CmKooHciDAXhYkimxIVrc=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 23 Mar 2021 16:16:31 +0200", "Message-Id": "<20210323141631.29827-1-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.28.1", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH] libcamera: camera_manager: Document the\n\tCameraManager destructor", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The destructor stops the camera manager if it is running. This is at the\nmoment an implementation detail, but makes sense to guarantee in the\nAPI. Document it.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/libcamera/camera_manager.cpp | 5 +++++\n 1 file changed, 5 insertions(+)", "diff": "diff --git a/src/libcamera/camera_manager.cpp b/src/libcamera/camera_manager.cpp\nindex 67641a555e1e..9e4d9c391f09 100644\n--- a/src/libcamera/camera_manager.cpp\n+++ b/src/libcamera/camera_manager.cpp\n@@ -269,6 +269,11 @@ CameraManager::CameraManager()\n \tself_ = this;\n }\n \n+/**\n+ * \\brief Destroy the camera manager\n+ *\n+ * Destroying the camera manager stops it if it is currently running.\n+ */\n CameraManager::~CameraManager()\n {\n \tstop();\n", "prefixes": [ "libcamera-devel" ] }