Patch Detail
Show a patch.
GET /api/patches/11650/?format=api
{ "id": 11650, "url": "https://patchwork.libcamera.org/api/patches/11650/?format=api", "web_url": "https://patchwork.libcamera.org/patch/11650/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210323014226.3211412-6-hiroh@chromium.org>", "date": "2021-03-23T01:42:23", "name": "[libcamera-devel,5/8] android: CameraDevice: Return const shared_ptr& by camera()", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "a1f119e37fc5fae7afe9e7ff8c7c326f123b6bf9", "submitter": { "id": 63, "url": "https://patchwork.libcamera.org/api/people/63/?format=api", "name": "Hirokazu Honda", "email": "hiroh@chromium.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/11650/mbox/", "series": [ { "id": 1817, "url": "https://patchwork.libcamera.org/api/series/1817/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1817", "date": "2021-03-23T01:42:18", "name": "Improve pointer types in android HAL adaptation layer", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1817/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/11650/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/11650/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 16652C32E1\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 23 Mar 2021 01:42:48 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BC56D68D6D;\n\tTue, 23 Mar 2021 02:42:47 +0100 (CET)", "from mail-pg1-x532.google.com (mail-pg1-x532.google.com\n\t[IPv6:2607:f8b0:4864:20::532])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AAD5B68D65\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 23 Mar 2021 02:42:44 +0100 (CET)", "by mail-pg1-x532.google.com with SMTP id u19so10112107pgh.10\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 22 Mar 2021 18:42:44 -0700 (PDT)", "from hiroh2.tok.corp.google.com\n\t([2401:fa00:8f:2:8115:e5cc:747b:64de])\n\tby smtp.gmail.com with ESMTPSA id\n\th13sm590527pjv.52.2021.03.22.18.42.42\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 22 Mar 2021 18:42:42 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"aimzPDmL\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=8V85V8tXNr1xchcUdM20iZoQf/t2GgfTSG7qr1XgV9c=;\n\tb=aimzPDmLvZIGX159TOhNYr0p4uOrBjWN4vSgo0Euh8ccdzmmzG6k7jp744LAmr8tG5\n\t4bXClizverSkbCZIUalmApwzwJeEZGoGls3PfB1ekJXax/pR0fpXEErvGJ0ljdALEUFT\n\tuR6LUyZFz1ZFs1nhUOMkl/diJ0fcIshEBDD94=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=8V85V8tXNr1xchcUdM20iZoQf/t2GgfTSG7qr1XgV9c=;\n\tb=UpBxdwUx+az4GS8yKWIRBLJ3p17C1axGiRRIEW0VaJIGvXXUyntxOLHnWbYhMzOi13\n\tvVTGq6uV7zGZXHudHY9TV6k8wNmMHHd27XcZIVtqMdGbJOCf8h51pcL3wos7NWrE/l9Y\n\ttuasVdhX8/BYoFunfa9lLY//TBUH6G/CORk/QnGt2k1iFNh0SsVngDlzDGvlzMUf+lfL\n\t3gTDDKra7OQruGNtv3YODcgq4MqCTB8rXnRF6g6whAA5ibWo4b7mMFXldkkLBqiOQ3Ig\n\txEUTE1aDAqRMcqrVkCFQwLQmhna6cYUmpSxT76z/fNn9QC2I6rOGESiDNYslrvxLkZDl\n\tuXIg==", "X-Gm-Message-State": "AOAM530bncNeqOI3ySW7IkX2MfvMdo0KrLguVJ0J6Z1zgZuPEJN80Px4\n\tDVA5tsYUdNjS8P6BM/kpCQyOC5o9EzHjAQ==", "X-Google-Smtp-Source": "ABdhPJzdBwa565Zpz0ubtj0pj9OisFT0N11AdrafPjlp6r5Dv705bCvsXjLl6C0LIoVZGdzE1vi6ag==", "X-Received": "by 2002:aa7:956d:0:b029:1f1:5ba6:2a58 with SMTP id\n\tx13-20020aa7956d0000b02901f15ba62a58mr2500464pfq.63.1616463763173; \n\tMon, 22 Mar 2021 18:42:43 -0700 (PDT)", "From": "Hirokazu Honda <hiroh@chromium.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 23 Mar 2021 10:42:23 +0900", "Message-Id": "<20210323014226.3211412-6-hiroh@chromium.org>", "X-Mailer": "git-send-email 2.31.0.rc2.261.g7f71774620-goog", "In-Reply-To": "<20210323014226.3211412-1-hiroh@chromium.org>", "References": "<20210323014226.3211412-1-hiroh@chromium.org>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH 5/8] android: CameraDevice: Return const\n\tshared_ptr& by camera()", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "CameraDevice::camera() originally returns shared_ptr. It is\nmandatory to make a copy by calling camera() in this way. There\nis no need of copying if a caller needs the reference of the\ncamera like const shared_ptr<Camera> cam = camera(). That is, it\nis a caller that copying is required. This changes the return\ntype of camera() to const shared_ptr&, so that we are able to\nreduce one redundant copy in the above case.\n\nSigned-off-by: Hirokazu Honda <hiroh@chromium.org>\n\n---\n src/android/camera_device.h | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\n--\n2.31.0.rc2.261.g7f71774620-goog", "diff": "diff --git a/src/android/camera_device.h b/src/android/camera_device.h\nindex 555b33e7..14e26b4d 100644\n--- a/src/android/camera_device.h\n+++ b/src/android/camera_device.h\n@@ -43,7 +43,7 @@ public:\n\n \tunsigned int id() const { return id_; }\n \tcamera3_device_t *camera3Device() { return &camera3Device_; }\n-\tstd::shared_ptr<libcamera::Camera> camera() const { return camera_; }\n+\tconst std::shared_ptr<libcamera::Camera> &camera() const { return camera_; }\n \tlibcamera::CameraConfiguration *cameraConfiguration() const\n \t{\n \t\treturn config_.get();\n", "prefixes": [ "libcamera-devel", "5/8" ] }