Patch Detail
Show a patch.
GET /api/patches/11630/?format=api
{ "id": 11630, "url": "https://patchwork.libcamera.org/api/patches/11630/?format=api", "web_url": "https://patchwork.libcamera.org/patch/11630/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210319164046.5626-1-m.cichy@pengutronix.de>", "date": "2021-03-19T16:40:46", "name": "[libcamera-devel] libcamera: controls: Extend docs how to identify controls from ControlList", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "54dbdc32af3b2ff094e5a1388a9b818a77984a13", "submitter": { "id": 80, "url": "https://patchwork.libcamera.org/api/people/80/?format=api", "name": "Marian Cichy", "email": "m.cichy@pengutronix.de" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/11630/mbox/", "series": [ { "id": 1806, "url": "https://patchwork.libcamera.org/api/series/1806/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1806", "date": "2021-03-19T16:40:46", "name": "[libcamera-devel] libcamera: controls: Extend docs how to identify controls from ControlList", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1806/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/11630/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/11630/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0B0D3C32E1\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 19 Mar 2021 16:40:51 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6CB4B68D62;\n\tFri, 19 Mar 2021 17:40:50 +0100 (CET)", "from metis.ext.pengutronix.de (metis.ext.pengutronix.de\n\t[IPv6:2001:67c:670:201:290:27ff:fe1d:cc33])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 26F7B6051E\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 19 Mar 2021 17:40:49 +0100 (CET)", "from dude02.hi.pengutronix.de ([2001:67c:670:100:1d::28])\n\tby metis.ext.pengutronix.de with esmtps\n\t(TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92)\n\t(envelope-from <mci@pengutronix.de>)\n\tid 1lNIB6-0004V6-FM; Fri, 19 Mar 2021 17:40:48 +0100", "from mci by dude02.hi.pengutronix.de with local (Exim 4.92)\n\t(envelope-from <mci@pengutronix.de>)\n\tid 1lNIB6-0001Vd-6J; Fri, 19 Mar 2021 17:40:48 +0100" ], "From": "Marian Cichy <m.cichy@pengutronix.de>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 19 Mar 2021 17:40:46 +0100", "Message-Id": "<20210319164046.5626-1-m.cichy@pengutronix.de>", "X-Mailer": "git-send-email 2.29.2", "MIME-Version": "1.0", "X-SA-Exim-Connect-IP": "2001:67c:670:100:1d::28", "X-SA-Exim-Mail-From": "mci@pengutronix.de", "X-SA-Exim-Scanned": "No (on metis.ext.pengutronix.de);\n\tSAEximRunCond expanded to false", "X-PTX-Original-Recipient": "libcamera-devel@lists.libcamera.org", "Subject": "[libcamera-devel] [PATCH] libcamera: controls: Extend docs how to\n\tidentify controls from ControlList", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Cc": "graphics@pengutronix.de, Marian Cichy <m.cichy@pengutronix.de>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Informations how to identify Controls from a ControlList is quite\nscattered around the documentation and not clear if one reads about the\nControlList. Referring to ControlId and ControlIdMap right in the\ndetailed description is probably very helpful.\n\nSigned-off-by: Marian Cichy <m.cichy@pengutronix.de>\n---\n src/libcamera/controls.cpp | 4 ++++\n 1 file changed, 4 insertions(+)", "diff": "diff --git a/src/libcamera/controls.cpp b/src/libcamera/controls.cpp\nindex c58ed394..b5253f83 100644\n--- a/src/libcamera/controls.cpp\n+++ b/src/libcamera/controls.cpp\n@@ -805,6 +805,10 @@ ControlList::ControlList()\n * For ControlList containing libcamera controls, a global map of all libcamera\n * controls is provided by controls::controls and can be used as the \\a idmap\n * argument.\n+ *\n+ * To identify a Control from the ControlList, one needs to find the ControlId\n+ * from the numerical control id saved in this list. A global ControlIdMap\n+ * of all libcamera controls is provided by controls::controls.\n */\n ControlList::ControlList(const ControlIdMap &idmap, ControlValidator *validator)\n \t: validator_(validator), idmap_(&idmap), infoMap_(nullptr)\n", "prefixes": [ "libcamera-devel" ] }