Patch Detail
Show a patch.
GET /api/patches/11620/?format=api
{ "id": 11620, "url": "https://patchwork.libcamera.org/api/patches/11620/?format=api", "web_url": "https://patchwork.libcamera.org/patch/11620/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210318103941.18837-8-jacopo@jmondi.org>", "date": "2021-03-18T10:39:41", "name": "[libcamera-devel,7/7] libcamera: ipu3: imgu: Change IF_CROP_MAX to 40", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "6f0a55b6aa85e315c49dfc00391ce351802cbb4d", "submitter": { "id": 3, "url": "https://patchwork.libcamera.org/api/people/3/?format=api", "name": "Jacopo Mondi", "email": "jacopo@jmondi.org" }, "delegate": { "id": 15, "url": "https://patchwork.libcamera.org/api/users/15/?format=api", "username": "jmondi", "first_name": "Jacopo", "last_name": "Mondi", "email": "jacopo@jmondi.org" }, "mbox": "https://patchwork.libcamera.org/patch/11620/mbox/", "series": [ { "id": 1801, "url": "https://patchwork.libcamera.org/api/series/1801/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1801", "date": "2021-03-18T10:39:34", "name": "ipu3: imgu: Improve ImgU calculation procedure", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1801/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/11620/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/11620/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8234FBD80C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 18 Mar 2021 10:39:26 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 32B3E68D6E;\n\tThu, 18 Mar 2021 11:39:26 +0100 (CET)", "from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net\n\t[217.70.183.198])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 66C9C68D74\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 18 Mar 2021 11:39:22 +0100 (CET)", "from uno.homenet.telecomitalia.it\n\t(host-79-22-58-175.retail.telecomitalia.it [79.22.58.175])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay6-d.mail.gandi.net (Postfix) with ESMTPSA id 4DB1BC0002;\n\tThu, 18 Mar 2021 10:39:21 +0000 (UTC)" ], "X-Originating-IP": "79.22.58.175", "From": "Jacopo Mondi <jacopo@jmondi.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 18 Mar 2021 11:39:41 +0100", "Message-Id": "<20210318103941.18837-8-jacopo@jmondi.org>", "X-Mailer": "git-send-email 2.30.0", "In-Reply-To": "<20210318103941.18837-1-jacopo@jmondi.org>", "References": "<20210318103941.18837-1-jacopo@jmondi.org>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH 7/7] libcamera: ipu3: imgu: Change\n\tIF_CROP_MAX to 40", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Cc": "Dave Olsthoorn <dave@bewaar.me>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "From: Dave Olsthoorn <dave@bewaar.me>\n\nThe value of IF_CROP_MAX seems to be a typo. A resolution of 40x540 seems\nunlikely and excludes camera's with a 640x480 resolution, like the OV7251\nin several Microsoft Surface products, from working.\n\nThis patch corrects the value to 40 since a minimal resolution of 40x40\nseems more logical.\n\nSigned-off-by: Dave Olsthoorn <dave@bewaar.me>\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n src/libcamera/pipeline/ipu3/imgu.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/pipeline/ipu3/imgu.cpp b/src/libcamera/pipeline/ipu3/imgu.cpp\nindex b6a1fe34494e..dd7d2e947141 100644\n--- a/src/libcamera/pipeline/ipu3/imgu.cpp\n+++ b/src/libcamera/pipeline/ipu3/imgu.cpp\n@@ -44,7 +44,7 @@ static constexpr unsigned int BDS_ALIGN_W = 2;\n static constexpr unsigned int BDS_ALIGN_H = 4;\n \n static constexpr unsigned int IF_CROP_MAX_W = 40;\n-static constexpr unsigned int IF_CROP_MAX_H = 540;\n+static constexpr unsigned int IF_CROP_MAX_H = 40;\n \n static constexpr float BDS_SF_MAX = 2.5;\n static constexpr float BDS_SF_MIN = 1.0;\n", "prefixes": [ "libcamera-devel", "7/7" ] }