Patch Detail
Show a patch.
GET /api/patches/11593/?format=api
{ "id": 11593, "url": "https://patchwork.libcamera.org/api/patches/11593/?format=api", "web_url": "https://patchwork.libcamera.org/patch/11593/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210316155211.6679-4-m.cichy@pengutronix.de>", "date": "2021-03-16T15:52:08", "name": "[libcamera-devel,RFC,3/6] libcamera: v4l2_subdevice: Add methods to get/set frame interval", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "ad11e4e1e32048859a8afec86bf9ce2004bbbd24", "submitter": { "id": 80, "url": "https://patchwork.libcamera.org/api/people/80/?format=api", "name": "Marian Cichy", "email": "m.cichy@pengutronix.de" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/11593/mbox/", "series": [ { "id": 1798, "url": "https://patchwork.libcamera.org/api/series/1798/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1798", "date": "2021-03-16T15:52:05", "name": "Add propagation of sensor frame interval", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1798/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/11593/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/11593/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 050FCBD80C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 16 Mar 2021 15:52:32 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CC72068D50;\n\tTue, 16 Mar 2021 16:52:30 +0100 (CET)", "from metis.ext.pengutronix.de (metis.ext.pengutronix.de\n\t[IPv6:2001:67c:670:201:290:27ff:fe1d:cc33])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9BED368D49\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 16 Mar 2021 16:52:27 +0100 (CET)", "from dude02.hi.pengutronix.de ([2001:67c:670:100:1d::28])\n\tby metis.ext.pengutronix.de with esmtps\n\t(TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92)\n\t(envelope-from <mci@pengutronix.de>)\n\tid 1lMBze-0000V3-SW; Tue, 16 Mar 2021 16:52:26 +0100", "from mci by dude02.hi.pengutronix.de with local (Exim 4.92)\n\t(envelope-from <mci@pengutronix.de>)\n\tid 1lMBze-0003Dd-IZ; Tue, 16 Mar 2021 16:52:26 +0100" ], "From": "Marian Cichy <m.cichy@pengutronix.de>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 16 Mar 2021 16:52:08 +0100", "Message-Id": "<20210316155211.6679-4-m.cichy@pengutronix.de>", "X-Mailer": "git-send-email 2.29.2", "In-Reply-To": "<20210316155211.6679-1-m.cichy@pengutronix.de>", "References": "<20210316155211.6679-1-m.cichy@pengutronix.de>", "MIME-Version": "1.0", "X-SA-Exim-Connect-IP": "2001:67c:670:100:1d::28", "X-SA-Exim-Mail-From": "mci@pengutronix.de", "X-SA-Exim-Scanned": "No (on metis.ext.pengutronix.de);\n\tSAEximRunCond expanded to false", "X-PTX-Original-Recipient": "libcamera-devel@lists.libcamera.org", "Subject": "[libcamera-devel] [RFC PATCH 3/6] libcamera: v4l2_subdevice: Add\n\tmethods to get/set frame interval", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Cc": "graphics@pengutronix.de, Marian Cichy <m.cichy@pengutronix.de>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add API-methods to get and set the frame interval on V4L2-subdevices.\n\nSigned-off-by: Marian Cichy <m.cichy@pengutronix.de>\n---\n include/libcamera/internal/v4l2_subdevice.h | 4 ++\n src/libcamera/v4l2_subdevice.cpp | 43 +++++++++++++++++++++\n 2 files changed, 47 insertions(+)", "diff": "diff --git a/include/libcamera/internal/v4l2_subdevice.h b/include/libcamera/internal/v4l2_subdevice.h\nindex d2b9ca55..310746d9 100644\n--- a/include/libcamera/internal/v4l2_subdevice.h\n+++ b/include/libcamera/internal/v4l2_subdevice.h\n@@ -12,6 +12,7 @@\n #include <vector>\n \n #include <libcamera/class.h>\n+#include <libcamera/fraction.h>\n #include <libcamera/geometry.h>\n \n #include \"libcamera/internal/formats.h\"\n@@ -60,6 +61,9 @@ public:\n \tint setFormat(unsigned int pad, V4L2SubdeviceFormat *format,\n \t\t Whence whence = ActiveFormat);\n \n+\tint getFrameInterval(unsigned int pad, Fraction *frameInterval);\n+\tint setFrameInterval(unsigned int pad, Fraction *frameInterval);\n+\n \tstatic std::unique_ptr<V4L2Subdevice>\n \tfromEntityName(const MediaDevice *media, const std::string &entity);\n \ndiff --git a/src/libcamera/v4l2_subdevice.cpp b/src/libcamera/v4l2_subdevice.cpp\nindex 721ff5a9..eac2d7d3 100644\n--- a/src/libcamera/v4l2_subdevice.cpp\n+++ b/src/libcamera/v4l2_subdevice.cpp\n@@ -17,6 +17,7 @@\n #include <linux/media-bus-format.h>\n #include <linux/v4l2-subdev.h>\n \n+#include <libcamera/fraction.h>\n #include <libcamera/geometry.h>\n \n #include \"libcamera/internal/log.h\"\n@@ -440,6 +441,48 @@ int V4L2Subdevice::setFormat(unsigned int pad, V4L2SubdeviceFormat *format,\n \treturn 0;\n }\n \n+int V4L2Subdevice::getFrameInterval(unsigned int pad, Fraction *frameInterval)\n+{\n+\tstruct v4l2_subdev_frame_interval subdevFrameInterval = {};\n+\tsubdevFrameInterval.pad = pad;\n+\n+\tint ret = ioctl(VIDIOC_SUBDEV_G_FRAME_INTERVAL, &subdevFrameInterval);\n+\tif (ret) {\n+\t\tLOG(V4L2, Debug)\n+\t\t\t<< \"Unable to get frame interval on pad \" << pad\n+\t\t\t<< \": \" << strerror(-ret);\n+\t\treturn ret;\n+\t}\n+\n+\tframeInterval->numerator = subdevFrameInterval.interval.numerator;\n+\tframeInterval->denominator = subdevFrameInterval.interval.denominator;\n+\n+\treturn 0;\n+}\n+\n+int V4L2Subdevice::setFrameInterval(unsigned int pad, Fraction *frameInterval)\n+{\n+\tstruct v4l2_subdev_frame_interval subdevFrameInterval = {};\n+\tstruct v4l2_fract fract = { frameInterval->numerator,\n+\t\t\t\t frameInterval->denominator };\n+\n+\tsubdevFrameInterval.pad = pad;\n+\tsubdevFrameInterval.interval = fract;\n+\n+\tint ret = ioctl(VIDIOC_SUBDEV_S_FRAME_INTERVAL, &subdevFrameInterval);\n+\tif (ret) {\n+\t\tLOG(V4L2, Debug)\n+\t\t\t<< \"Unable to set frame interval on pad \" << pad\n+\t\t\t<< \": \" << strerror(-ret);\n+\t\treturn ret;\n+\t}\n+\n+\tframeInterval->numerator = subdevFrameInterval.interval.numerator;\n+\tframeInterval->denominator = subdevFrameInterval.interval.denominator;\n+\n+\treturn 0;\n+}\n+\n /**\n * \\brief Create a new video subdevice instance from \\a entity in media device\n * \\a media\n", "prefixes": [ "libcamera-devel", "RFC", "3/6" ] }