Patch Detail
Show a patch.
GET /api/patches/11587/?format=api
{ "id": 11587, "url": "https://patchwork.libcamera.org/api/patches/11587/?format=api", "web_url": "https://patchwork.libcamera.org/patch/11587/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210316144711.40778-3-jeanmichel.hautbois@ideasonboard.com>", "date": "2021-03-16T14:47:10", "name": "[libcamera-devel,v3,2/3] libcamera: ipu3: Move ipa configuration from start() to configure()", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "9a44f9cefb916bb9154da555a31f4e4f5b11b872", "submitter": { "id": 75, "url": "https://patchwork.libcamera.org/api/people/75/?format=api", "name": "Jean-Michel Hautbois", "email": "jeanmichel.hautbois@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/11587/mbox/", "series": [ { "id": 1796, "url": "https://patchwork.libcamera.org/api/series/1796/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1796", "date": "2021-03-16T14:47:08", "name": "Prepare IPU3 pipeline to pass BDS to IPA", "version": 3, "mbox": "https://patchwork.libcamera.org/series/1796/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/11587/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/11587/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2F2AABD80C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 16 Mar 2021 14:47:25 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E3CD968D4F;\n\tTue, 16 Mar 2021 15:47:24 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6B19868D4D\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 16 Mar 2021 15:47:23 +0100 (CET)", "from localhost.localdomain (unknown\n\t[IPv6:2a01:e0a:169:7140:f840:1816:ba68:a009])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1A3EA8C8;\n\tTue, 16 Mar 2021 15:47:23 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"G+tvmEhW\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1615906043;\n\tbh=m1ptAZBNku/80rSrV60VyvMk0o6/PR1Zm5R4W9mlVtg=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=G+tvmEhWiXhHczU94ZFww2ddVzKTNGd0Ce8NXz9EI9tZxNWgKPn/9jMsSTkaQ+yHV\n\tSTMlyWrXuPRSSMcra/NLHKVd2toBOze4t7Pp5r1xd0WiJ1476MzAlwUhuDqxUzuSDU\n\tpbxPYR3EZ1W91vVyJCRGhC7FX3/q8Bo2uvvQi27Y=", "From": "Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 16 Mar 2021 15:47:10 +0100", "Message-Id": "<20210316144711.40778-3-jeanmichel.hautbois@ideasonboard.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20210316144711.40778-1-jeanmichel.hautbois@ideasonboard.com>", "References": "<20210316144711.40778-1-jeanmichel.hautbois@ideasonboard.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v3 2/3] libcamera: ipu3: Move ipa\n\tconfiguration from start() to configure()", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "IPA was configured after all the pipeline devices were started,\nincluding IPA itself...\nMove it at the end of configure() call.\n\nSigned-off-by: Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>\n---\n src/libcamera/pipeline/ipu3/ipu3.cpp | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)", "diff": "diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\nindex 65657dcc..174c1dd8 100644\n--- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n+++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n@@ -631,6 +631,10 @@ int PipelineHandlerIPU3::configure(Camera *camera, CameraConfiguration *c)\n \t\treturn ret;\n \t}\n \n+\tstd::map<uint32_t, ControlInfoMap> entityControls;\n+\tentityControls.emplace(0, data->cio2_.sensor()->controls());\n+\tdata->ipa_->configure(entityControls);\n+\n \treturn 0;\n }\n \n@@ -715,7 +719,6 @@ int PipelineHandlerIPU3::freeBuffers(Camera *camera)\n \n int PipelineHandlerIPU3::start(Camera *camera, [[maybe_unused]] const ControlList *controls)\n {\n-\tstd::map<uint32_t, ControlInfoMap> entityControls;\n \tIPU3CameraData *data = cameraData(camera);\n \tCIO2Device *cio2 = &data->cio2_;\n \tImgUDevice *imgu = data->imgu_;\n@@ -742,9 +745,6 @@ int PipelineHandlerIPU3::start(Camera *camera, [[maybe_unused]] const ControlLis\n \tif (ret)\n \t\tgoto error;\n \n-\tentityControls.emplace(0, data->cio2_.sensor()->controls());\n-\tdata->ipa_->configure(entityControls);\n-\n \treturn 0;\n \n error:\n", "prefixes": [ "libcamera-devel", "v3", "2/3" ] }