Patch Detail
Show a patch.
GET /api/patches/11565/?format=api
{ "id": 11565, "url": "https://patchwork.libcamera.org/api/patches/11565/?format=api", "web_url": "https://patchwork.libcamera.org/patch/11565/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210312061131.854849-6-kieran.bingham@ideasonboard.com>", "date": "2021-03-12T06:11:28", "name": "[libcamera-devel,5/8] libcamera: pipeline: ipu3: frames: Add FrameInfo state tracing", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "95e0eacf722a22de2fddbd66c438fac059b9f949", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": { "id": 11, "url": "https://patchwork.libcamera.org/api/users/11/?format=api", "username": "kbingham", "first_name": "Kieran", "last_name": "Bingham", "email": "kieran.bingham@ideasonboard.com" }, "mbox": "https://patchwork.libcamera.org/patch/11565/mbox/", "series": [ { "id": 1786, "url": "https://patchwork.libcamera.org/api/series/1786/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1786", "date": "2021-03-12T06:11:23", "name": "IPU3 Debug improvements", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1786/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/11565/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/11565/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E2D2CBD1F1\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 12 Mar 2021 06:11:43 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9B019602ED;\n\tFri, 12 Mar 2021 07:11:43 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D753168C75\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 12 Mar 2021 07:11:37 +0100 (CET)", "from localhost.localdomain\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4642BB60;\n\tFri, 12 Mar 2021 07:11:37 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ddyoaOsa\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1615529497;\n\tbh=mjb9EEd8Zf5PA1G9OwUMexHAJ/QoKzQTvOaU/OXhVFs=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=ddyoaOsaj3vEl8xj/FtzrGI2Lk7IKsPcdFZB+3ClUx053NEUErDeLo2tNcDVqoycP\n\t4Mh0CoihcY2LFS0+BApfAHLaZfQzdA/sBDJlnONxz4PyIR01k8axlV8EyE6fiyg3Tl\n\tsK5omrcXtVKqvqNOsUjjF5KGAaa4rb/CSVEVmpGM=", "From": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "To": "libcamera devel <libcamera-devel@lists.libcamera.org>", "Date": "Fri, 12 Mar 2021 06:11:28 +0000", "Message-Id": "<20210312061131.854849-6-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20210312061131.854849-1-kieran.bingham@ideasonboard.com>", "References": "<20210312061131.854849-1-kieran.bingham@ideasonboard.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH 5/8] libcamera: pipeline: ipu3: frames:\n\tAdd FrameInfo state tracing", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Provide a toString() function on the IPU3Frames::Info structure so that\nit can be reported during debug logs.\n\nProvide a public helper on the IPU3Frames class to report the state of\nall Info structures it holds.\n\nThis method can be used when debugging the contexts that are associated\nwith requests.\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/libcamera/pipeline/ipu3/frames.cpp | 23 +++++++++++++++++++++++\n src/libcamera/pipeline/ipu3/frames.h | 4 ++++\n 2 files changed, 27 insertions(+)", "diff": "diff --git a/src/libcamera/pipeline/ipu3/frames.cpp b/src/libcamera/pipeline/ipu3/frames.cpp\nindex 4198e2019f3f..b8b471c3c561 100644\n--- a/src/libcamera/pipeline/ipu3/frames.cpp\n+++ b/src/libcamera/pipeline/ipu3/frames.cpp\n@@ -131,4 +131,27 @@ IPU3Frames::Info *IPU3Frames::find(FrameBuffer *buffer)\n \treturn nullptr;\n }\n \n+const std::string IPU3Frames::Info::toString() const\n+{\n+\tstd::stringstream ss;\n+\n+\tss << request->toString()\n+\t << (metadataProcessed ? \"\" : \"[!metadata]\")\n+\t << (paramDequeued ? \"\" : \"[!param]\");\n+\n+\treturn ss.str();\n+}\n+\n+void IPU3Frames::dump() const\n+{\n+\tLOG(IPU3, Error) << \"Frames:\";\n+\n+\tfor (auto const &itInfo : frameInfo_) {\n+\t\tInfo *info = itInfo.second.get();\n+\n+\t\tLOG(IPU3, Error)\n+\t\t\t<< \" - \" << info->toString();\n+\t}\n+}\n+\n } /* namespace libcamera */\ndiff --git a/src/libcamera/pipeline/ipu3/frames.h b/src/libcamera/pipeline/ipu3/frames.h\nindex 4acdf48eca9d..c769ae864d32 100644\n--- a/src/libcamera/pipeline/ipu3/frames.h\n+++ b/src/libcamera/pipeline/ipu3/frames.h\n@@ -34,6 +34,8 @@ public:\n \n \t\tbool paramDequeued;\n \t\tbool metadataProcessed;\n+\n+\t\tconst std::string toString() const;\n \t};\n \n \tIPU3Frames();\n@@ -49,6 +51,8 @@ public:\n \tInfo *find(unsigned int id);\n \tInfo *find(FrameBuffer *buffer);\n \n+\tvoid dump() const;\n+\n private:\n \tstd::queue<FrameBuffer *> availableParamBuffers_;\n \tstd::queue<FrameBuffer *> availableStatBuffers_;\n", "prefixes": [ "libcamera-devel", "5/8" ] }