Patch Detail
Show a patch.
GET /api/patches/11511/?format=api
{ "id": 11511, "url": "https://patchwork.libcamera.org/api/patches/11511/?format=api", "web_url": "https://patchwork.libcamera.org/patch/11511/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210308101356.59333-3-paul.elder@ideasonboard.com>", "date": "2021-03-08T10:13:54", "name": "[libcamera-devel,2/4] android: jpeg: exif: Simplify setGPSDateTimestamp and setGPSDMS", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "6ff3450479daac5a2125cf224f9a52c7224ff22e", "submitter": { "id": 17, "url": "https://patchwork.libcamera.org/api/people/17/?format=api", "name": "Paul Elder", "email": "paul.elder@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/11511/mbox/", "series": [ { "id": 1767, "url": "https://patchwork.libcamera.org/api/series/1767/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1767", "date": "2021-03-08T10:13:52", "name": "android: jpeg: exif: Fix GPS altitude", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1767/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/11511/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/11511/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F3B38BD1F1\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 8 Mar 2021 10:14:11 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A81F368AA1;\n\tMon, 8 Mar 2021 11:14:11 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 133E6602E6\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 8 Mar 2021 11:14:10 +0100 (CET)", "from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 932988A3;\n\tMon, 8 Mar 2021 11:14:08 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"jHFGfEUv\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1615198449;\n\tbh=RN7RRonhHrIGcZusbzCmJmzrhMEFMO94nSqppmD+HA0=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=jHFGfEUvodTlIOaXMwev1lNGpJO3+a1nmjC1Lr3Q5l3bJ7GgzjtJRvTyztHVOhmoB\n\tEHJ5+UTMAa07t7qBUw1EgiKHBbKg5ngW6abGhDOlTUFFVikyyoCu0pEFqi71dn4skO\n\tvoYfv+VwN9Kf1le0ctbp9O8WoqGOLAt/mCEpm19g=", "From": "Paul Elder <paul.elder@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 8 Mar 2021 19:13:54 +0900", "Message-Id": "<20210308101356.59333-3-paul.elder@ideasonboard.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20210308101356.59333-1-paul.elder@ideasonboard.com>", "References": "<20210308101356.59333-1-paul.elder@ideasonboard.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH 2/4] android: jpeg: exif: Simplify\n\tsetGPSDateTimestamp and setGPSDMS", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Now that setRational() supports setting multiple rational values, use\nthat in setGPSDateTimestamp and setGPSDMS which previously set every\nrational manually.\n\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\n---\n src/android/jpeg/exif.cpp | 24 ++----------------------\n 1 file changed, 2 insertions(+), 22 deletions(-)", "diff": "diff --git a/src/android/jpeg/exif.cpp b/src/android/jpeg/exif.cpp\nindex e5a3e448..c8b2f072 100644\n--- a/src/android/jpeg/exif.cpp\n+++ b/src/android/jpeg/exif.cpp\n@@ -345,24 +345,13 @@ void Exif::setGPSDateTimestamp(time_t timestamp)\n \t\t EXIF_FORMAT_ASCII, tsStr);\n \n \t/* Set GPS_TIME_STAMP */\n-\tExifEntry *entry =\n-\t\tcreateEntry(EXIF_IFD_GPS,\n-\t\t\t static_cast<ExifTag>(EXIF_TAG_GPS_TIME_STAMP),\n-\t\t\t EXIF_FORMAT_RATIONAL, 3, 3 * sizeof(ExifRational));\n-\tif (!entry)\n-\t\treturn;\n-\n \tExifRational ts[] = {\n \t\t{ static_cast<ExifLong>(tm.tm_hour), 1 },\n \t\t{ static_cast<ExifLong>(tm.tm_min), 1 },\n \t\t{ static_cast<ExifLong>(tm.tm_sec), 1 },\n \t};\n \n-\tfor (int i = 0; i < 3; i++)\n-\t\texif_set_rational(entry->data + i * sizeof(ExifRational),\n-\t\t\t\t order_, ts[i]);\n-\n-\texif_entry_unref(entry);\n+\tsetRational(EXIF_IFD_GPS, static_cast<ExifTag>(EXIF_TAG_GPS_TIME_STAMP), 3, ts);\n }\n \n std::tuple<int, int, int> Exif::degreesToDMS(double decimalDegrees)\n@@ -376,22 +365,13 @@ std::tuple<int, int, int> Exif::degreesToDMS(double decimalDegrees)\n \n void Exif::setGPSDMS(ExifIfd ifd, ExifTag tag, int deg, int min, int sec)\n {\n-\tExifEntry *entry = createEntry(ifd, tag, EXIF_FORMAT_RATIONAL, 3,\n-\t\t\t\t 3 * sizeof(ExifRational));\n-\tif (!entry)\n-\t\treturn;\n-\n \tExifRational coords[] = {\n \t\t{ static_cast<ExifLong>(deg), 1 },\n \t\t{ static_cast<ExifLong>(min), 1 },\n \t\t{ static_cast<ExifLong>(sec), 1 },\n \t};\n \n-\tfor (int i = 0; i < 3; i++)\n-\t\texif_set_rational(entry->data + i * sizeof(ExifRational),\n-\t\t\t\t order_, coords[i]);\n-\n-\texif_entry_unref(entry);\n+\tsetRational(ifd, tag, 3, coords);\n }\n \n /*\n", "prefixes": [ "libcamera-devel", "2/4" ] }