Patch Detail
Show a patch.
GET /api/patches/11442/?format=api
{ "id": 11442, "url": "https://patchwork.libcamera.org/api/patches/11442/?format=api", "web_url": "https://patchwork.libcamera.org/patch/11442/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210302115108.103328-10-jacopo@jmondi.org>", "date": "2021-03-02T11:51:07", "name": "[libcamera-devel,v3,09/10] android: mm: Provide helper macro for PIMPL", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "bc0ea58b42b4fff40fb453cf27645b659940b7c5", "submitter": { "id": 3, "url": "https://patchwork.libcamera.org/api/people/3/?format=api", "name": "Jacopo Mondi", "email": "jacopo@jmondi.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/11442/mbox/", "series": [ { "id": 1738, "url": "https://patchwork.libcamera.org/api/series/1738/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1738", "date": "2021-03-02T11:50:58", "name": "android: Supports memory backends", "version": 3, "mbox": "https://patchwork.libcamera.org/series/1738/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/11442/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/11442/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E4A39BD808\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 2 Mar 2021 11:50:59 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C16B668AA5;\n\tTue, 2 Mar 2021 12:50:59 +0100 (CET)", "from relay12.mail.gandi.net (relay12.mail.gandi.net\n\t[217.70.178.232])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7349868A98\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 2 Mar 2021 12:50:58 +0100 (CET)", "from uno.LocalDomain (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay12.mail.gandi.net (Postfix) with ESMTPSA id 05B5120000B;\n\tTue, 2 Mar 2021 11:50:56 +0000 (UTC)" ], "From": "Jacopo Mondi <jacopo@jmondi.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 2 Mar 2021 12:51:07 +0100", "Message-Id": "<20210302115108.103328-10-jacopo@jmondi.org>", "X-Mailer": "git-send-email 2.30.0", "In-Reply-To": "<20210302115108.103328-1-jacopo@jmondi.org>", "References": "<20210302115108.103328-1-jacopo@jmondi.org>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v3 09/10] android: mm: Provide helper\n\tmacro for PIMPL", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Cc": "Han-lin Chen <hanlinchen@chromium.org>,\n\tDaniel Hung-yu Wu <hywu@google.com>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Each memory backend has to declare a CameraBuffer class implementation\nthat bridges the API calls to each CameraBuffer::Private implementation.\n\nAs the code is likely the same for most (if not all) backends, provide\na convenience macro that expands to the CameraBuffer class declaration.\n\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n src/android/camera_buffer.h | 33 ++++++++++++++++++++\n src/android/mm/generic_camera_buffer.cpp | 39 +-----------------------\n 2 files changed, 34 insertions(+), 38 deletions(-)", "diff": "diff --git a/src/android/camera_buffer.h b/src/android/camera_buffer.h\nindex 342aac6d3f14..eb1c12c1e9dd 100644\n--- a/src/android/camera_buffer.h\n+++ b/src/android/camera_buffer.h\n@@ -30,4 +30,37 @@ public:\n \tsize_t jpegBlobSize(size_t maxJpegBlobSize);\n };\n \n+#define PUBLIC_CAMERA_BUFFER_IMPLEMENTATION\t\t\t\t\\\n+CameraBuffer::CameraBuffer(buffer_handle_t camera3Buffer, int flags)\t\\\n+\t: Extensible(new Private(this, camera3Buffer, flags))\t\t\\\n+{\t\t\t\t\t\t\t\t\t\\\n+}\t\t\t\t\t\t\t\t\t\\\n+CameraBuffer::~CameraBuffer()\t\t\t\t\t\t\\\n+{\t\t\t\t\t\t\t\t\t\\\n+}\t\t\t\t\t\t\t\t\t\\\n+bool CameraBuffer::isValid() const\t\t\t\t\t\\\n+{\t\t\t\t\t\t\t\t\t\\\n+\tconst Private *const d = LIBCAMERA_D_PTR();\t\t\t\\\n+\treturn d->isValid();\t\t\t\t\t\t\\\n+}\t\t\t\t\t\t\t\t\t\\\n+unsigned int CameraBuffer::numPlanes() const\t\t\t\t\\\n+{\t\t\t\t\t\t\t\t\t\\\n+\tconst Private *const d = LIBCAMERA_D_PTR();\t\t\t\\\n+\treturn d->numPlanes();\t\t\t\t\t\t\\\n+}\t\t\t\t\t\t\t\t\t\\\n+Span<const uint8_t> CameraBuffer::plane(unsigned int plane) const\t\\\n+{\t\t\t\t\t\t\t\t\t\\\n+\tconst Private *const d = LIBCAMERA_D_PTR();\t\t\t\\\n+\treturn const_cast<Private *>(d)->plane(plane);\t\t\t\\\n+}\t\t\t\t\t\t\t\t\t\\\n+Span<uint8_t> CameraBuffer::plane(unsigned int plane)\t\t\t\\\n+{\t\t\t\t\t\t\t\t\t\\\n+\tPrivate *const d = LIBCAMERA_D_PTR();\t\t\t\t\\\n+\treturn d->plane(plane);\t\t\t\t\t\t\\\n+}\t\t\t\t\t\t\t\t\t\\\n+size_t CameraBuffer::jpegBlobSize(size_t maxJpegBlobSize)\t\t\\\n+{\t\t\t\t\t\t\t\t\t\\\n+\tPrivate *const d = LIBCAMERA_D_PTR();\t\t\t\t\\\n+\treturn d->jpegBlobSize(maxJpegBlobSize);\t\t\t\\\n+}\n #endif /* __ANDROID_CAMERA_BUFFER_H__ */\ndiff --git a/src/android/mm/generic_camera_buffer.cpp b/src/android/mm/generic_camera_buffer.cpp\nindex 5637b3f415eb..c5e66a454fbb 100644\n--- a/src/android/mm/generic_camera_buffer.cpp\n+++ b/src/android/mm/generic_camera_buffer.cpp\n@@ -85,41 +85,4 @@ size_t CameraBuffer::Private::jpegBlobSize(size_t maxJpegBlobSize)\n \t\t\t\t maxJpegBlobSize);\n }\n \n-CameraBuffer::CameraBuffer(buffer_handle_t camera3Buffer, int flags)\n-\t: Extensible(new Private(this, camera3Buffer, flags))\n-{\n-}\n-\n-CameraBuffer::~CameraBuffer()\n-{\n-}\n-\n-bool CameraBuffer::isValid() const\n-{\n-\tconst Private *const d = LIBCAMERA_D_PTR();\n-\treturn d->isValid();\n-}\n-\n-unsigned int CameraBuffer::numPlanes() const\n-{\n-\tconst Private *const d = LIBCAMERA_D_PTR();\n-\treturn d->numPlanes();\n-}\n-\n-Span<const uint8_t> CameraBuffer::plane(unsigned int plane) const\n-{\n-\tconst Private *const d = LIBCAMERA_D_PTR();\n-\treturn const_cast<Private *>(d)->plane(plane);\n-}\n-\n-Span<uint8_t> CameraBuffer::plane(unsigned int plane)\n-{\n-\tPrivate *const d = LIBCAMERA_D_PTR();\n-\treturn d->plane(plane);\n-}\n-\n-size_t CameraBuffer::jpegBlobSize(size_t maxJpegBlobSize)\n-{\n-\tPrivate *const d = LIBCAMERA_D_PTR();\n-\treturn d->jpegBlobSize(maxJpegBlobSize);\n-}\n+PUBLIC_CAMERA_BUFFER_IMPLEMENTATION\n", "prefixes": [ "libcamera-devel", "v3", "09/10" ] }