Patch Detail
Show a patch.
GET /api/patches/11407/?format=api
{ "id": 11407, "url": "https://patchwork.libcamera.org/api/patches/11407/?format=api", "web_url": "https://patchwork.libcamera.org/patch/11407/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210227180126.37591-2-sebastian.fricke@posteo.net>", "date": "2021-02-27T18:01:25", "name": "[libcamera-devel,v5,1/2] pipeline: rkisp1: Share the ISP subdevice", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "b373fc7cf631f40d6498ef27ddc8ac7c8141ba11", "submitter": { "id": 78, "url": "https://patchwork.libcamera.org/api/people/78/?format=api", "name": "Sebastian Fricke", "email": "sebastian.fricke@posteo.net" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/11407/mbox/", "series": [ { "id": 1732, "url": "https://patchwork.libcamera.org/api/series/1732/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1732", "date": "2021-02-27T18:01:24", "name": "Fix a format mismatch within the RkISP1 pipeline", "version": 5, "mbox": "https://patchwork.libcamera.org/series/1732/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/11407/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/11407/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D0F6FBD1F1\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSat, 27 Feb 2021 18:01:36 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9F50068A72;\n\tSat, 27 Feb 2021 19:01:36 +0100 (CET)", "from mout01.posteo.de (mout01.posteo.de [185.67.36.65])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DD7A9689DD\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 27 Feb 2021 19:01:34 +0100 (CET)", "from submission (posteo.de [89.146.220.130]) \n\tby mout01.posteo.de (Postfix) with ESMTPS id C5B0F16005F\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 27 Feb 2021 19:01:33 +0100 (CET)", "from customer (localhost [127.0.0.1])\n\tby submission (posteo.de) with ESMTPSA id 4DnvV42mxZz9rxS;\n\tSat, 27 Feb 2021 19:01:32 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=posteo.net header.i=@posteo.net\n\theader.b=\"FXU1rH4a\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017;\n\tt=1614448893; bh=8v2dIIDAZbzD4uZU41prjpTu5QO8fG+lZXMxMpGLkic=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=FXU1rH4aY8d+PL/BzScjFmT9plBDpegviOuPwxoMYE/9Z/Xv0yEpMwkE3sSiFzH8k\n\tj1Hcfjm+oK3050PLC3qBkiRLr2Ir3FdtToLkAH/oUQSQS6uuGug09nWgEiB2UhITw4\n\tLDZKX/KNxsXMnpWV8DZ6dKWd+dR7Hvcb6kJj2g2ADTuid5CCotuu4xqsy8MLt8i5Y6\n\tO84aEXIKJaxmBQldBIdaMoCATKGtMzGs4JXrPbwRkNuEbx9rV97L4kmkl3HcEwEdDR\n\thnx7kaCHRM2nHGMl5LWlFJANrnAhsmLl1ZHkGuxzOgl5nyJanTe+YP2v8lluuCoC9C\n\tWfDHO5/F9xONw==", "From": "Sebastian Fricke <sebastian.fricke@posteo.net>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Sat, 27 Feb 2021 19:01:25 +0100", "Message-Id": "<20210227180126.37591-2-sebastian.fricke@posteo.net>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20210227180126.37591-1-sebastian.fricke@posteo.net>", "References": "<20210227180126.37591-1-sebastian.fricke@posteo.net>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v5 1/2] pipeline: rkisp1: Share the ISP\n\tsubdevice", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Share the ISP subdevice between the RkISP1CameraData and the\nPipelineHandlerRkISP1 class. This enables other classes like\nRkISP1CameraConfiguration to get access to the device.\n\nSigned-off-by: Sebastian Fricke <sebastian.fricke@posteo.net>\n---\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 5 ++++-\n 1 file changed, 4 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\nindex 538c0139..50eaa6a4 100644\n--- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n+++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n@@ -90,6 +90,7 @@ public:\n \tStream mainPathStream_;\n \tStream selfPathStream_;\n \tstd::unique_ptr<CameraSensor> sensor_;\n+\tstd::shared_ptr<V4L2Subdevice> isp_;\n \tstd::unique_ptr<DelayedControls> delayedCtrls_;\n \tunsigned int frame_;\n \tstd::vector<IPABuffer> ipaBuffers_;\n@@ -172,7 +173,7 @@ private:\n \tint freeBuffers(Camera *camera);\n \n \tMediaDevice *media_;\n-\tstd::unique_ptr<V4L2Subdevice> isp_;\n+\tstd::shared_ptr<V4L2Subdevice> isp_;\n \tstd::unique_ptr<V4L2VideoDevice> param_;\n \tstd::unique_ptr<V4L2VideoDevice> stat_;\n \n@@ -930,6 +931,8 @@ int PipelineHandlerRkISP1::createCamera(MediaEntity *sensor)\n \tif (ret)\n \t\treturn ret;\n \n+\tdata->isp_ = isp_;\n+\n \t/* Initialize the camera properties. */\n \tdata->properties_ = data->sensor_->properties();\n \n", "prefixes": [ "libcamera-devel", "v5", "1/2" ] }