Patch Detail
Show a patch.
GET /api/patches/1139/?format=api
{ "id": 1139, "url": "https://patchwork.libcamera.org/api/patches/1139/?format=api", "web_url": "https://patchwork.libcamera.org/patch/1139/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20190429191729.29697-12-niklas.soderlund@ragnatech.se>", "date": "2019-04-29T19:17:29", "name": "[libcamera-devel,11/11] libcamera: camera: Lock the pipeline handler in acquire()", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "54d3733de70a5e1b5a6ad3bd04a4fbec4a71248a", "submitter": { "id": 5, "url": "https://patchwork.libcamera.org/api/people/5/?format=api", "name": "Niklas Söderlund", "email": "niklas.soderlund@ragnatech.se" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/1139/mbox/", "series": [ { "id": 284, "url": "https://patchwork.libcamera.org/api/series/284/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=284", "date": "2019-04-29T19:17:18", "name": "libcamerea: Add support for exclusive access to cameras between processes", "version": 1, "mbox": "https://patchwork.libcamera.org/series/284/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/1139/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/1139/checks/", "tags": {}, "headers": { "Return-Path": "<niklas.soderlund@ragnatech.se>", "Received": [ "from bin-mail-out-06.binero.net (bin-mail-out-06.binero.net\n\t[195.74.38.229])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B3BC060E69\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 29 Apr 2019 21:17:55 +0200 (CEST)", "from wyvern.station (unknown [37.182.44.227])\n\tby bin-vsp-out-02.atm.binero.net (Halon) with ESMTPA\n\tid 7d73c0d9-6ab3-11e9-8e2c-005056917f90;\n\tMon, 29 Apr 2019 21:17:55 +0200 (CEST)" ], "X-Halon-ID": "7d73c0d9-6ab3-11e9-8e2c-005056917f90", "Authorized-sender": "niklas@soderlund.pp.se", "From": "=?utf-8?q?Niklas_S=C3=B6derlund?= <niklas.soderlund@ragnatech.se>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 29 Apr 2019 21:17:29 +0200", "Message-Id": "<20190429191729.29697-12-niklas.soderlund@ragnatech.se>", "X-Mailer": "git-send-email 2.21.0", "In-Reply-To": "<20190429191729.29697-1-niklas.soderlund@ragnatech.se>", "References": "<20190429191729.29697-1-niklas.soderlund@ragnatech.se>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 11/11] libcamera: camera: Lock the\n\tpipeline handler in acquire()", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Mon, 29 Apr 2019 19:17:56 -0000" }, "content": "To allow more than one application using libcamera simultaneously there\ncan be no overlap between which cameras are in use by which user. As a\ncamera is part of a pipeline handler and there might be shared resources\nbetween all cameras exposed by that pipeline handler it's not enough to\nto only lock access to a single camera, all cameras from that pipeline\nneed to be tied to the same process.\n\nAllow for this by locking the whole pipeline when one of its cameras\nis acquired by the user. Other processes can still enumerate and list\nall cameras in the system but can't acquire a camera from a locked\npipeline handler.\n\nSigned-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n---\n src/libcamera/camera.cpp | 7 +++++++\n 1 file changed, 7 insertions(+)", "diff": "diff --git a/src/libcamera/camera.cpp b/src/libcamera/camera.cpp\nindex ef9e15be09ece319..95f652e5953b2016 100644\n--- a/src/libcamera/camera.cpp\n+++ b/src/libcamera/camera.cpp\n@@ -489,6 +489,11 @@ int Camera::acquire()\n \tif (!stateIs(CameraAvailable))\n \t\treturn -EBUSY;\n \n+\tif (!pipe_->lock()) {\n+\t\tLOG(Camera, Info) << \"Pipeline handler in use by other process\";\n+\t\treturn -EBUSY;\n+\t}\n+\n \tstate_ = CameraAcquired;\n \n \treturn 0;\n@@ -510,6 +515,8 @@ int Camera::release()\n \tif (!stateBetween(CameraAvailable, CameraConfigured))\n \t\treturn -EBUSY;\n \n+\tpipe_->unlock();\n+\n \tstate_ = CameraAvailable;\n \n \treturn 0;\n", "prefixes": [ "libcamera-devel", "11/11" ] }